[#97536] [Ruby master Bug#16694] JIT vs hardened GCC with PCH — v.ondruch@...
Issue #16694 has been reported by vo.x (Vit Ondruch).
11 messages
2020/03/18
[ruby-core:97384] [Ruby master Bug#16676] `#hash` can change Hash object from ar_table to st_table
From:
ko1@...
Date:
2020-03-06 19:08:58 UTC
List:
ruby-core #97384
Issue #16676 has been updated by ko1 (Koichi Sasada).
Status changed from Open to Closed
4c019f5a626523e99e2827ed917802e3097c380d
c3584dfacce4d0f2058d8403de6fdce4fd4d686b
----------------------------------------
Bug #16676: `#hash` can change Hash object from ar_table to st_table
https://bugs.ruby-lang.org/issues/16676#change-84510
* Author: ko1 (Koichi Sasada)
* Status: Closed
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
* Target version: 2.8
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
# Points
* Hash representation `ar_table` has a problem from Ruby 2.6 (need to backport)
# Problem
From Ruby 2.6 `Hash` object is represented by `ar_table` (for small (<=8) pairs) and `st_table`.
To lookup hash table, `Object#hash` is called to get a hash value, and this method call can modify Hash object.
It means that the code assumes the Hash representation is a `ar_table`, but calling the `#hash` method, it can be a `st_table`.
I believe nobody modify Hash table from `#hash` method (it should be pure, no-side effect method), but multi-threads can modify a Hash object, it can be exposed.
I will commit a patch soon.
# Workaround
To avoid this issue, making a hash table in `st_table`, for example:
```
h = {} # ar_table
10.times{|i| h[i] = i} # st_table because the number of pair == 10 (> 8)
h.clear
```
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>