ruby-dev

2012/6/19 nobu <[email protected]>:
> nobu    2012-06-19 17:51:57 +0900 (Tue, 19 Jun 2012)
>
>  New Revision: 36134
>
>  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=36134
>
>  Log:
>    process.c: no method calls in async-signal-safe
>
>    * process.c (rb_execarg_run_options): do not call any methods in the
>      async-signal-safe function.  mask has been checked with NUM2MODET()
>      already and converted with LONG2NUM().

> Index: process.c
> ===================================================================
> --- process.c   (revision 36133)
> +++ process.c   (revision 36134)
> @@ -17,6 +17,8 @@
>  #include "internal.h"
>  #include "vm_core.h"
>
> +#define STATIC_ASSERT(name, expr) typedef int static_assert_##name##_check[1 - 2*!(expr)]
> +
>  #include <stdio.h>
>  #include <errno.h>
>  #include <signal.h>
> @@ -1595,6 +1597,7 @@
>                                   hide_obj(rb_str_dup(val)));
>         }
>         else if (id == rb_intern("umask")) {
> +           STATIC_ASSERT(sizeof_mode_t, sizeof(long) >= sizeof(mode_t)); /* for LONG2NUM */
>            mode_t cmask = NUM2MODET(val);
>             if (!NIL_P(rb_ary_entry(options, EXEC_OPTION_UMASK))) {
>                 rb_raise(rb_eArgError, "umask option specified twice");
> @@ -2707,7 +2710,7 @@
>
>     obj = rb_ary_entry(options, EXEC_OPTION_UMASK);
>     if (!NIL_P(obj)) {
> -        mode_t mask = NUM2MODET(obj);
> +        mode_t mask = (mode_t)FIX2LONG(obj); /* no method calls */
>         mode_t oldmask = umask(mask); /* never fail */ /* async-signal-safe */
>         if (!NIL_P(soptions))
>             rb_ary_store(soptions, EXEC_OPTION_UMASK, MODET2NUM(oldmask));

どういう状況でこの NUM2MODET からメソッド呼び出しが起こるのか
理解できなかったんですが、どういう話なんでしょう?
-- 
[田中 哲][たなか あきら][Tanaka Akira]

Thread

Prev Next

In This Thread

Prev Next

[#45700] [ruby-trunk - Feature #6528][Open] Add Pathname#write and Pathname#binwrite — "niku (niku _)" <niku@...>

[#45701] [ruby-trunk - Feature #4146] Improvement of Symbol and Proc — "prijutme4ty (Ilya Vorontsov)" <prijutme4ty@...>

[#45702] [ruby-trunk - Feature #6545][Assigned] inconvinient require order of DL — "usa (Usaku NAKAMURA)" <usa@...>

[#45703] test_advise failure on GNU/Linux — Tanaka Akira <tanaka.akira@...>

[#45704] Re: [ANN] Request for "slide-show" of your feature proposal — Yusuke Endoh <mame@...>

[#45708] [ANN] Request for "slide-show" of your feature proposal — Yusuke Endoh <mame@...>

[#45709] [ruby-trunk - Bug #6556][Open] ネストした配列の inspect で segv — "naruse (Yui NARUSE)" <naruse@...>

[#45713] [ruby-trunk - Feature #3946] Array#packのqQ指定子に機種依存サイズフラグ!を追加 — "naruse (Yui NARUSE)" <naruse@...>

[#45715] [ruby-trunk - Feature #3946] Array#packのqQ指定子に機種依存サイズフラグ!を追加 — "usa (Usaku NAKAMURA)" <usa@...>

[#45718] Re: [ruby-changes:23971] yugui:r36022 (trunk): Fixes threading on NativeClient. — KOSAKI Motohiro <kosaki.motohiro@...>

[#45721] [ruby-trunk - Bug #6577][Open] GC中にstack overflowが発生するとSEGVする — "naruse (Yui NARUSE)" <naruse@...>

[#45722] [ruby-trunk - Bug #6581][Open] Array#shuffle, Array#shuffle! の受け付ける引数が想定しづらい — "kachick (Kenichi Kamiya)" <kachick1@...>

[#45723] Developers' meeting (7/21) — Yusuke Endoh <mame@...>

[#45727] Re: [ruby-core:45611] [ruby-trunk - Bug #6124][Rejected] What is the purpose of "fake" gems in Ruby — Urabe Shyouhei <shyouhei@...>

[#45733] [ruby-trunk - Bug #6584][Open] Segmentation fault in DL::TestFunc#test_qsort1 on sparc Solaris10 — "ngoto (Naohisa Goto)" <ngotogenome@...>

[#45735] [ruby-trunk - Feature #6587][Open] proposal: adding new methods File.rootname and Pathname#rootname — "usa (Usaku NAKAMURA)" <usa@...>

[#45742] [ruby-trunk - Bug #6591][Third Party's Issue] r35101以降、古いfccで拡張ライブラリのコンパイルに失敗 — "ngoto (Naohisa Goto)" <ngotogenome@...>

[#45745] Re: [ruby-changes:24028] yugui:r36079 (trunk): Embedding CRuby interpreter without internal headers has been difficult — SASADA Koichi <ko1@...>

[#45746] [ruby-trunk - Bug #6595][Assigned] no skipped information on test-all when -j is specified — "usa (Usaku NAKAMURA)" <usa@...>

[#45752] [ruby-trunk - Bug #6597][Open] README.EXT と README.EXT.ja の内容が違う — "znz (Kazuhiro NISHIYAMA)" <redmine@...>

[#45753] [ruby-trunk - Bug #6598][Open] tool/runruby.rb の File.realpath — "znz (Kazuhiro NISHIYAMA)" <redmine@...>

[#45760] [ruby-trunk - Bug #6603][Open] FileUtils::touchで更新時刻，アクセス時刻がミリ秒単位で記録されない(FreeBSD/amd64) — "skoba (Shinji KOBAYASHI)" <redmine@...>

[#45765] [ruby-trunk - Bug #6604][Assigned] trunkでtest-all が完走しない （-j 使用時のみ） — "kosaki (Motohiro KOSAKI)" <kosaki.motohiro@...>

[#45769] [ruby-trunk - Bug #6606][Open] default_external encoding and STDOUT and UTF-8 — "shyouhei (Shyouhei Urabe)" <shyouhei@...>

[#45772] [ruby-trunk - Bug #6607][Open] rb_thread_blocking_region_begin — "ko1 (Koichi Sasada)" <redmine@...>

[#45780] Re: [ruby-changes:24083] nobu:r36134 (trunk): process.c: no method calls in async-signal-safe — Tanaka Akira <akr@...>

[#45789] [ruby-trunk - Bug #6626][Assigned] Readline.delete_text — "nobu (Nobuyoshi Nakada)" <nobu@...>

[#45794] :new_pgroup and :pgroup option for spawn. — Tanaka Akira <akr@...>

[#45795] [ruby-trunk - Feature #6639][Open] ArgumentError から ArityError を分離 — "metanest (Makoto Kishimoto)" <redmine@...>

[#45796] [ruby-trunk - Feature #4043] グローバル関数current_classの提案 — "metanest (Makoto Kishimoto)" <redmine@...>

[#45810] 開発会議（7/14） — SASADA Koichi <ko1@...>

[#45812] Re: [ruby-cvs:43389] nobu:r36213 (trunk): popen: shell commands with envvar — Tanaka Akira <akr@...>

[#45818] [ruby-trunk - Feature #6643][Open] io.seek(off, :end) — "akr (Akira Tanaka)" <akr@...>

[#45826] Question: Thread#kill doesn't throw Exception — SASADA Koichi <ko1@...>

[#45828] [ruby-trunk - Feature #2080] Proc#to_source, Method#to_source — "ko1 (Koichi Sasada)" <redmine@...>

[#45829] [ruby-trunk - Feature #2447] reduce GC pressure by symbol table without String instance — "ko1 (Koichi Sasada)" <redmine@...>

[#45830] [ruby-trunk - Feature #2674] RubyVM::InstructionSequence to accept IOs — "ko1 (Koichi Sasada)" <redmine@...>

[#45831] [ruby-trunk - Feature #3638][Closed] VM内データ構造へアクセスするマクロ — "ko1 (Koichi Sasada)" <redmine@...>

[#45833] [ruby-trunk - Feature #3251] allow to unlock mutex locked by another thread — "ko1 (Koichi Sasada)" <redmine@...>

[#45839] [ruby-trunk - Feature #3251] allow to unlock mutex locked by another thread — "kosaki (Motohiro KOSAKI)" <kosaki.motohiro@...>

[#45842] [ruby-trunk - Feature #4146] Improvement of Symbol and Proc — "ko1 (Koichi Sasada)" <redmine@...>

[#45854] [ruby-trunk - Feature #6651] Re: [ruby-cvs:43389] nobu:r36213 (trunk): popen: shell commands with envvar — "nobu (Nobuyoshi Nakada)" <nobu@...>

[#45856] [ruby-trunk - Bug #5776] irb のトップレベルで定義したメソッドが public になる — "davidbalbert (David Albert)" <davidbalbert@...>

[#45858] [ruby-trunk - Feature #6651][Closed] Re: [ruby-cvs:43389] nobu:r36213 (trunk): popen: shell commands with envvar — "nobu (Nobuyoshi Nakada)" <nobu@...>

[#45859] [ruby-trunk - Feature #6651] Re: [ruby-cvs:43389] nobu:r36213 (trunk): popen: shell commands with envvar — "nobu (Nobuyoshi Nakada)" <nobu@...>

[#45860] [ruby-trunk - Bug #6657][Open] IRB.fail — "znz (Kazuhiro NISHIYAMA)" <redmine@...>

[#45861] [ruby-trunk - Bug #6659][Open] prepend した Class/Module の ancestors に Class が混入する — "nagachika (Tomoyuki Chikanaga)" <nagachika00@...>

[#45863] [ruby-trunk - Bug #6660][Open] prepend したクラスの instance_methods(false)が空になる — "nagachika (Tomoyuki Chikanaga)" <nagachika00@...>

[#45868] [ruby-trunk - Bug #6662][Open] prepend した Class/Module が継承ツリー上にある Class/Module で ancestors に Class が入り込む — "nagachika (Tomoyuki Chikanaga)" <nagachika00@...>

[#45870] Re: [ruby-cvs:43422] luislavena:r36246 (trunk): * test/win32ole/test_win32ole.rb (test_s_codepage_changed): — Masaki Suketa <masaki.suketa@...>

[#45875] [Backport93 - Backport #6676][Open] ruby1.9.3-p194 + VisualStudio2005 x64版でrubyがビルドできません — "aves_ramphastos (Seigo Ishigane)" <aves.ramphastos.toco@...>

[ruby-dev:45780] Re: [ruby-changes:24083] nobu:r36134 (trunk): process.c: no method calls in async-signal-safe

Thread

In This Thread

[#45765] [ruby-trunk - Bug #6604][Assigned] trunkでtest-all が完走しない（-j 使用時のみ） — "kosaki (Motohiro KOSAKI)" <kosaki.motohiro@...>