[ruby-dev:50459] [Ruby trunk Bug#13957] readline が SHARABLE_MIDDLE_SUBSTRING=1 を考慮していない

From: usa@...
Date: 2018-01-31 13:40:13 UTC
List: ruby-dev #50459
Issue #13957 has been updated by usa (Usaku NAKAMURA).

Backport changed from 2.3: REQUIRED, 2.4: DONE to 2.3: DONE, 2.4: DONE

ruby_2_3 r62140 merged revision(s) 60071.

----------------------------------------
Bug #13957: readline =E3=81=8C SHARABLE_MIDDLE_SUBSTRING=3D1 =E3=82=92=E8=
=80=83=E6=85=AE=E3=81=97=E3=81=A6=E3=81=84=E3=81=AA=E3=81=84
https://bugs.ruby-lang.org/issues/13957#change-70088

* Author: tommy (Masahiro Tomita)
* Status: Closed
* Priority: Normal
* Assignee:=20
* Target version:=20
* ruby -v: ruby 2.5.0dev (2017-09-29 trunk 60062) [x86_64-linux]
* Backport: 2.3: DONE, 2.4: DONE
----------------------------------------
SHARABLE_MIDDLE_SUBSTRING=3D1 =E3=81=A7=E3=82=B3=E3=83=B3=E3=83=91=E3=82=A4=
=E3=83=AB=E3=81=97=E3=81=9FRuby=E3=81=A7=E3=80=81Readline.insert_text =E3=
=81=AE=E6=96=87=E5=AD=97=E5=88=97=E3=81=8C=E6=AD=A3=E3=81=97=E3=81=8F=E6=89=
=B1=E3=82=8F=E3=82=8C=E3=81=BE=E3=81=9B=E3=82=93=E3=80=82

```
% ruby -rreadline -e 'p Readline.insert_text(("a"*100)[0,24]).line_buffer'
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa=
aaaaaaaaaaaaaaaaaaaaaaaaaa"
```

=E6=AC=A1=E3=81=AE=E3=83=91=E3=83=83=E3=83=81=E3=81=A7=E7=9B=B4=E3=82=8B=E3=
=81=A8=E6=80=9D=E3=81=84=E3=81=BE=E3=81=99=E3=80=82

```diff
diff --git a/ext/readline/readline.c b/ext/readline/readline.c
index 253798f9e6..deebc282f5 100644
--- a/ext/readline/readline.c
+++ b/ext/readline/readline.c
@@ -93,6 +93,7 @@ static char **readline_attempted_completion_function(cons=
t char *text,
=20
 #define OutputStringValue(str) do {\
     SafeStringValue(str);\
+    StringValueCStr(str);\
     (str) =3D rb_str_conv_enc((str), rb_enc_get(str), rb_locale_encoding()=
);\
 } while (0)\
=20
```

=E3=83=91=E3=83=83=E3=83=81=E9=81=A9=E7=94=A8=E5=BE=8C

```
% ruby -rreadline -e 'p Readline.insert_text(("a"*100)[0,24]).line_buffer'
"aaaaaaaaaaaaaaaaaaaaaaaa"
```



--=20
https://bugs.ruby-lang.org/

In This Thread

Prev Next