Avoid using HTML tags in translation strings (bp-blogs/bp-blogs-template.php)

[ramiy]

Old string:

• <a href="%1$s">%2$s</a> is your new site. <a href="%3$s">Login</a> as "%4$s" using your existing password.

New strings:

• %s is your new site.
• <a href="%1$s">Login</a> as "%2$s" using your existing password.

---

The attached patch splits the original string into two shorter and easy to translate strings.

Also, replacing <a href="%1$s">%2$s</a> with %s.

[DJPaul]

I don't like this patch because it splits a paragraph into multiple phrases. I expect there may be languages where people want to re-order the sentences, or continue to have just one.

[ramiy]

@DJPaul

This patch is splitting the original string into two strings. The first string is an informative text where you inform the user about the new site. The second string is a call-to-action to login to the site.

[boonebgorges]

Splitting seems acceptable in this case, though not much is gained from the split.

[boonebgorges]

In 10682:

Improve the way blog signup confirmation strings are built.

• Remove markup from the strings, where possible.
• Use core functions to generate URLs, rather than manually concatenating.
• Pass $blog_id to bp_blogs_confirm_blog_signup().

Props ramiy, boonebgorges.
Fixes #6909.