Closed Bug 1073717 Opened 11 years ago Closed 2 years ago

[Web Notifications] Add support for "silent" notifications on desktop

Categories

(Core :: DOM: Push Subscriptions, enhancement, P3)

Product:
Core
Component:
DOM: Push Subscriptions
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox110 --- fixed

People

(Reporter: mikehenrty, Assigned: MattN)

References

(Blocks 2 open bugs,
URL
)

Details

(Whiteboard: [systemsfe])

Attachments

(4 files, 3 obsolete files)

Bug 1073717 - [Web Notifications] Add support for "silent" notifications on macOS. r=mstange
48 bytes, text/x-phabricator-request
Details | Review
Bug 1073717 - [Web Notifications] Add support for "silent" toast notifications on Windows. r=mhowell
48 bytes, text/x-phabricator-request
Details | Review
Bug 1073717 - [Web Notifications] Add support for "silent" notifications with libnotify. r=stransky
48 bytes, text/x-phabricator-request
Details | Review
Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=saschanaz
48 bytes, text/x-phabricator-request
Details | Review
Blocks: 1073020
Blocks: 1049479
Attached file gaia_silent_notifications (obsolete) —
Michael is there any way I can test whether a sound was played?
Attachment #8499520 - Flags: review?(mhenretty)
Moving to p3 because no activity for at least 1 year(s). See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3

I got annoyed at hearing the macOS notification sound every time Google Play Music played a new track (because I enabled notification to see the song name) so I'm taking this. I think it only affects macOS for now.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=679a9f27af26b404fc2edd3065ab4109185a87d5

Assignee: robertbindar → MattN+bmo
Blocks: 1335659
URL: https://notifications.spec.whatwg.org...
Status: NEW → ASSIGNED
See Also: → 1505044
Attachment #8499520 - Attachment is obsolete: true
Attachment #8501356 - Attachment is obsolete: true
Type: defect → enhancement

I am use notification for the transit prediction website TransSee https://www.transsee.ca/ My notifications updates themselves every 10 seconds and would benefit from the silent option.

However I think the deeper problem is that when a notification is updated (by doing a showNotification with the same tag as a previous notification) Firefox is closing and opening a new notification rather then updating the existing notification like Chrome does. This can be seen in that fact that Firefox triggers the notificationclose event every time a notification is updated, unlike Chrome (which I had to work around).

(In reply to Matthew N. [:MattN] from comment #11)

I got annoyed at hearing the macOS notification sound every time Google Play Music played a new track (because I enabled notification to see the song name) so I'm taking this. I think it only affects macOS for now.

It also affects Android. Silent notifications shouldn't cause vibrations and lighting up of the screen.

(In reply to bop from comment #14)

(In reply to Matthew N. [:MattN] from comment #11)

I got annoyed at hearing the macOS notification sound every time Google Play Music played a new track (because I enabled notification to see the song name) so I'm taking this. I think it only affects macOS for now.

It also affects Android. Silent notifications shouldn't cause vibrations and lighting up of the screen.

This was implemented for Android in bug 1696145 but is currently limited to Nightly builds.

Severity: normal → N/A
Depends on: 1696145
Summary: [Web Notifications] Add support for "silent" notifications → [Web Notifications] Add support for "silent" notifications on desktop

Test page: https://bugs.mattn.ca/w3c_notifications.htm (Set the pref dom.webnotifications.silent.enabled to true)

:agi, are there any blockers to shipping silent notifications outside of Nightly on Android?

Flags: needinfo?(agi)

Not that I know of!

Flags: needinfo?(agi)

Any word on merging this PR? Been waiting 5+ years for this, looks like the PR is ready to go.

D119590 has been there over a year since accepted, any reason why it's not landing?

Flags: needinfo?(mozilla+bmo)

Only the macOS portion was accepted. I hadn't got around to re-testing the patches on Linux and Windows since I wrote these patches years ago. I rebased now and will try to test on Windows and Linux when I have a chance. If someone else has time to test and review them sooner then that would be great.

Attachment #9230660 - Attachment description: WIP: Bug 1073717 - [Web Notifications] Add support for "silent" toast notifications on Windows. → Bug 1073717 - [Web Notifications] Add support for "silent" toast notifications on Windows. r=nalexander
Attachment #9230662 - Attachment description: WIP: Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly → Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=masayuki
Attachment #9230661 - Attachment description: WIP: Bug 1073717 - [Web Notifications] Add support for "silent" notifications with libnotify → Bug 1073717 - [Web Notifications] Add support for "silent" notifications with libnotify. r=stransky
Flags: needinfo?(mozilla+bmo)
Attachment #9230662 - Attachment description: Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=masayuki → Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=saschanaz
Attachment #9230662 - Attachment description: Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=saschanaz → Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=masayuki
Attachment #9230660 - Attachment description: Bug 1073717 - [Web Notifications] Add support for "silent" toast notifications on Windows. r=nalexander → Bug 1073717 - [Web Notifications] Add support for "silent" toast notifications on Windows. r=mhowell
Attachment #9230662 - Attachment description: Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=masayuki → Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=saschanaz
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/9e5e59c9399b [Web Notifications] Add support for "silent" notifications on macOS. r=mstange https://hg.mozilla.org/integration/autoland/rev/cf0dac184d52 [Web Notifications] Add support for "silent" toast notifications on Windows. r=mhowell https://hg.mozilla.org/integration/autoland/rev/f6c8c0c6f87b [Web Notifications] Add support for "silent" notifications with libnotify. r=stransky https://hg.mozilla.org/integration/autoland/rev/d2da482646eb [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=saschanaz
Blocks: 1809028
Blocks: 1844584
Component: DOM: Core & HTML → DOM: Notifications
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: