Closed Bug 2009004 Opened 2 days ago Closed 20 hours ago

Navigation API: Implement #dom-navigationprecommitcontroller-addhandler

Categories

(Core :: DOM: Navigation, task)

task

Tracking

()

RESOLVED FIXED
148 Branch
Tracking Status
relnote-firefox --- ?
firefox148 --- fixed

People

(Reporter: jjaschke, Assigned: jjaschke)

Details

Attachments

(1 file)

This was introduced by HTML#11984. The spec PR names bug 2004569 as implementation bug, but it only updates the WPTs and is closed already, hence this new bug.

Assignee: nobody → jjaschke
Status: NEW → ASSIGNED
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/974b0546f470 https://hg.mozilla.org/integration/autoland/rev/74f40e6ee9d0 Revert "Bug 2009004 - Navigation API: Implement #dom-navigationprecommitcontroller-addhandler. r=farre,webidl,smaug,saschanaz" for causing wpt failures.

Reverted this because it was causing wpt failures.

  • Revert link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | /html/dom/idlharness.https.html?exclude=(Document|Window|HTML.+) | NavigationPrecommitController interface: operation addHandler(NavigationInterceptHandler) - assert_own_property: self does not have own property "NavigationPrecommitController" expected property "NavigationPrecommitController" missing
Flags: needinfo?(jjaschke)

Ah, there's android + no ship of course. I updated the expectation and I'll reland.

Flags: needinfo?(jjaschke)
Status: ASSIGNED → RESOLVED
Closed: 20 hours ago
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch

:jjaschke, could you consider nominating this for a release note? (Process info)

Flags: needinfo?(jjaschke)

Release Note Request (optional, but appreciated)
[Why is this notable]: This allows registering a post-commit navigation handler during the pre-commit phase, to allow a multi-step navigation process.
[Affects Firefox for Android]: Yes, but only with SHIP
[Suggested wording]:
[Links (documentation, blog post, etc)]: https://github.com/whatwg/html/issues/11956

relnote-firefox: --- → ?
Flags: needinfo?(jjaschke)

Thanks, added to the Fx148 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx148 release notes.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: