Albert J. Wong | cb00463 | 2018-07-10 22:58:25 | [diff] [blame] | 1 | // Copyright 2013 The Chromium Authors. All rights reserved. |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
danakj | c492bf8 | 2020-09-09 20:02:44 | [diff] [blame] | 5 | #include "content/browser/renderer_host/frame_tree.h" |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 6 | |
avi | b734894 | 2015-12-25 20:57:10 | [diff] [blame] | 7 | #include <stddef.h> |
| 8 | |
| 9 | #include "base/macros.h" |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 10 | #include "base/run_loop.h" |
[email protected] | 7cc7ebd | 2013-10-08 00:59:00 | [diff] [blame] | 11 | #include "base/strings/string_number_conversions.h" |
Lei Zhang | e02299a | 2021-04-26 23:12:24 | [diff] [blame] | 12 | #include "base/strings/stringprintf.h" |
danakj | c492bf8 | 2020-09-09 20:02:44 | [diff] [blame] | 13 | #include "content/browser/renderer_host/navigator.h" |
| 14 | #include "content/browser/renderer_host/render_frame_host_factory.h" |
| 15 | #include "content/browser/renderer_host/render_frame_host_impl.h" |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 16 | #include "content/browser/renderer_host/render_view_host_impl.h" |
[email protected] | 94d0cc1 | 2013-12-18 00:07:41 | [diff] [blame] | 17 | #include "content/browser/web_contents/web_contents_impl.h" |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 18 | #include "content/public/browser/web_contents_observer.h" |
Gabriel Charette | c710874 | 2019-08-23 03:31:40 | [diff] [blame] | 19 | #include "content/public/test/browser_task_environment.h" |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 20 | #include "content/public/test/mock_render_process_host.h" |
| 21 | #include "content/public/test/test_browser_context.h" |
[email protected] | 6b50e36 | 2014-08-15 05:15:59 | [diff] [blame] | 22 | #include "content/test/test_render_frame_host.h" |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 23 | #include "content/test/test_render_view_host.h" |
| 24 | #include "content/test/test_web_contents.h" |
Gyuyoung Kim | 6c9ce902 | 2019-11-26 05:40:08 | [diff] [blame] | 25 | #include "mojo/public/cpp/bindings/pending_receiver.h" |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 26 | #include "testing/gtest/include/gtest/gtest.h" |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 27 | #include "third_party/blink/public/common/frame/frame_owner_element_type.h" |
Blink Reformat | a30d423 | 2018-04-07 15:31:06 | [diff] [blame] | 28 | #include "third_party/blink/public/common/frame/frame_policy.h" |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 29 | #include "third_party/blink/public/common/tokens/tokens.h" |
Julie Jeongeun Kim | 70a2e4e | 2020-02-21 05:09:54 | [diff] [blame] | 30 | #include "third_party/blink/public/mojom/frame/frame_owner_properties.mojom.h" |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 31 | |
| 32 | namespace content { |
dgrogan | fb22f9a | 2014-10-20 21:32:32 | [diff] [blame] | 33 | |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 34 | namespace { |
| 35 | |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 36 | // Appends a description of the structure of the frame tree to |result|. |
| 37 | void AppendTreeNodeState(FrameTreeNode* node, std::string* result) { |
| 38 | result->append( |
Raul Tambre | 6c0c3f5b | 2019-02-04 17:44:17 | [diff] [blame] | 39 | base::NumberToString(node->current_frame_host()->GetRoutingID())); |
schenney | 6408fed2 | 2015-04-17 17:44:57 | [diff] [blame] | 40 | if (!node->current_frame_host()->IsRenderFrameLive()) |
| 41 | result->append("*"); // Asterisk next to dead frames. |
| 42 | |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 43 | if (!node->frame_name().empty()) { |
| 44 | result->append(" '"); |
| 45 | result->append(node->frame_name()); |
| 46 | result->append("'"); |
| 47 | } |
| 48 | result->append(": ["); |
| 49 | const char* separator = ""; |
| 50 | for (size_t i = 0; i < node->child_count(); i++) { |
| 51 | result->append(separator); |
| 52 | AppendTreeNodeState(node->child_at(i), result); |
| 53 | separator = ", "; |
| 54 | } |
| 55 | result->append("]"); |
| 56 | } |
| 57 | |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 58 | mojo::PendingAssociatedRemote<mojom::Frame> CreateStubFrameRemote() { |
| 59 | return TestRenderFrameHost::CreateStubFrameRemote(); |
| 60 | } |
| 61 | |
Oksana Zhuravlova | fee097c | 2019-07-26 17:01:30 | [diff] [blame] | 62 | mojo::PendingReceiver<blink::mojom::BrowserInterfaceBroker> |
| 63 | CreateStubBrowserInterfaceBrokerReceiver() { |
| 64 | return TestRenderFrameHost::CreateStubBrowserInterfaceBrokerReceiver(); |
| 65 | } |
| 66 | |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 67 | blink::mojom::PolicyContainerBindParamsPtr |
| 68 | CreateStubPolicyContainerBindParams() { |
| 69 | return TestRenderFrameHost::CreateStubPolicyContainerBindParams(); |
Antonio Sartori | a1fd143 | 2020-11-25 09:10:20 | [diff] [blame] | 70 | } |
| 71 | |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 72 | // Logs calls to WebContentsObserver along with the state of the frame tree, |
| 73 | // for later use in EXPECT_EQ(). |
| 74 | class TreeWalkingWebContentsLogger : public WebContentsObserver { |
| 75 | public: |
| 76 | explicit TreeWalkingWebContentsLogger(WebContents* web_contents) |
| 77 | : WebContentsObserver(web_contents) {} |
| 78 | |
Peter Boström | 828b902 | 2021-09-21 02:28:43 | [diff] [blame] | 79 | TreeWalkingWebContentsLogger(const TreeWalkingWebContentsLogger&) = delete; |
| 80 | TreeWalkingWebContentsLogger& operator=(const TreeWalkingWebContentsLogger&) = |
| 81 | delete; |
| 82 | |
dcheng | c2282aa | 2014-10-21 12:07:58 | [diff] [blame] | 83 | ~TreeWalkingWebContentsLogger() override { |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 84 | EXPECT_EQ("", log_) << "Activity logged that was not expected"; |
| 85 | } |
| 86 | |
| 87 | // Gets and resets the log, which is a string of what happened. |
| 88 | std::string GetLog() { |
| 89 | std::string result = log_; |
| 90 | log_.clear(); |
| 91 | return result; |
| 92 | } |
| 93 | |
| 94 | // content::WebContentsObserver implementation. |
dcheng | c2282aa | 2014-10-21 12:07:58 | [diff] [blame] | 95 | void RenderFrameCreated(RenderFrameHost* render_frame_host) override { |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 96 | LogWhatHappened("RenderFrameCreated", render_frame_host); |
| 97 | } |
| 98 | |
dcheng | c2282aa | 2014-10-21 12:07:58 | [diff] [blame] | 99 | void RenderFrameHostChanged(RenderFrameHost* old_host, |
| 100 | RenderFrameHost* new_host) override { |
[email protected] | 02d7b6e | 2014-06-24 21:01:50 | [diff] [blame] | 101 | if (old_host) |
nasko | f5940b9f | 2015-03-02 23:04:05 | [diff] [blame] | 102 | LogWhatHappened("RenderFrameHostChanged(old)", old_host); |
| 103 | LogWhatHappened("RenderFrameHostChanged(new)", new_host); |
[email protected] | 02d7b6e | 2014-06-24 21:01:50 | [diff] [blame] | 104 | } |
| 105 | |
dcheng | c2282aa | 2014-10-21 12:07:58 | [diff] [blame] | 106 | void RenderFrameDeleted(RenderFrameHost* render_frame_host) override { |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 107 | LogWhatHappened("RenderFrameDeleted", render_frame_host); |
| 108 | } |
| 109 | |
dcheng | c2282aa | 2014-10-21 12:07:58 | [diff] [blame] | 110 | void RenderProcessGone(base::TerminationStatus status) override { |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 111 | LogWhatHappened("RenderProcessGone"); |
| 112 | } |
| 113 | |
| 114 | private: |
| 115 | void LogWhatHappened(const std::string& event_name) { |
| 116 | if (!log_.empty()) { |
| 117 | log_.append("\n"); |
| 118 | } |
| 119 | log_.append(event_name + " -> "); |
| 120 | AppendTreeNodeState( |
| 121 | static_cast<WebContentsImpl*>(web_contents())->GetFrameTree()->root(), |
| 122 | &log_); |
| 123 | } |
| 124 | |
| 125 | void LogWhatHappened(const std::string& event_name, RenderFrameHost* rfh) { |
| 126 | LogWhatHappened( |
| 127 | base::StringPrintf("%s(%d)", event_name.c_str(), rfh->GetRoutingID())); |
| 128 | } |
| 129 | |
| 130 | std::string log_; |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 131 | }; |
| 132 | |
dgrogan | fb22f9a | 2014-10-20 21:32:32 | [diff] [blame] | 133 | } // namespace |
| 134 | |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 135 | class FrameTreeTest : public RenderViewHostImplTestHarness { |
[email protected] | 7cc7ebd | 2013-10-08 00:59:00 | [diff] [blame] | 136 | protected: |
| 137 | // Prints a FrameTree, for easy assertions of the tree hierarchy. |
| 138 | std::string GetTreeState(FrameTree* frame_tree) { |
| 139 | std::string result; |
[email protected] | fa944cb8 | 2013-11-15 17:51:21 | [diff] [blame] | 140 | AppendTreeNodeState(frame_tree->root(), &result); |
[email protected] | 7cc7ebd | 2013-10-08 00:59:00 | [diff] [blame] | 141 | return result; |
| 142 | } |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 143 | |
| 144 | std::string GetTraversalOrder(FrameTree* frame_tree, |
Alex Moshchuk | 27caae8 | 2017-09-11 23:11:18 | [diff] [blame] | 145 | FrameTreeNode* subtree_to_skip) { |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 146 | std::string result; |
Alex Moshchuk | 27caae8 | 2017-09-11 23:11:18 | [diff] [blame] | 147 | for (FrameTreeNode* node : |
| 148 | frame_tree->NodesExceptSubtree(subtree_to_skip)) { |
dcheng | 57e39e2 | 2016-01-21 00:25:38 | [diff] [blame] | 149 | if (!result.empty()) |
| 150 | result += " "; |
Raul Tambre | 6c0c3f5b | 2019-02-04 17:44:17 | [diff] [blame] | 151 | result += |
| 152 | base::NumberToString(node->current_frame_host()->GetRoutingID()); |
dcheng | 57e39e2 | 2016-01-21 00:25:38 | [diff] [blame] | 153 | } |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 154 | return result; |
| 155 | } |
Jayson Adams | 4db0bfe2 | 2021-07-15 19:24:07 | [diff] [blame] | 156 | |
| 157 | size_t GetIteratorSize(FrameTree::NodeIterator iterator) { |
| 158 | return iterator.queue_.size(); |
| 159 | } |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 160 | }; |
| 161 | |
Jayson Adams | 4db0bfe2 | 2021-07-15 19:24:07 | [diff] [blame] | 162 | // Confirm expected operation of the node queue that supports node iterators. |
| 163 | TEST_F(FrameTreeTest, FrameNodeQueue) { |
| 164 | main_test_rfh()->InitializeRenderFrameIfNeeded(); |
| 165 | |
| 166 | // Use the FrameTree of the WebContents so that it has all the delegates it |
| 167 | // needs. We may want to consider a test version of this. |
| 168 | FrameTree* frame_tree = contents()->GetFrameTree(); |
| 169 | FrameTreeNode* root = frame_tree->root(); |
| 170 | |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 171 | constexpr auto kOwnerType = blink::FrameOwnerElementType::kIframe; |
Jayson Adams | 4db0bfe2 | 2021-07-15 19:24:07 | [diff] [blame] | 172 | int process_id = root->current_frame_host()->GetProcess()->GetID(); |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 173 | frame_tree->AddFrame( |
| 174 | root->current_frame_host(), process_id, 14, CreateStubFrameRemote(), |
| 175 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 176 | CreateStubPolicyContainerBindParams(), |
| 177 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName0", |
| 178 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 179 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 180 | kOwnerType, false); |
| 181 | frame_tree->AddFrame( |
| 182 | root->current_frame_host(), process_id, 15, CreateStubFrameRemote(), |
| 183 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 184 | CreateStubPolicyContainerBindParams(), |
| 185 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName1", |
| 186 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 187 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 188 | kOwnerType, false); |
| 189 | frame_tree->AddFrame( |
| 190 | root->current_frame_host(), process_id, 16, CreateStubFrameRemote(), |
| 191 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 192 | CreateStubPolicyContainerBindParams(), |
| 193 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName2", |
| 194 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 195 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 196 | kOwnerType, false); |
Jayson Adams | 4db0bfe2 | 2021-07-15 19:24:07 | [diff] [blame] | 197 | |
| 198 | EXPECT_EQ(3U, root->child_count()); |
| 199 | FrameTree::NodeIterator node_iterator = frame_tree->Nodes().begin(); |
| 200 | |
| 201 | // Before the iterator advances the frame node queue should be empty. |
| 202 | EXPECT_EQ(0U, GetIteratorSize(node_iterator)); |
| 203 | |
| 204 | std::advance(node_iterator, 1); |
| 205 | |
| 206 | // Advancing the iterator should fill the queue, then pop the first node |
| 207 | // from the front of the queue and make it the current node (available by |
| 208 | // dereferencing the iterator). |
| 209 | EXPECT_EQ(2U, GetIteratorSize(node_iterator)); |
| 210 | EXPECT_EQ(root->child_at(0), *node_iterator); |
| 211 | } |
| 212 | |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 213 | // Exercise tree manipulation routines. |
| 214 | // - Add a series of nodes and verify tree structure. |
| 215 | // - Remove a series of nodes and verify tree structure. |
nasko | 9f2261b | 2015-07-02 11:40:26 | [diff] [blame] | 216 | TEST_F(FrameTreeTest, Shape) { |
nick | 8814e65 | 2015-12-18 01:44:12 | [diff] [blame] | 217 | main_test_rfh()->InitializeRenderFrameIfNeeded(); |
| 218 | |
[email protected] | 94d0cc1 | 2013-12-18 00:07:41 | [diff] [blame] | 219 | // Use the FrameTree of the WebContents so that it has all the delegates it |
| 220 | // needs. We may want to consider a test version of this. |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 221 | FrameTree* frame_tree = contents()->GetFrameTree(); |
[email protected] | 58faf94 | 2014-02-20 21:03:58 | [diff] [blame] | 222 | FrameTreeNode* root = frame_tree->root(); |
[email protected] | 190b8c5 | 2013-11-09 01:35:44 | [diff] [blame] | 223 | |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 224 | std::string no_children_node("no children node"); |
| 225 | std::string deep_subtree("node with deep subtree"); |
dgrogan | fb22f9a | 2014-10-20 21:32:32 | [diff] [blame] | 226 | int process_id = root->current_frame_host()->GetProcess()->GetID(); |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 227 | |
nasko | 9f2261b | 2015-07-02 11:40:26 | [diff] [blame] | 228 | // Do not navigate each frame separately, since that will clutter the test |
| 229 | // itself. Instead, leave them in "not live" state, which is indicated by the |
| 230 | // * after the frame id, since this test cares about the shape, not the |
nick | 8814e65 | 2015-12-18 01:44:12 | [diff] [blame] | 231 | // frame liveness. |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 232 | EXPECT_EQ("1: []", GetTreeState(frame_tree)); |
[email protected] | 7cc7ebd | 2013-10-08 00:59:00 | [diff] [blame] | 233 | |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 234 | constexpr auto kOwnerType = blink::FrameOwnerElementType::kIframe; |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 235 | // Simulate attaching a series of frames to build the frame tree. |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 236 | frame_tree->AddFrame( |
| 237 | root->current_frame_host(), process_id, 14, CreateStubFrameRemote(), |
| 238 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 239 | CreateStubPolicyContainerBindParams(), |
| 240 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName0", |
| 241 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 242 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 243 | kOwnerType, false); |
| 244 | frame_tree->AddFrame( |
| 245 | root->current_frame_host(), process_id, 15, CreateStubFrameRemote(), |
| 246 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 247 | CreateStubPolicyContainerBindParams(), |
| 248 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName1", |
| 249 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 250 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 251 | kOwnerType, false); |
| 252 | frame_tree->AddFrame( |
| 253 | root->current_frame_host(), process_id, 16, CreateStubFrameRemote(), |
| 254 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 255 | CreateStubPolicyContainerBindParams(), |
| 256 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName2", |
| 257 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 258 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 259 | kOwnerType, false); |
| 260 | frame_tree->AddFrame( |
| 261 | root->child_at(0)->current_frame_host(), process_id, 244, |
| 262 | CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
| 263 | CreateStubPolicyContainerBindParams(), |
| 264 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName3", |
| 265 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 266 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 267 | kOwnerType, false); |
| 268 | frame_tree->AddFrame( |
| 269 | root->child_at(1)->current_frame_host(), process_id, 255, |
| 270 | CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
| 271 | CreateStubPolicyContainerBindParams(), |
| 272 | blink::mojom::TreeScopeType::kDocument, no_children_node, "uniqueName4", |
| 273 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 274 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 275 | kOwnerType, false); |
| 276 | frame_tree->AddFrame( |
| 277 | root->child_at(0)->current_frame_host(), process_id, 245, |
| 278 | CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
| 279 | CreateStubPolicyContainerBindParams(), |
| 280 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName5", |
| 281 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 282 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 283 | kOwnerType, false); |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 284 | |
dcheng | 3ce04b6 | 2015-10-26 23:30:55 | [diff] [blame] | 285 | EXPECT_EQ( |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 286 | "1: [14: [244: [], 245: []], " |
nick | 8814e65 | 2015-12-18 01:44:12 | [diff] [blame] | 287 | "15: [255 'no children node': []], " |
| 288 | "16: []]", |
dcheng | 3ce04b6 | 2015-10-26 23:30:55 | [diff] [blame] | 289 | GetTreeState(frame_tree)); |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 290 | |
[email protected] | 58faf94 | 2014-02-20 21:03:58 | [diff] [blame] | 291 | FrameTreeNode* child_16 = root->child_at(2); |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 292 | frame_tree->AddFrame( |
| 293 | child_16->current_frame_host(), process_id, 264, CreateStubFrameRemote(), |
| 294 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 295 | CreateStubPolicyContainerBindParams(), |
| 296 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName6", |
| 297 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 298 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 299 | kOwnerType, false); |
| 300 | frame_tree->AddFrame( |
| 301 | child_16->current_frame_host(), process_id, 265, CreateStubFrameRemote(), |
| 302 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 303 | CreateStubPolicyContainerBindParams(), |
| 304 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName7", |
| 305 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 306 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 307 | kOwnerType, false); |
| 308 | frame_tree->AddFrame( |
| 309 | child_16->current_frame_host(), process_id, 266, CreateStubFrameRemote(), |
| 310 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 311 | CreateStubPolicyContainerBindParams(), |
| 312 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName8", |
| 313 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 314 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 315 | kOwnerType, false); |
| 316 | frame_tree->AddFrame( |
| 317 | child_16->current_frame_host(), process_id, 267, CreateStubFrameRemote(), |
| 318 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 319 | CreateStubPolicyContainerBindParams(), |
| 320 | blink::mojom::TreeScopeType::kDocument, deep_subtree, "uniqueName9", |
| 321 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 322 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 323 | kOwnerType, false); |
| 324 | frame_tree->AddFrame( |
| 325 | child_16->current_frame_host(), process_id, 268, CreateStubFrameRemote(), |
| 326 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 327 | CreateStubPolicyContainerBindParams(), |
| 328 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName10", |
| 329 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 330 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 331 | kOwnerType, false); |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 332 | |
[email protected] | 58faf94 | 2014-02-20 21:03:58 | [diff] [blame] | 333 | FrameTreeNode* child_267 = child_16->child_at(3); |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 334 | frame_tree->AddFrame( |
| 335 | child_267->current_frame_host(), process_id, 365, CreateStubFrameRemote(), |
| 336 | CreateStubBrowserInterfaceBrokerReceiver(), |
| 337 | CreateStubPolicyContainerBindParams(), |
| 338 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName11", |
| 339 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 340 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 341 | kOwnerType, false); |
| 342 | frame_tree->AddFrame( |
| 343 | child_267->child_at(0)->current_frame_host(), process_id, 455, |
| 344 | CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
| 345 | CreateStubPolicyContainerBindParams(), |
| 346 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName12", |
| 347 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
| 348 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
| 349 | kOwnerType, false); |
Alexander Timin | 381e7e18 | 2020-04-28 19:04:03 | [diff] [blame] | 350 | frame_tree->AddFrame( |
| 351 | child_267->child_at(0)->child_at(0)->current_frame_host(), process_id, |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 352 | 555, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 353 | CreateStubPolicyContainerBindParams(), |
| 354 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName13", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 355 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 356 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 357 | kOwnerType, false); |
Alexander Timin | 381e7e18 | 2020-04-28 19:04:03 | [diff] [blame] | 358 | frame_tree->AddFrame( |
| 359 | child_267->child_at(0)->child_at(0)->child_at(0)->current_frame_host(), |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 360 | process_id, 655, CreateStubFrameRemote(), |
| 361 | CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 362 | CreateStubPolicyContainerBindParams(), |
| 363 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName14", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 364 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 365 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 366 | kOwnerType, false); |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 367 | |
[email protected] | 7cc7ebd | 2013-10-08 00:59:00 | [diff] [blame] | 368 | // Now that's it's fully built, verify the tree structure is as expected. |
dcheng | 3ce04b6 | 2015-10-26 23:30:55 | [diff] [blame] | 369 | EXPECT_EQ( |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 370 | "1: [14: [244: [], 245: []], " |
nick | 8814e65 | 2015-12-18 01:44:12 | [diff] [blame] | 371 | "15: [255 'no children node': []], " |
| 372 | "16: [264: [], 265: [], 266: [], " |
| 373 | "267 'node with deep subtree': " |
| 374 | "[365: [455: [555: [655: []]]]], 268: []]]", |
dcheng | 3ce04b6 | 2015-10-26 23:30:55 | [diff] [blame] | 375 | GetTreeState(frame_tree)); |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 376 | |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 377 | // Verify that traversal order is breadth first, even if we skip a subtree. |
| 378 | FrameTreeNode* child_14 = root->child_at(0); |
| 379 | FrameTreeNode* child_15 = root->child_at(1); |
| 380 | FrameTreeNode* child_244 = child_14->child_at(0); |
| 381 | FrameTreeNode* child_245 = child_14->child_at(1); |
[email protected] | 58faf94 | 2014-02-20 21:03:58 | [diff] [blame] | 382 | FrameTreeNode* child_555 = child_267->child_at(0)->child_at(0)->child_at(0); |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 383 | FrameTreeNode* child_655 = child_555->child_at(0); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 384 | EXPECT_EQ("1 14 15 16 244 245 255 264 265 266 267 268 365 455 555 655", |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 385 | GetTraversalOrder(frame_tree, nullptr)); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 386 | EXPECT_EQ("1", GetTraversalOrder(frame_tree, root)); |
| 387 | EXPECT_EQ("1 14 15 16 255 264 265 266 267 268 365 455 555 655", |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 388 | GetTraversalOrder(frame_tree, child_14)); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 389 | EXPECT_EQ("1 14 15 16 244 245 255 264 265 266 267 268 365 455 555 655", |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 390 | GetTraversalOrder(frame_tree, child_244)); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 391 | EXPECT_EQ("1 14 15 16 244 245 255 264 265 266 267 268 365 455 555 655", |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 392 | GetTraversalOrder(frame_tree, child_245)); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 393 | EXPECT_EQ("1 14 15 16 244 245 264 265 266 267 268 365 455 555 655", |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 394 | GetTraversalOrder(frame_tree, child_15)); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 395 | EXPECT_EQ("1 14 15 16 244 245 255 264 265 266 267 268", |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 396 | GetTraversalOrder(frame_tree, child_267)); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 397 | EXPECT_EQ("1 14 15 16 244 245 255 264 265 266 267 268 365 455 555", |
Alex Moshchuk | 27caae8 | 2017-09-11 23:11:18 | [diff] [blame] | 398 | GetTraversalOrder(frame_tree, child_555)); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 399 | EXPECT_EQ("1 14 15 16 244 245 255 264 265 266 267 268 365 455 555 655", |
nick | 4ed97029 | 2016-01-20 21:46:45 | [diff] [blame] | 400 | GetTraversalOrder(frame_tree, child_655)); |
| 401 | |
[email protected] | 58faf94 | 2014-02-20 21:03:58 | [diff] [blame] | 402 | frame_tree->RemoveFrame(child_555); |
dcheng | 3ce04b6 | 2015-10-26 23:30:55 | [diff] [blame] | 403 | EXPECT_EQ( |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 404 | "1: [14: [244: [], 245: []], " |
nick | 8814e65 | 2015-12-18 01:44:12 | [diff] [blame] | 405 | "15: [255 'no children node': []], " |
| 406 | "16: [264: [], 265: [], 266: [], " |
| 407 | "267 'node with deep subtree': " |
| 408 | "[365: [455: []]], 268: []]]", |
dcheng | 3ce04b6 | 2015-10-26 23:30:55 | [diff] [blame] | 409 | GetTreeState(frame_tree)); |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 410 | |
[email protected] | 58faf94 | 2014-02-20 21:03:58 | [diff] [blame] | 411 | frame_tree->RemoveFrame(child_16->child_at(1)); |
dcheng | 3ce04b6 | 2015-10-26 23:30:55 | [diff] [blame] | 412 | EXPECT_EQ( |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 413 | "1: [14: [244: [], 245: []], " |
nick | 8814e65 | 2015-12-18 01:44:12 | [diff] [blame] | 414 | "15: [255 'no children node': []], " |
| 415 | "16: [264: [], 266: [], " |
| 416 | "267 'node with deep subtree': " |
| 417 | "[365: [455: []]], 268: []]]", |
dcheng | 3ce04b6 | 2015-10-26 23:30:55 | [diff] [blame] | 418 | GetTreeState(frame_tree)); |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 419 | |
[email protected] | 58faf94 | 2014-02-20 21:03:58 | [diff] [blame] | 420 | frame_tree->RemoveFrame(root->child_at(1)); |
dcheng | 3ce04b6 | 2015-10-26 23:30:55 | [diff] [blame] | 421 | EXPECT_EQ( |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 422 | "1: [14: [244: [], 245: []], " |
nick | 8814e65 | 2015-12-18 01:44:12 | [diff] [blame] | 423 | "16: [264: [], 266: [], " |
| 424 | "267 'node with deep subtree': " |
| 425 | "[365: [455: []]], 268: []]]", |
dcheng | 3ce04b6 | 2015-10-26 23:30:55 | [diff] [blame] | 426 | GetTreeState(frame_tree)); |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 427 | } |
| 428 | |
creis | 6a93a81 | 2015-04-24 23:13:17 | [diff] [blame] | 429 | // Ensure frames can be found by frame_tree_node_id, routing ID, or name. |
Charlie Reis | b140562 | 2018-04-02 22:52:39 | [diff] [blame] | 430 | TEST_F(FrameTreeTest, FindFrames) { |
lfg | 269b702f | 2015-06-08 19:28:19 | [diff] [blame] | 431 | main_test_rfh()->InitializeRenderFrameIfNeeded(); |
| 432 | |
creis | 6a93a81 | 2015-04-24 23:13:17 | [diff] [blame] | 433 | // Add a few child frames to the main frame. |
| 434 | FrameTree* frame_tree = contents()->GetFrameTree(); |
| 435 | FrameTreeNode* root = frame_tree->root(); |
lfg | 269b702f | 2015-06-08 19:28:19 | [diff] [blame] | 436 | |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 437 | constexpr auto kOwnerType = blink::FrameOwnerElementType::kIframe; |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 438 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 439 | 22, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 440 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 441 | blink::mojom::TreeScopeType::kDocument, "child0", "uniqueName0", false, |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 442 | blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 443 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 444 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 445 | 23, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 446 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 447 | blink::mojom::TreeScopeType::kDocument, "child1", "uniqueName1", false, |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 448 | blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 449 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 450 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 451 | 24, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 452 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 453 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName2", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 454 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 455 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
creis | 6a93a81 | 2015-04-24 23:13:17 | [diff] [blame] | 456 | FrameTreeNode* child0 = root->child_at(0); |
| 457 | FrameTreeNode* child1 = root->child_at(1); |
| 458 | FrameTreeNode* child2 = root->child_at(2); |
| 459 | |
| 460 | // Add one grandchild frame. |
dcheng | 860817a | 2015-05-22 03:16:56 | [diff] [blame] | 461 | child1->current_frame_host()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 462 | 33, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 463 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 464 | blink::mojom::TreeScopeType::kDocument, "grandchild", "uniqueName3", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 465 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 466 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
creis | 6a93a81 | 2015-04-24 23:13:17 | [diff] [blame] | 467 | FrameTreeNode* grandchild = child1->child_at(0); |
| 468 | |
| 469 | // Ensure they can be found by FTN id. |
| 470 | EXPECT_EQ(root, frame_tree->FindByID(root->frame_tree_node_id())); |
| 471 | EXPECT_EQ(child0, frame_tree->FindByID(child0->frame_tree_node_id())); |
| 472 | EXPECT_EQ(child1, frame_tree->FindByID(child1->frame_tree_node_id())); |
| 473 | EXPECT_EQ(child2, frame_tree->FindByID(child2->frame_tree_node_id())); |
| 474 | EXPECT_EQ(grandchild, frame_tree->FindByID(grandchild->frame_tree_node_id())); |
| 475 | EXPECT_EQ(nullptr, frame_tree->FindByID(-1)); |
| 476 | |
| 477 | // Ensure they can be found by routing id. |
| 478 | int process_id = main_test_rfh()->GetProcess()->GetID(); |
| 479 | EXPECT_EQ(root, frame_tree->FindByRoutingID(process_id, |
| 480 | main_test_rfh()->GetRoutingID())); |
| 481 | EXPECT_EQ(child0, frame_tree->FindByRoutingID(process_id, 22)); |
| 482 | EXPECT_EQ(child1, frame_tree->FindByRoutingID(process_id, 23)); |
| 483 | EXPECT_EQ(child2, frame_tree->FindByRoutingID(process_id, 24)); |
| 484 | EXPECT_EQ(grandchild, frame_tree->FindByRoutingID(process_id, 33)); |
| 485 | EXPECT_EQ(nullptr, frame_tree->FindByRoutingID(process_id, 37)); |
| 486 | |
| 487 | // Ensure they can be found by name, if they have one. |
| 488 | EXPECT_EQ(root, frame_tree->FindByName(std::string())); |
| 489 | EXPECT_EQ(child0, frame_tree->FindByName("child0")); |
| 490 | EXPECT_EQ(child1, frame_tree->FindByName("child1")); |
| 491 | EXPECT_EQ(grandchild, frame_tree->FindByName("grandchild")); |
| 492 | EXPECT_EQ(nullptr, frame_tree->FindByName("no such frame")); |
| 493 | } |
| 494 | |
paulmeyer | 322777fb | 2016-05-16 23:15:39 | [diff] [blame] | 495 | // Check that PreviousSibling() and NextSibling() are retrieved correctly. |
| 496 | TEST_F(FrameTreeTest, GetSibling) { |
lfg | 269b702f | 2015-06-08 19:28:19 | [diff] [blame] | 497 | main_test_rfh()->InitializeRenderFrameIfNeeded(); |
| 498 | |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 499 | constexpr auto kOwnerType = blink::FrameOwnerElementType::kIframe; |
alexmos | 9f8705a | 2015-05-06 19:58:59 | [diff] [blame] | 500 | // Add a few child frames to the main frame. |
| 501 | FrameTree* frame_tree = contents()->GetFrameTree(); |
| 502 | FrameTreeNode* root = frame_tree->root(); |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 503 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 504 | 22, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 505 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 506 | blink::mojom::TreeScopeType::kDocument, "child0", "uniqueName0", false, |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 507 | blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 508 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 509 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 510 | 23, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 511 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 512 | blink::mojom::TreeScopeType::kDocument, "child1", "uniqueName1", false, |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 513 | blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 514 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 515 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 516 | 24, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 517 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 518 | blink::mojom::TreeScopeType::kDocument, "child2", "uniqueName2", false, |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 519 | blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 520 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
alexmos | 9f8705a | 2015-05-06 19:58:59 | [diff] [blame] | 521 | FrameTreeNode* child0 = root->child_at(0); |
| 522 | FrameTreeNode* child1 = root->child_at(1); |
| 523 | FrameTreeNode* child2 = root->child_at(2); |
| 524 | |
| 525 | // Add one grandchild frame. |
dcheng | 860817a | 2015-05-22 03:16:56 | [diff] [blame] | 526 | child1->current_frame_host()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 527 | 33, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 528 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 529 | blink::mojom::TreeScopeType::kDocument, "grandchild", "uniqueName3", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 530 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 531 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
alexmos | 9f8705a | 2015-05-06 19:58:59 | [diff] [blame] | 532 | FrameTreeNode* grandchild = child1->child_at(0); |
| 533 | |
paulmeyer | 322777fb | 2016-05-16 23:15:39 | [diff] [blame] | 534 | // Test PreviousSibling(). |
alexmos | 9f8705a | 2015-05-06 19:58:59 | [diff] [blame] | 535 | EXPECT_EQ(nullptr, root->PreviousSibling()); |
| 536 | EXPECT_EQ(nullptr, child0->PreviousSibling()); |
| 537 | EXPECT_EQ(child0, child1->PreviousSibling()); |
| 538 | EXPECT_EQ(child1, child2->PreviousSibling()); |
| 539 | EXPECT_EQ(nullptr, grandchild->PreviousSibling()); |
paulmeyer | 322777fb | 2016-05-16 23:15:39 | [diff] [blame] | 540 | |
| 541 | // Test NextSibling(). |
| 542 | EXPECT_EQ(nullptr, root->NextSibling()); |
| 543 | EXPECT_EQ(child1, child0->NextSibling()); |
| 544 | EXPECT_EQ(child2, child1->NextSibling()); |
| 545 | EXPECT_EQ(nullptr, child2->NextSibling()); |
| 546 | EXPECT_EQ(nullptr, grandchild->NextSibling()); |
alexmos | 9f8705a | 2015-05-06 19:58:59 | [diff] [blame] | 547 | } |
| 548 | |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 549 | // Do some simple manipulations of the frame tree, making sure that |
| 550 | // WebContentsObservers see a consistent view of the tree as we go. |
| 551 | TEST_F(FrameTreeTest, ObserverWalksTreeDuringFrameCreation) { |
| 552 | TreeWalkingWebContentsLogger activity(contents()); |
schenney | 6408fed2 | 2015-04-17 17:44:57 | [diff] [blame] | 553 | contents()->NavigateAndCommit(GURL("http://www.google.com")); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 554 | EXPECT_EQ("RenderFrameCreated(1) -> 1: []", activity.GetLog()); |
schenney | 6408fed2 | 2015-04-17 17:44:57 | [diff] [blame] | 555 | |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 556 | FrameTree* frame_tree = contents()->GetFrameTree(); |
| 557 | FrameTreeNode* root = frame_tree->root(); |
| 558 | |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 559 | constexpr auto kOwnerType = blink::FrameOwnerElementType::kIframe; |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 560 | // Simulate attaching a series of frames to build the frame tree. |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 561 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 562 | 14, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 563 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 564 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName0", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 565 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 566 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
nasko | f5940b9f | 2015-03-02 23:04:05 | [diff] [blame] | 567 | EXPECT_EQ( |
Sreeja Kamishetty | 5b69962 | 2021-01-22 12:54:08 | [diff] [blame] | 568 | "RenderFrameCreated(14) -> 1: [14: []]\n" |
| 569 | "RenderFrameHostChanged(new)(14) -> 1: [14: []]", |
nasko | f5940b9f | 2015-03-02 23:04:05 | [diff] [blame] | 570 | activity.GetLog()); |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 571 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 572 | 18, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 573 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 574 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName1", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 575 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 576 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
nasko | f5940b9f | 2015-03-02 23:04:05 | [diff] [blame] | 577 | EXPECT_EQ( |
Sreeja Kamishetty | 5b69962 | 2021-01-22 12:54:08 | [diff] [blame] | 578 | "RenderFrameCreated(18) -> 1: [14: [], 18: []]\n" |
| 579 | "RenderFrameHostChanged(new)(18) -> 1: [14: [], 18: []]", |
nasko | f5940b9f | 2015-03-02 23:04:05 | [diff] [blame] | 580 | activity.GetLog()); |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 581 | frame_tree->RemoveFrame(root->child_at(0)); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 582 | EXPECT_EQ("RenderFrameDeleted(14) -> 1: [18: []]", activity.GetLog()); |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 583 | frame_tree->RemoveFrame(root->child_at(0)); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 584 | EXPECT_EQ("RenderFrameDeleted(18) -> 1: []", activity.GetLog()); |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 585 | } |
| 586 | |
| 587 | // Make sure that WebContentsObservers see a consistent view of the tree after |
| 588 | // recovery from a render process crash. |
| 589 | TEST_F(FrameTreeTest, ObserverWalksTreeAfterCrash) { |
| 590 | TreeWalkingWebContentsLogger activity(contents()); |
schenney | 6408fed2 | 2015-04-17 17:44:57 | [diff] [blame] | 591 | contents()->NavigateAndCommit(GURL("http://www.google.com")); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 592 | EXPECT_EQ("RenderFrameCreated(1) -> 1: []", activity.GetLog()); |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 593 | |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 594 | constexpr auto kOwnerType = blink::FrameOwnerElementType::kIframe; |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 595 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 596 | 22, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 597 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 598 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName0", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 599 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 600 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
nasko | f5940b9f | 2015-03-02 23:04:05 | [diff] [blame] | 601 | EXPECT_EQ( |
Sreeja Kamishetty | 5b69962 | 2021-01-22 12:54:08 | [diff] [blame] | 602 | "RenderFrameCreated(22) -> 1: [22: []]\n" |
| 603 | "RenderFrameHostChanged(new)(22) -> 1: [22: []]", |
nasko | f5940b9f | 2015-03-02 23:04:05 | [diff] [blame] | 604 | activity.GetLog()); |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 605 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 606 | 23, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 607 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 608 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName1", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 609 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 610 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
nasko | f5940b9f | 2015-03-02 23:04:05 | [diff] [blame] | 611 | EXPECT_EQ( |
Sreeja Kamishetty | 5b69962 | 2021-01-22 12:54:08 | [diff] [blame] | 612 | "RenderFrameCreated(23) -> 1: [22: [], 23: []]\n" |
| 613 | "RenderFrameHostChanged(new)(23) -> 1: [22: [], 23: []]", |
nasko | f5940b9f | 2015-03-02 23:04:05 | [diff] [blame] | 614 | activity.GetLog()); |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 615 | |
| 616 | // Crash the renderer |
nick | 16b0765 | 2015-04-18 02:35:31 | [diff] [blame] | 617 | main_test_rfh()->GetProcess()->SimulateCrash(); |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 618 | EXPECT_EQ( |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 619 | "RenderProcessGone -> 1*: [22*: [], 23*: []]\n" |
| 620 | "RenderFrameDeleted(23) -> 1*: []\n" |
| 621 | "RenderFrameDeleted(22) -> 1*: []\n" |
| 622 | "RenderFrameDeleted(1) -> 1*: []", |
[email protected] | 1426607 | 2014-04-19 00:35:20 | [diff] [blame] | 623 | activity.GetLog()); |
| 624 | } |
| 625 | |
dgrogan | fb22f9a | 2014-10-20 21:32:32 | [diff] [blame] | 626 | // Ensure that frames are not added to the tree, if the process passed in |
| 627 | // is different than the process of the parent node. |
| 628 | TEST_F(FrameTreeTest, FailAddFrameWithWrongProcessId) { |
schenney | 6408fed2 | 2015-04-17 17:44:57 | [diff] [blame] | 629 | contents()->NavigateAndCommit(GURL("http://www.google.com")); |
dgrogan | fb22f9a | 2014-10-20 21:32:32 | [diff] [blame] | 630 | FrameTree* frame_tree = contents()->GetFrameTree(); |
| 631 | FrameTreeNode* root = frame_tree->root(); |
| 632 | int process_id = root->current_frame_host()->GetProcess()->GetID(); |
| 633 | |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 634 | ASSERT_EQ("1: []", GetTreeState(frame_tree)); |
dgrogan | fb22f9a | 2014-10-20 21:32:32 | [diff] [blame] | 635 | |
| 636 | // Simulate attaching a frame from mismatched process id. |
dcheng | 5f60abb | 2015-05-28 01:39:36 | [diff] [blame] | 637 | ASSERT_FALSE(frame_tree->AddFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 638 | root->current_frame_host(), process_id + 1, 1, CreateStubFrameRemote(), |
Oksana Zhuravlova | fee097c | 2019-07-26 17:01:30 | [diff] [blame] | 639 | CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 640 | CreateStubPolicyContainerBindParams(), |
| 641 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName0", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 642 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 643 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), false, |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 644 | blink::FrameOwnerElementType::kIframe, false)); |
Fergal Daly | fd9136d | 2020-03-11 14:53:36 | [diff] [blame] | 645 | ASSERT_EQ("1: []", GetTreeState(frame_tree)); |
dgrogan | fb22f9a | 2014-10-20 21:32:32 | [diff] [blame] | 646 | } |
| 647 | |
nasko | aeca57b | 2015-02-13 00:50:46 | [diff] [blame] | 648 | // Ensure that frames removed while a process has crashed are not preserved in |
| 649 | // the global map of id->frame. |
| 650 | TEST_F(FrameTreeTest, ProcessCrashClearsGlobalMap) { |
lfg | 269b702f | 2015-06-08 19:28:19 | [diff] [blame] | 651 | main_test_rfh()->InitializeRenderFrameIfNeeded(); |
| 652 | |
nasko | aeca57b | 2015-02-13 00:50:46 | [diff] [blame] | 653 | // Add a couple child frames to the main frame. |
| 654 | FrameTreeNode* root = contents()->GetFrameTree()->root(); |
| 655 | |
Kevin McNee | 43fe829 | 2021-10-04 22:59:41 | [diff] [blame^] | 656 | constexpr auto kOwnerType = blink::FrameOwnerElementType::kIframe; |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 657 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 658 | 22, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 659 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 660 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName0", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 661 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 662 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
lukasza | 464d869 | 2016-02-22 19:26:32 | [diff] [blame] | 663 | main_test_rfh()->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 664 | 23, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 665 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 666 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName1", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 667 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 668 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
nasko | aeca57b | 2015-02-13 00:50:46 | [diff] [blame] | 669 | |
dmazzoni | e950ea23 | 2015-03-13 21:39:45 | [diff] [blame] | 670 | // Add one grandchild frame. |
| 671 | RenderFrameHostImpl* child1_rfh = root->child_at(0)->current_frame_host(); |
Ehsan Karamad | 192a8da | 2018-10-21 03:48:08 | [diff] [blame] | 672 | child1_rfh->OnCreateChildFrame( |
danakj | 0bdfacd | 2021-01-20 19:27:18 | [diff] [blame] | 673 | 33, CreateStubFrameRemote(), CreateStubBrowserInterfaceBrokerReceiver(), |
Antonio Sartori | db967c5 | 2021-01-20 09:54:30 | [diff] [blame] | 674 | CreateStubPolicyContainerBindParams(), |
Antonio Gomes | 9d5c1ef | 2020-04-30 20:56:41 | [diff] [blame] | 675 | blink::mojom::TreeScopeType::kDocument, std::string(), "uniqueName2", |
Chris Hamilton | 3ff6ed0e | 2021-02-19 03:54:04 | [diff] [blame] | 676 | false, blink::LocalFrameToken(), base::UnguessableToken::Create(), |
Dave Tapuska | 8444938 | 2020-05-01 00:39:04 | [diff] [blame] | 677 | blink::FramePolicy(), blink::mojom::FrameOwnerProperties(), kOwnerType); |
dmazzoni | e950ea23 | 2015-03-13 21:39:45 | [diff] [blame] | 678 | |
nasko | aeca57b | 2015-02-13 00:50:46 | [diff] [blame] | 679 | // Ensure they can be found by id. |
vishal.b | 782eb5d | 2015-04-29 12:22:57 | [diff] [blame] | 680 | int id1 = root->child_at(0)->frame_tree_node_id(); |
| 681 | int id2 = root->child_at(1)->frame_tree_node_id(); |
| 682 | int id3 = root->child_at(0)->child_at(0)->frame_tree_node_id(); |
dmazzoni | e950ea23 | 2015-03-13 21:39:45 | [diff] [blame] | 683 | EXPECT_TRUE(FrameTreeNode::GloballyFindByID(id1)); |
| 684 | EXPECT_TRUE(FrameTreeNode::GloballyFindByID(id2)); |
| 685 | EXPECT_TRUE(FrameTreeNode::GloballyFindByID(id3)); |
nasko | aeca57b | 2015-02-13 00:50:46 | [diff] [blame] | 686 | |
| 687 | // Crash the renderer. |
nick | 16b0765 | 2015-04-18 02:35:31 | [diff] [blame] | 688 | main_test_rfh()->GetProcess()->SimulateCrash(); |
nasko | aeca57b | 2015-02-13 00:50:46 | [diff] [blame] | 689 | |
| 690 | // Ensure they cannot be found by id after the process has crashed. |
dmazzoni | e950ea23 | 2015-03-13 21:39:45 | [diff] [blame] | 691 | EXPECT_FALSE(FrameTreeNode::GloballyFindByID(id1)); |
| 692 | EXPECT_FALSE(FrameTreeNode::GloballyFindByID(id2)); |
| 693 | EXPECT_FALSE(FrameTreeNode::GloballyFindByID(id3)); |
nasko | aeca57b | 2015-02-13 00:50:46 | [diff] [blame] | 694 | } |
| 695 | |
[email protected] | 9b159a5 | 2013-10-03 17:24:55 | [diff] [blame] | 696 | } // namespace content |