blob: f9967e3a75f1c6241b63d2b21b67d3b21492531c [file] [log] [blame]
[email protected]75e10ff2012-09-04 23:54:131# Copyright (c) 2012 The Chromium Authors. All rights reserved.
2# Use of this source code is governed by a BSD-style license that can be
3# found in the LICENSE file.
4
5"""Top-level presubmit script for isolate.
6
7See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8details on the presubmit API built into gcl.
9"""
10
11
12def CommonChecks(input_api, output_api):
13 output = []
14 disabled_warnings = [
[email protected]bb06d4e2012-09-10 20:47:2015 'F0401', # Unable to import module
[email protected]75e10ff2012-09-04 23:54:1316 'R0401', # Cyclic import
17 'W0613', # Unused argument
18 'E1103', # subprocess.communicate() generates these :(
[email protected]bb06d4e2012-09-10 20:47:2019 'R0201', # method could be function (doesn't reference self)
[email protected]75e10ff2012-09-04 23:54:1320 ]
[email protected]ae8c433c62012-10-30 20:38:3021 black_list = [
22 r'src[\\\/]build_tools[\\\/]tests[\\\/].*',
23 r'src[\\\/]build_tools[\\\/]sdk_tools[\\\/]third_party[\\\/].*',
24 ]
[email protected]75e10ff2012-09-04 23:54:1325 canned = input_api.canned_checks
26 output.extend(canned.RunPylint(input_api, output_api, black_list=black_list,
27 disabled_warnings=disabled_warnings))
28 return output
29
30
31def CheckChangeOnUpload(input_api, output_api):
32 return CommonChecks(input_api, output_api)
33
34
35def CheckChangeOnCommit(input_api, output_api):
36 return CommonChecks(input_api, output_api)
[email protected]356aa542012-09-19 23:31:2937
38
39def GetPreferredTrySlaves(project, change):
40 return ['linux_nacl_sdk', 'win_nacl_sdk', 'mac_nacl_sdk']