Avi Drissman | e4622aa | 2022-09-08 20:36:06 | [diff] [blame] | 1 | // Copyright 2012 The Chromium Authors |
license.bot | bf09a50 | 2008-08-24 00:55:55 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
[email protected] | d26cd527 | 2008-08-07 13:40:16 | [diff] [blame] | 4 | |
danakj | 51d26a4 | 2024-04-25 14:23:56 | [diff] [blame] | 5 | #ifdef UNSAFE_BUFFERS_BUILD |
| 6 | // TODO(crbug.com/40284755): Remove this and spanify to fix the errors. |
| 7 | #pragma allow_unsafe_buffers |
| 8 | #endif |
| 9 | |
dcheng | 093de9b | 2016-04-04 21:25:51 | [diff] [blame] | 10 | #include "base/pickle.h" |
| 11 | |
avi | 9b6f4293 | 2015-12-26 22:15:14 | [diff] [blame] | 12 | #include <limits.h> |
| 13 | #include <stddef.h> |
| 14 | #include <stdint.h> |
| 15 | |
dcheng | 093de9b | 2016-04-04 21:25:51 | [diff] [blame] | 16 | #include <memory> |
[email protected] | d26cd527 | 2008-08-07 13:40:16 | [diff] [blame] | 17 | #include <string> |
Helmut Januschka | 1dce9dc | 2024-06-11 13:05:35 | [diff] [blame] | 18 | #include <string_view> |
Avi Drissman | 933398e | 2022-01-22 00:55:42 | [diff] [blame] | 19 | #include <tuple> |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 20 | |
HuanPo Lin | 27731ca | 2024-04-16 14:57:30 | [diff] [blame] | 21 | #include "base/containers/heap_array.h" |
Avi Drissman | 516e192 | 2024-03-21 18:11:28 | [diff] [blame] | 22 | #include "base/containers/span.h" |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 23 | #include "base/strings/utf_string_conversions.h" |
Daniel Cheng | f45f4760 | 2022-02-28 22:38:32 | [diff] [blame] | 24 | #include "build/build_config.h" |
Matt Menke | 4e486db | 2025-04-07 13:51:43 | [diff] [blame] | 25 | #include "testing/gmock/include/gmock/gmock.h" |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 26 | #include "testing/gtest/include/gtest/gtest.h" |
| 27 | |
brettw | 05cfd8ddb | 2015-06-02 07:02:47 | [diff] [blame] | 28 | namespace base { |
[email protected] | 476dafb | 2013-12-03 00:39:26 | [diff] [blame] | 29 | |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 30 | namespace { |
| 31 | |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 32 | const bool testbool1 = false; |
| 33 | const bool testbool2 = true; |
Peter Kasting | e72b278b | 2018-01-17 05:29:09 | [diff] [blame] | 34 | const int testint = 2'093'847'192; |
| 35 | const long testlong = 1'093'847'192; |
avi | 9b6f4293 | 2015-12-26 22:15:14 | [diff] [blame] | 36 | const uint16_t testuint16 = 32123; |
| 37 | const uint32_t testuint32 = 1593847192; |
Peter Kasting | e72b278b | 2018-01-17 05:29:09 | [diff] [blame] | 38 | const int64_t testint64 = -0x7E8CA925'3104BDFCLL; |
| 39 | const uint64_t testuint64 = 0xCE8CA925'3104BDF7ULL; |
[email protected] | b1f61b03 | 2012-11-28 15:40:58 | [diff] [blame] | 40 | const float testfloat = 3.1415926935f; |
[email protected] | 915cc7d | 2014-07-14 22:50:32 | [diff] [blame] | 41 | const double testdouble = 2.71828182845904523; |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 42 | const std::string teststring("Hello world"); // note non-aligned string length |
Will Harris | 3542dc4 | 2025-01-30 22:13:35 | [diff] [blame] | 43 | const std::string testemptystring(""); |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 44 | const std::wstring testwstring(L"Hello, world"); |
Jan Wilken Dörrie | c92a6d724 | 2021-03-23 17:43:48 | [diff] [blame] | 45 | const std::u16string teststring16(u"Hello, world"); |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 46 | const char testrawstring[] = "Hello new world"; // Test raw string writing |
Jan Wilken Dörrie | 677e0c87 | 2021-03-10 10:04:38 | [diff] [blame] | 47 | // Test raw char16_t writing, assumes UTF16 encoding is ANSI for alpha chars. |
| 48 | const char16_t testrawstring16[] = {'A', 'l', 'o', 'h', 'a', 0}; |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 49 | const char testdata[] = "AAA\0BBB\0"; |
Peter Kasting | 28b51cf | 2022-06-28 15:02:43 | [diff] [blame] | 50 | const size_t testdatalen = std::size(testdata) - 1; |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 51 | |
brucedawson | eaa3896 | 2015-03-10 01:46:50 | [diff] [blame] | 52 | // checks that the results can be read correctly from the Pickle |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 53 | void VerifyResult(const Pickle& pickle) { |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 54 | PickleIterator iter(pickle); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 55 | |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 56 | bool outbool; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 57 | EXPECT_TRUE(iter.ReadBool(&outbool)); |
[email protected] | 1885369 | 2013-01-03 12:30:52 | [diff] [blame] | 58 | EXPECT_FALSE(outbool); |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 59 | EXPECT_TRUE(iter.ReadBool(&outbool)); |
[email protected] | 1885369 | 2013-01-03 12:30:52 | [diff] [blame] | 60 | EXPECT_TRUE(outbool); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 61 | |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 62 | int outint; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 63 | EXPECT_TRUE(iter.ReadInt(&outint)); |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 64 | EXPECT_EQ(testint, outint); |
| 65 | |
| 66 | long outlong; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 67 | EXPECT_TRUE(iter.ReadLong(&outlong)); |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 68 | EXPECT_EQ(testlong, outlong); |
| 69 | |
avi | 9b6f4293 | 2015-12-26 22:15:14 | [diff] [blame] | 70 | uint16_t outuint16; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 71 | EXPECT_TRUE(iter.ReadUInt16(&outuint16)); |
[email protected] | 6d81b48 | 2011-02-22 19:47:19 | [diff] [blame] | 72 | EXPECT_EQ(testuint16, outuint16); |
| 73 | |
avi | 9b6f4293 | 2015-12-26 22:15:14 | [diff] [blame] | 74 | uint32_t outuint32; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 75 | EXPECT_TRUE(iter.ReadUInt32(&outuint32)); |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 76 | EXPECT_EQ(testuint32, outuint32); |
| 77 | |
avi | 9b6f4293 | 2015-12-26 22:15:14 | [diff] [blame] | 78 | int64_t outint64; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 79 | EXPECT_TRUE(iter.ReadInt64(&outint64)); |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 80 | EXPECT_EQ(testint64, outint64); |
| 81 | |
avi | 9b6f4293 | 2015-12-26 22:15:14 | [diff] [blame] | 82 | uint64_t outuint64; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 83 | EXPECT_TRUE(iter.ReadUInt64(&outuint64)); |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 84 | EXPECT_EQ(testuint64, outuint64); |
| 85 | |
[email protected] | b1f61b03 | 2012-11-28 15:40:58 | [diff] [blame] | 86 | float outfloat; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 87 | EXPECT_TRUE(iter.ReadFloat(&outfloat)); |
[email protected] | b1f61b03 | 2012-11-28 15:40:58 | [diff] [blame] | 88 | EXPECT_EQ(testfloat, outfloat); |
| 89 | |
[email protected] | 915cc7d | 2014-07-14 22:50:32 | [diff] [blame] | 90 | double outdouble; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 91 | EXPECT_TRUE(iter.ReadDouble(&outdouble)); |
[email protected] | 915cc7d | 2014-07-14 22:50:32 | [diff] [blame] | 92 | EXPECT_EQ(testdouble, outdouble); |
| 93 | |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 94 | std::string outstring; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 95 | EXPECT_TRUE(iter.ReadString(&outstring)); |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 96 | EXPECT_EQ(teststring, outstring); |
| 97 | |
Will Harris | 3542dc4 | 2025-01-30 22:13:35 | [diff] [blame] | 98 | std::string outstring2; |
| 99 | EXPECT_TRUE(iter.ReadString(&outstring2)); |
| 100 | EXPECT_EQ(testemptystring, outstring2); |
| 101 | |
Jan Wilken Dörrie | 085b2aa | 2021-03-12 16:26:57 | [diff] [blame] | 102 | std::u16string outstring16; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 103 | EXPECT_TRUE(iter.ReadString16(&outstring16)); |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 104 | EXPECT_EQ(teststring16, outstring16); |
| 105 | |
Helmut Januschka | 1dce9dc | 2024-06-11 13:05:35 | [diff] [blame] | 106 | std::string_view outstringpiece; |
brucedawson | eaa3896 | 2015-03-10 01:46:50 | [diff] [blame] | 107 | EXPECT_TRUE(iter.ReadStringPiece(&outstringpiece)); |
| 108 | EXPECT_EQ(testrawstring, outstringpiece); |
| 109 | |
Helmut Januschka | 1dce9dc | 2024-06-11 13:05:35 | [diff] [blame] | 110 | std::u16string_view outstringpiece16; |
brucedawson | eaa3896 | 2015-03-10 01:46:50 | [diff] [blame] | 111 | EXPECT_TRUE(iter.ReadStringPiece16(&outstringpiece16)); |
| 112 | EXPECT_EQ(testrawstring16, outstringpiece16); |
| 113 | |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 114 | const char* outdata; |
Peter Kasting | 28b51cf | 2022-06-28 15:02:43 | [diff] [blame] | 115 | size_t outdatalen; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 116 | EXPECT_TRUE(iter.ReadData(&outdata, &outdatalen)); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 117 | EXPECT_EQ(testdatalen, outdatalen); |
| 118 | EXPECT_EQ(memcmp(testdata, outdata, outdatalen), 0); |
| 119 | |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 120 | // reads past the end should fail |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 121 | EXPECT_FALSE(iter.ReadInt(&outint)); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 122 | } |
| 123 | |
| 124 | } // namespace |
| 125 | |
Avi Drissman | 516e192 | 2024-03-21 18:11:28 | [diff] [blame] | 126 | TEST(PickleTest, UnownedVsOwned) { |
| 127 | const uint8_t buffer[1] = {0x00}; |
| 128 | |
| 129 | Pickle unowned_pickle = Pickle::WithUnownedBuffer(buffer); |
| 130 | EXPECT_EQ(unowned_pickle.GetTotalAllocatedSize(), 0u); |
| 131 | |
| 132 | Pickle owned_pickle = Pickle::WithData(buffer); |
| 133 | EXPECT_GE(unowned_pickle.GetTotalAllocatedSize(), 0u); |
| 134 | } |
| 135 | |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 136 | TEST(PickleTest, EncodeDecode) { |
| 137 | Pickle pickle; |
| 138 | |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 139 | pickle.WriteBool(testbool1); |
| 140 | pickle.WriteBool(testbool2); |
| 141 | pickle.WriteInt(testint); |
| 142 | pickle.WriteLong(testlong); |
| 143 | pickle.WriteUInt16(testuint16); |
| 144 | pickle.WriteUInt32(testuint32); |
| 145 | pickle.WriteInt64(testint64); |
| 146 | pickle.WriteUInt64(testuint64); |
| 147 | pickle.WriteFloat(testfloat); |
| 148 | pickle.WriteDouble(testdouble); |
| 149 | pickle.WriteString(teststring); |
Will Harris | 3542dc4 | 2025-01-30 22:13:35 | [diff] [blame] | 150 | pickle.WriteString(testemptystring); |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 151 | pickle.WriteString16(teststring16); |
| 152 | pickle.WriteString(testrawstring); |
| 153 | pickle.WriteString16(testrawstring16); |
Austin Sullivan | 31fcd06b | 2024-01-10 22:18:29 | [diff] [blame] | 154 | pickle.WriteData(std::string_view(testdata, testdatalen)); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 155 | VerifyResult(pickle); |
| 156 | |
| 157 | // test copy constructor |
| 158 | Pickle pickle2(pickle); |
| 159 | VerifyResult(pickle2); |
| 160 | |
| 161 | // test operator= |
| 162 | Pickle pickle3; |
| 163 | pickle3 = pickle; |
| 164 | VerifyResult(pickle3); |
| 165 | } |
| 166 | |
jam | 03d8a78 | 2016-02-10 20:13:39 | [diff] [blame] | 167 | // Tests that reading/writing a long works correctly when the source process |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 168 | // is 64-bit. We rely on having both 32- and 64-bit trybots to validate both |
| 169 | // arms of the conditional in this test. |
jam | 03d8a78 | 2016-02-10 20:13:39 | [diff] [blame] | 170 | TEST(PickleTest, LongFrom64Bit) { |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 171 | Pickle pickle; |
jam | 03d8a78 | 2016-02-10 20:13:39 | [diff] [blame] | 172 | // Under the hood long is always written as a 64-bit value, so simulate a |
| 173 | // 64-bit long even on 32-bit architectures by explicitly writing an int64_t. |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 174 | pickle.WriteInt64(testint64); |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 175 | |
| 176 | PickleIterator iter(pickle); |
jam | 03d8a78 | 2016-02-10 20:13:39 | [diff] [blame] | 177 | long outlong; |
| 178 | if (sizeof(long) < sizeof(int64_t)) { |
| 179 | // ReadLong() should return false when the original written value can't be |
| 180 | // represented as a long. |
Maksim Ivanov | 88edf97 | 2022-10-21 17:58:16 | [diff] [blame] | 181 | EXPECT_FALSE(iter.ReadLong(&outlong)); |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 182 | } else { |
jam | 03d8a78 | 2016-02-10 20:13:39 | [diff] [blame] | 183 | EXPECT_TRUE(iter.ReadLong(&outlong)); |
| 184 | EXPECT_EQ(testint64, outlong); |
pkasting | 89a19f14 | 2014-10-02 03:01:04 | [diff] [blame] | 185 | } |
| 186 | } |
| 187 | |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 188 | // Tests that we can handle really small buffers. |
| 189 | TEST(PickleTest, SmallBuffer) { |
Avi Drissman | 516e192 | 2024-03-21 18:11:28 | [diff] [blame] | 190 | const uint8_t buffer[] = {0x00}; |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 191 | |
| 192 | // We should not touch the buffer. |
Avi Drissman | 516e192 | 2024-03-21 18:11:28 | [diff] [blame] | 193 | Pickle pickle = Pickle::WithUnownedBuffer(buffer); |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 194 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 195 | PickleIterator iter(pickle); |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 196 | int data; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 197 | EXPECT_FALSE(iter.ReadInt(&data)); |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 198 | } |
| 199 | |
| 200 | // Tests that we can handle improper headers. |
| 201 | TEST(PickleTest, BigSize) { |
Avi Drissman | 516e192 | 2024-03-21 18:11:28 | [diff] [blame] | 202 | const int buffer[4] = {0x56035200, 25, 40, 50}; |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 203 | |
Avi Drissman | 516e192 | 2024-03-21 18:11:28 | [diff] [blame] | 204 | Pickle pickle = Pickle::WithUnownedBuffer(as_byte_span(buffer)); |
David Sanders | 4252759 | 2021-06-16 07:20:38 | [diff] [blame] | 205 | EXPECT_EQ(0U, pickle.size()); |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 206 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 207 | PickleIterator iter(pickle); |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 208 | int data; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 209 | EXPECT_FALSE(iter.ReadInt(&data)); |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 210 | } |
| 211 | |
Nick Diego Yamane | 7676c80 | 2022-01-19 19:02:51 | [diff] [blame] | 212 | // Tests that instances constructed with invalid parameter combinations can be |
| 213 | // properly copied. Regression test for https://crbug.com/1271311. |
| 214 | TEST(PickleTest, CopyWithInvalidHeader) { |
| 215 | // 1. Actual header size (calculated based on the input buffer) > passed in |
| 216 | // buffer size. Which results in Pickle's internal |header_| = null. |
| 217 | { |
| 218 | Pickle::Header header = {.payload_size = 100}; |
Avi Drissman | 516e192 | 2024-03-21 18:11:28 | [diff] [blame] | 219 | const Pickle pickle = Pickle::WithUnownedBuffer(byte_span_from_ref(header)); |
Nick Diego Yamane | 7676c80 | 2022-01-19 19:02:51 | [diff] [blame] | 220 | |
| 221 | EXPECT_EQ(0U, pickle.size()); |
| 222 | EXPECT_FALSE(pickle.data()); |
| 223 | |
| 224 | Pickle copy_built_with_op = pickle; |
| 225 | EXPECT_EQ(0U, copy_built_with_op.size()); |
| 226 | EXPECT_FALSE(copy_built_with_op.data()); |
| 227 | |
| 228 | Pickle copy_built_with_ctor(pickle); |
| 229 | EXPECT_EQ(0U, copy_built_with_ctor.size()); |
| 230 | EXPECT_FALSE(copy_built_with_ctor.data()); |
| 231 | } |
| 232 | // 2. Input buffer's size < sizeof(Pickle::Header). Which must also result in |
| 233 | // Pickle's internal |header_| = null. |
| 234 | { |
Avi Drissman | 516e192 | 2024-03-21 18:11:28 | [diff] [blame] | 235 | const uint8_t data[] = {0x00, 0x00}; |
| 236 | const Pickle pickle = Pickle::WithUnownedBuffer(data); |
Nick Diego Yamane | 7676c80 | 2022-01-19 19:02:51 | [diff] [blame] | 237 | static_assert(sizeof(Pickle::Header) > sizeof(data)); |
| 238 | |
| 239 | EXPECT_EQ(0U, pickle.size()); |
| 240 | EXPECT_FALSE(pickle.data()); |
| 241 | |
| 242 | Pickle copy_built_with_op = pickle; |
| 243 | EXPECT_EQ(0U, copy_built_with_op.size()); |
| 244 | EXPECT_FALSE(copy_built_with_op.data()); |
| 245 | |
| 246 | Pickle copy_built_with_ctor(pickle); |
| 247 | EXPECT_EQ(0U, copy_built_with_ctor.size()); |
| 248 | EXPECT_FALSE(copy_built_with_ctor.data()); |
| 249 | } |
| 250 | } |
| 251 | |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 252 | TEST(PickleTest, UnalignedSize) { |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 253 | int buffer[] = {10, 25, 40, 50}; |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 254 | |
Avi Drissman | 516e192 | 2024-03-21 18:11:28 | [diff] [blame] | 255 | Pickle pickle = Pickle::WithUnownedBuffer(as_byte_span(buffer)); |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 256 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 257 | PickleIterator iter(pickle); |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 258 | int data; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 259 | EXPECT_FALSE(iter.ReadInt(&data)); |
[email protected] | d87f8e6f | 2010-11-15 19:31:23 | [diff] [blame] | 260 | } |
| 261 | |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 262 | TEST(PickleTest, ZeroLenStr) { |
| 263 | Pickle pickle; |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 264 | pickle.WriteString(std::string()); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 265 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 266 | PickleIterator iter(pickle); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 267 | std::string outstr; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 268 | EXPECT_TRUE(iter.ReadString(&outstr)); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 269 | EXPECT_EQ("", outstr); |
| 270 | } |
| 271 | |
thestig | f84f17f | 2015-03-11 20:41:55 | [diff] [blame] | 272 | TEST(PickleTest, ZeroLenStr16) { |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 273 | Pickle pickle; |
Jan Wilken Dörrie | 085b2aa | 2021-03-12 16:26:57 | [diff] [blame] | 274 | pickle.WriteString16(std::u16string()); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 275 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 276 | PickleIterator iter(pickle); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 277 | std::string outstr; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 278 | EXPECT_TRUE(iter.ReadString(&outstr)); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 279 | EXPECT_EQ("", outstr); |
| 280 | } |
| 281 | |
| 282 | TEST(PickleTest, BadLenStr) { |
| 283 | Pickle pickle; |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 284 | pickle.WriteInt(-2); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 285 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 286 | PickleIterator iter(pickle); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 287 | std::string outstr; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 288 | EXPECT_FALSE(iter.ReadString(&outstr)); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 289 | } |
| 290 | |
thestig | f84f17f | 2015-03-11 20:41:55 | [diff] [blame] | 291 | TEST(PickleTest, BadLenStr16) { |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 292 | Pickle pickle; |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 293 | pickle.WriteInt(-1); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 294 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 295 | PickleIterator iter(pickle); |
Jan Wilken Dörrie | 085b2aa | 2021-03-12 16:26:57 | [diff] [blame] | 296 | std::u16string outstr; |
thestig | f84f17f | 2015-03-11 20:41:55 | [diff] [blame] | 297 | EXPECT_FALSE(iter.ReadString16(&outstr)); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 298 | } |
| 299 | |
dskiba | 6f3790a | 2015-09-30 17:24:30 | [diff] [blame] | 300 | TEST(PickleTest, PeekNext) { |
| 301 | struct CustomHeader : base::Pickle::Header { |
| 302 | int cookies[10]; |
| 303 | }; |
| 304 | |
| 305 | Pickle pickle(sizeof(CustomHeader)); |
| 306 | |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 307 | pickle.WriteString("Goooooooooooogle"); |
dskiba | 6f3790a | 2015-09-30 17:24:30 | [diff] [blame] | 308 | |
Claudio DeSouza | c537f85d | 2023-03-02 18:42:52 | [diff] [blame] | 309 | const char* pickle_data = pickle.data_as_char(); |
dskiba | 6f3790a | 2015-09-30 17:24:30 | [diff] [blame] | 310 | |
| 311 | size_t pickle_size; |
| 312 | |
| 313 | // Data range doesn't contain header |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 314 | EXPECT_FALSE(Pickle::PeekNext(sizeof(CustomHeader), pickle_data, |
| 315 | pickle_data + sizeof(CustomHeader) - 1, |
| 316 | &pickle_size)); |
dskiba | 6f3790a | 2015-09-30 17:24:30 | [diff] [blame] | 317 | |
| 318 | // Data range contains header |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 319 | EXPECT_TRUE(Pickle::PeekNext(sizeof(CustomHeader), pickle_data, |
| 320 | pickle_data + sizeof(CustomHeader), |
| 321 | &pickle_size)); |
dskiba | 6f3790a | 2015-09-30 17:24:30 | [diff] [blame] | 322 | EXPECT_EQ(pickle_size, pickle.size()); |
| 323 | |
| 324 | // Data range contains header and some other data |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 325 | EXPECT_TRUE(Pickle::PeekNext(sizeof(CustomHeader), pickle_data, |
| 326 | pickle_data + sizeof(CustomHeader) + 1, |
| 327 | &pickle_size)); |
dskiba | 6f3790a | 2015-09-30 17:24:30 | [diff] [blame] | 328 | EXPECT_EQ(pickle_size, pickle.size()); |
| 329 | |
| 330 | // Data range contains full pickle |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 331 | EXPECT_TRUE(Pickle::PeekNext(sizeof(CustomHeader), pickle_data, |
| 332 | pickle_data + pickle.size(), &pickle_size)); |
dskiba | 6f3790a | 2015-09-30 17:24:30 | [diff] [blame] | 333 | EXPECT_EQ(pickle_size, pickle.size()); |
| 334 | } |
| 335 | |
| 336 | TEST(PickleTest, PeekNextOverflow) { |
| 337 | struct CustomHeader : base::Pickle::Header { |
| 338 | int cookies[10]; |
| 339 | }; |
| 340 | |
| 341 | CustomHeader header; |
| 342 | |
| 343 | // Check if we can wrap around at all |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 344 | if (sizeof(size_t) > sizeof(header.payload_size)) { |
dskiba | 6f3790a | 2015-09-30 17:24:30 | [diff] [blame] | 345 | return; |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 346 | } |
dskiba | 6f3790a | 2015-09-30 17:24:30 | [diff] [blame] | 347 | |
| 348 | const char* pickle_data = reinterpret_cast<const char*>(&header); |
| 349 | |
| 350 | size_t pickle_size; |
| 351 | |
| 352 | // Wrapping around is detected and reported as maximum size_t value |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 353 | header.payload_size = |
| 354 | static_cast<uint32_t>(1 - static_cast<int32_t>(sizeof(CustomHeader))); |
| 355 | EXPECT_TRUE(Pickle::PeekNext(sizeof(CustomHeader), pickle_data, |
| 356 | pickle_data + sizeof(CustomHeader), |
| 357 | &pickle_size)); |
dskiba | 6f3790a | 2015-09-30 17:24:30 | [diff] [blame] | 358 | EXPECT_EQ(pickle_size, std::numeric_limits<size_t>::max()); |
| 359 | |
| 360 | // Ridiculous pickle sizes are fine (callers are supposed to |
| 361 | // verify them) |
| 362 | header.payload_size = |
| 363 | std::numeric_limits<uint32_t>::max() / 2 - sizeof(CustomHeader); |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 364 | EXPECT_TRUE(Pickle::PeekNext(sizeof(CustomHeader), pickle_data, |
| 365 | pickle_data + sizeof(CustomHeader), |
| 366 | &pickle_size)); |
dskiba | 6f3790a | 2015-09-30 17:24:30 | [diff] [blame] | 367 | EXPECT_EQ(pickle_size, std::numeric_limits<uint32_t>::max() / 2); |
| 368 | } |
| 369 | |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 370 | TEST(PickleTest, FindNext) { |
| 371 | Pickle pickle; |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 372 | pickle.WriteInt(1); |
| 373 | pickle.WriteString("Domo"); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 374 | |
| 375 | const char* start = reinterpret_cast<const char*>(pickle.data()); |
| 376 | const char* end = start + pickle.size(); |
| 377 | |
Ivan Kotenkov | a16212a5 | 2017-11-08 12:37:33 | [diff] [blame] | 378 | EXPECT_EQ(end, Pickle::FindNext(pickle.header_size_, start, end)); |
| 379 | EXPECT_EQ(nullptr, Pickle::FindNext(pickle.header_size_, start, end - 1)); |
| 380 | EXPECT_EQ(end, Pickle::FindNext(pickle.header_size_, start, end + 1)); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 381 | } |
| 382 | |
[email protected] | 137d237 | 2011-01-26 13:02:27 | [diff] [blame] | 383 | TEST(PickleTest, FindNextWithIncompleteHeader) { |
| 384 | size_t header_size = sizeof(Pickle::Header); |
HuanPo Lin | 27731ca | 2024-04-16 14:57:30 | [diff] [blame] | 385 | auto buffer = base::HeapArray<char>::Uninit(header_size - 1); |
| 386 | memset(buffer.data(), 0x1, header_size - 1); |
[email protected] | 137d237 | 2011-01-26 13:02:27 | [diff] [blame] | 387 | |
HuanPo Lin | 27731ca | 2024-04-16 14:57:30 | [diff] [blame] | 388 | const char* start = buffer.data(); |
[email protected] | 137d237 | 2011-01-26 13:02:27 | [diff] [blame] | 389 | const char* end = start + header_size - 1; |
| 390 | |
Ivan Kotenkov | a16212a5 | 2017-11-08 12:37:33 | [diff] [blame] | 391 | EXPECT_EQ(nullptr, Pickle::FindNext(header_size, start, end)); |
[email protected] | 137d237 | 2011-01-26 13:02:27 | [diff] [blame] | 392 | } |
| 393 | |
[email protected] | 9dbfa984 | 2013-11-01 09:43:45 | [diff] [blame] | 394 | #if defined(COMPILER_MSVC) |
| 395 | #pragma warning(push) |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 396 | #pragma warning(disable : 4146) |
[email protected] | 9dbfa984 | 2013-11-01 09:43:45 | [diff] [blame] | 397 | #endif |
[email protected] | 33a38dd | 2013-11-01 09:06:26 | [diff] [blame] | 398 | TEST(PickleTest, FindNextOverflow) { |
| 399 | size_t header_size = sizeof(Pickle::Header); |
| 400 | size_t header_size2 = 2 * header_size; |
| 401 | size_t payload_received = 100; |
HuanPo Lin | 27731ca | 2024-04-16 14:57:30 | [diff] [blame] | 402 | auto buffer = base::HeapArray<char>::Uninit(header_size2 + payload_received); |
| 403 | const char* start = buffer.data(); |
| 404 | Pickle::Header* header = reinterpret_cast<Pickle::Header*>(buffer.data()); |
[email protected] | 33a38dd | 2013-11-01 09:06:26 | [diff] [blame] | 405 | const char* end = start + header_size2 + payload_received; |
| 406 | // It is impossible to construct an overflow test otherwise. |
| 407 | if (sizeof(size_t) > sizeof(header->payload_size) || |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 408 | sizeof(uintptr_t) > sizeof(header->payload_size)) { |
[email protected] | 33a38dd | 2013-11-01 09:06:26 | [diff] [blame] | 409 | return; |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 410 | } |
[email protected] | 33a38dd | 2013-11-01 09:06:26 | [diff] [blame] | 411 | |
| 412 | header->payload_size = -(reinterpret_cast<uintptr_t>(start) + header_size2); |
Ivan Kotenkov | a16212a5 | 2017-11-08 12:37:33 | [diff] [blame] | 413 | EXPECT_EQ(nullptr, Pickle::FindNext(header_size2, start, end)); |
[email protected] | 33a38dd | 2013-11-01 09:06:26 | [diff] [blame] | 414 | |
| 415 | header->payload_size = -header_size2; |
Ivan Kotenkov | a16212a5 | 2017-11-08 12:37:33 | [diff] [blame] | 416 | EXPECT_EQ(nullptr, Pickle::FindNext(header_size2, start, end)); |
[email protected] | 33a38dd | 2013-11-01 09:06:26 | [diff] [blame] | 417 | |
| 418 | header->payload_size = 0; |
| 419 | end = start + header_size; |
Ivan Kotenkov | a16212a5 | 2017-11-08 12:37:33 | [diff] [blame] | 420 | EXPECT_EQ(nullptr, Pickle::FindNext(header_size2, start, end)); |
[email protected] | 33a38dd | 2013-11-01 09:06:26 | [diff] [blame] | 421 | } |
[email protected] | 9dbfa984 | 2013-11-01 09:43:45 | [diff] [blame] | 422 | #if defined(COMPILER_MSVC) |
| 423 | #pragma warning(pop) |
| 424 | #endif |
[email protected] | 33a38dd | 2013-11-01 09:06:26 | [diff] [blame] | 425 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 426 | TEST(PickleTest, GetReadPointerAndAdvance) { |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 427 | Pickle pickle; |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 428 | |
| 429 | PickleIterator iter(pickle); |
| 430 | EXPECT_FALSE(iter.GetReadPointerAndAdvance(1)); |
| 431 | |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 432 | pickle.WriteInt(1); |
| 433 | pickle.WriteInt(2); |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 434 | int bytes = sizeof(int) * 2; |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 435 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 436 | EXPECT_TRUE(PickleIterator(pickle).GetReadPointerAndAdvance(0)); |
| 437 | EXPECT_TRUE(PickleIterator(pickle).GetReadPointerAndAdvance(1)); |
| 438 | EXPECT_FALSE(PickleIterator(pickle).GetReadPointerAndAdvance(-1)); |
| 439 | EXPECT_TRUE(PickleIterator(pickle).GetReadPointerAndAdvance(bytes)); |
| 440 | EXPECT_FALSE(PickleIterator(pickle).GetReadPointerAndAdvance(bytes + 1)); |
| 441 | EXPECT_FALSE(PickleIterator(pickle).GetReadPointerAndAdvance(INT_MAX)); |
| 442 | EXPECT_FALSE(PickleIterator(pickle).GetReadPointerAndAdvance(INT_MIN)); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 443 | } |
| 444 | |
| 445 | TEST(PickleTest, Resize) { |
[email protected] | 44a1cbfa | 2008-08-15 01:05:11 | [diff] [blame] | 446 | size_t unit = Pickle::kPayloadUnit; |
HuanPo Lin | 27731ca | 2024-04-16 14:57:30 | [diff] [blame] | 447 | auto data = base::HeapArray<char>::Uninit(unit); |
| 448 | char* data_ptr = data.data(); |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 449 | for (size_t i = 0; i < unit; i++) { |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 450 | data_ptr[i] = 'G'; |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 451 | } |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 452 | |
| 453 | // construct a message that will be exactly the size of one payload unit, |
| 454 | // note that any data will have a 4-byte header indicating the size |
avi | 9b6f4293 | 2015-12-26 22:15:14 | [diff] [blame] | 455 | const size_t payload_size_after_header = unit - sizeof(uint32_t); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 456 | Pickle pickle; |
Austin Sullivan | 31fcd06b | 2024-01-10 22:18:29 | [diff] [blame] | 457 | pickle.WriteData( |
| 458 | std::string_view(data_ptr, payload_size_after_header - sizeof(uint32_t))); |
[email protected] | 44a1cbfa | 2008-08-15 01:05:11 | [diff] [blame] | 459 | size_t cur_payload = payload_size_after_header; |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 460 | |
[email protected] | 2de4626 | 2009-03-16 20:21:57 | [diff] [blame] | 461 | // note: we assume 'unit' is a power of 2 |
[email protected] | d1b319fc | 2013-10-31 04:03:02 | [diff] [blame] | 462 | EXPECT_EQ(unit, pickle.capacity_after_header()); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 463 | EXPECT_EQ(pickle.payload_size(), payload_size_after_header); |
| 464 | |
| 465 | // fill out a full page (noting data header) |
Austin Sullivan | 31fcd06b | 2024-01-10 22:18:29 | [diff] [blame] | 466 | pickle.WriteData(std::string_view(data_ptr, unit - sizeof(uint32_t))); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 467 | cur_payload += unit; |
[email protected] | d1b319fc | 2013-10-31 04:03:02 | [diff] [blame] | 468 | EXPECT_EQ(unit * 2, pickle.capacity_after_header()); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 469 | EXPECT_EQ(cur_payload, pickle.payload_size()); |
| 470 | |
[email protected] | 2de4626 | 2009-03-16 20:21:57 | [diff] [blame] | 471 | // one more byte should double the capacity |
Austin Sullivan | 31fcd06b | 2024-01-10 22:18:29 | [diff] [blame] | 472 | pickle.WriteData(std::string_view(data_ptr, 1u)); |
[email protected] | a15016f | 2014-06-02 23:23:49 | [diff] [blame] | 473 | cur_payload += 8; |
[email protected] | d1b319fc | 2013-10-31 04:03:02 | [diff] [blame] | 474 | EXPECT_EQ(unit * 4, pickle.capacity_after_header()); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 475 | EXPECT_EQ(cur_payload, pickle.payload_size()); |
| 476 | } |
| 477 | |
[email protected] | d26cd527 | 2008-08-07 13:40:16 | [diff] [blame] | 478 | namespace { |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 479 | |
[email protected] | d26cd527 | 2008-08-07 13:40:16 | [diff] [blame] | 480 | struct CustomHeader : Pickle::Header { |
| 481 | int blah; |
| 482 | }; |
| 483 | |
| 484 | } // namespace |
| 485 | |
| 486 | TEST(PickleTest, HeaderPadding) { |
avi | 9b6f4293 | 2015-12-26 22:15:14 | [diff] [blame] | 487 | const uint32_t kMagic = 0x12345678; |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 488 | |
| 489 | Pickle pickle(sizeof(CustomHeader)); |
| 490 | pickle.WriteInt(kMagic); |
| 491 | |
| 492 | // this should not overwrite the 'int' payload |
| 493 | pickle.headerT<CustomHeader>()->blah = 10; |
| 494 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 495 | PickleIterator iter(pickle); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 496 | int result; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 497 | ASSERT_TRUE(iter.ReadInt(&result)); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 498 | |
avi | 9b6f4293 | 2015-12-26 22:15:14 | [diff] [blame] | 499 | EXPECT_EQ(static_cast<uint32_t>(result), kMagic); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 500 | } |
| 501 | |
| 502 | TEST(PickleTest, EqualsOperator) { |
| 503 | Pickle source; |
| 504 | source.WriteInt(1); |
| 505 | |
Avi Drissman | 516e192 | 2024-03-21 18:11:28 | [diff] [blame] | 506 | Pickle copy_refs_source_buffer = Pickle::WithUnownedBuffer(source); |
initial.commit | d7cae12 | 2008-07-26 21:49:38 | [diff] [blame] | 507 | Pickle copy; |
| 508 | copy = copy_refs_source_buffer; |
| 509 | ASSERT_EQ(source.size(), copy.size()); |
[email protected] | d26cd527 | 2008-08-07 13:40:16 | [diff] [blame] | 510 | } |
[email protected] | 8766556 | 2009-06-25 16:54:02 | [diff] [blame] | 511 | |
| 512 | TEST(PickleTest, EvilLengths) { |
| 513 | Pickle source; |
[email protected] | b235357d | 2009-06-25 17:23:49 | [diff] [blame] | 514 | std::string str(100000, 'A'); |
Austin Sullivan | 31fcd06b | 2024-01-10 22:18:29 | [diff] [blame] | 515 | source.WriteData(std::string_view(str.c_str(), 100000u)); |
[email protected] | 8766556 | 2009-06-25 16:54:02 | [diff] [blame] | 516 | // ReadString16 used to have its read buffer length calculation wrong leading |
| 517 | // to out-of-bounds reading. |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 518 | PickleIterator iter(source); |
Jan Wilken Dörrie | 085b2aa | 2021-03-12 16:26:57 | [diff] [blame] | 519 | std::u16string str16; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 520 | EXPECT_FALSE(iter.ReadString16(&str16)); |
[email protected] | 8766556 | 2009-06-25 16:54:02 | [diff] [blame] | 521 | |
| 522 | // And check we didn't break ReadString16. |
Avi Drissman | 516e192 | 2024-03-21 18:11:28 | [diff] [blame] | 523 | str16 = u"A"; |
[email protected] | 8766556 | 2009-06-25 16:54:02 | [diff] [blame] | 524 | Pickle str16_pickle; |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 525 | str16_pickle.WriteString16(str16); |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 526 | iter = PickleIterator(str16_pickle); |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 527 | EXPECT_TRUE(iter.ReadString16(&str16)); |
[email protected] | 8766556 | 2009-06-25 16:54:02 | [diff] [blame] | 528 | EXPECT_EQ(1U, str16.length()); |
| 529 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 530 | // Check we don't fail in a length check with invalid String16 size. |
Jan Wilken Dörrie | 677e0c87 | 2021-03-10 10:04:38 | [diff] [blame] | 531 | // (1<<31) * sizeof(char16_t) == 0, so this is particularly evil. |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 532 | Pickle bad_len; |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 533 | bad_len.WriteInt(1 << 31); |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 534 | iter = PickleIterator(bad_len); |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 535 | EXPECT_FALSE(iter.ReadString16(&str16)); |
[email protected] | 8766556 | 2009-06-25 16:54:02 | [diff] [blame] | 536 | } |
| 537 | |
[email protected] | e64ff5e | 2009-07-28 21:00:03 | [diff] [blame] | 538 | // Check we can write zero bytes of data and 'data' can be NULL. |
| 539 | TEST(PickleTest, ZeroLength) { |
| 540 | Pickle pickle; |
Austin Sullivan | 31fcd06b | 2024-01-10 22:18:29 | [diff] [blame] | 541 | pickle.WriteData(std::string_view()); |
[email protected] | e64ff5e | 2009-07-28 21:00:03 | [diff] [blame] | 542 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 543 | PickleIterator iter(pickle); |
[email protected] | e64ff5e | 2009-07-28 21:00:03 | [diff] [blame] | 544 | const char* outdata; |
Peter Kasting | 28b51cf | 2022-06-28 15:02:43 | [diff] [blame] | 545 | size_t outdatalen; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 546 | EXPECT_TRUE(iter.ReadData(&outdata, &outdatalen)); |
Peter Kasting | 28b51cf | 2022-06-28 15:02:43 | [diff] [blame] | 547 | EXPECT_EQ(0u, outdatalen); |
[email protected] | e64ff5e | 2009-07-28 21:00:03 | [diff] [blame] | 548 | // We can't assert that outdata is NULL. |
| 549 | } |
| 550 | |
[email protected] | 26d2f47 | 2010-03-30 23:52:24 | [diff] [blame] | 551 | // Check that ReadBytes works properly with an iterator initialized to NULL. |
| 552 | TEST(PickleTest, ReadBytes) { |
| 553 | Pickle pickle; |
| 554 | int data = 0x7abcd; |
Daniel Cheng | 0d89f922 | 2017-09-22 05:05:07 | [diff] [blame] | 555 | pickle.WriteBytes(&data, sizeof(data)); |
[email protected] | 26d2f47 | 2010-03-30 23:52:24 | [diff] [blame] | 556 | |
[email protected] | ce208f87 | 2012-03-07 20:42:56 | [diff] [blame] | 557 | PickleIterator iter(pickle); |
Ivan Kotenkov | a16212a5 | 2017-11-08 12:37:33 | [diff] [blame] | 558 | const char* outdata_char = nullptr; |
avi | 48fc13b | 2014-12-28 23:31:48 | [diff] [blame] | 559 | EXPECT_TRUE(iter.ReadBytes(&outdata_char, sizeof(data))); |
[email protected] | 26d2f47 | 2010-03-30 23:52:24 | [diff] [blame] | 560 | |
| 561 | int outdata; |
| 562 | memcpy(&outdata, outdata_char, sizeof(outdata)); |
| 563 | EXPECT_EQ(data, outdata); |
| 564 | } |
brettw | 05cfd8ddb | 2015-06-02 07:02:47 | [diff] [blame] | 565 | |
erikchen | f9ca8f5f0 | 2015-09-08 23:36:29 | [diff] [blame] | 566 | // Checks that when a pickle is deep-copied, the result is not larger than |
| 567 | // needed. |
| 568 | TEST(PickleTest, DeepCopyResize) { |
| 569 | Pickle pickle; |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 570 | while (pickle.capacity_after_header() != pickle.payload_size()) { |
erikchen | f9ca8f5f0 | 2015-09-08 23:36:29 | [diff] [blame] | 571 | pickle.WriteBool(true); |
Peter Kasting | 134ef9af | 2024-12-28 02:30:09 | [diff] [blame] | 572 | } |
erikchen | f9ca8f5f0 | 2015-09-08 23:36:29 | [diff] [blame] | 573 | |
| 574 | // Make a deep copy. |
| 575 | Pickle pickle2(pickle); |
| 576 | |
| 577 | // Check that there isn't any extraneous capacity. |
| 578 | EXPECT_EQ(pickle.capacity_after_header(), pickle2.capacity_after_header()); |
| 579 | } |
| 580 | |
rockot | 0776a50 | 2015-12-17 06:19:49 | [diff] [blame] | 581 | namespace { |
| 582 | |
| 583 | // Publicly exposes the ClaimBytes interface for testing. |
| 584 | class TestingPickle : public Pickle { |
| 585 | public: |
Chris Watkins | bb7211c | 2017-11-29 07:16:38 | [diff] [blame] | 586 | TestingPickle() = default; |
rockot | 0776a50 | 2015-12-17 06:19:49 | [diff] [blame] | 587 | |
| 588 | void* ClaimBytes(size_t num_bytes) { return Pickle::ClaimBytes(num_bytes); } |
| 589 | }; |
| 590 | |
| 591 | } // namespace |
| 592 | |
| 593 | // Checks that claimed bytes are zero-initialized. |
| 594 | TEST(PickleTest, ClaimBytesInitialization) { |
| 595 | static const int kChunkSize = 64; |
| 596 | TestingPickle pickle; |
| 597 | const char* bytes = static_cast<const char*>(pickle.ClaimBytes(kChunkSize)); |
| 598 | for (size_t i = 0; i < kChunkSize; ++i) { |
| 599 | EXPECT_EQ(0, bytes[i]); |
| 600 | } |
| 601 | } |
| 602 | |
| 603 | // Checks that ClaimBytes properly advances the write offset. |
| 604 | TEST(PickleTest, ClaimBytes) { |
| 605 | std::string data("Hello, world!"); |
| 606 | |
| 607 | TestingPickle pickle; |
jam | 03d8a78 | 2016-02-10 20:13:39 | [diff] [blame] | 608 | pickle.WriteUInt32(data.size()); |
rockot | 0776a50 | 2015-12-17 06:19:49 | [diff] [blame] | 609 | void* bytes = pickle.ClaimBytes(data.size()); |
| 610 | pickle.WriteInt(42); |
| 611 | memcpy(bytes, data.data(), data.size()); |
| 612 | |
| 613 | PickleIterator iter(pickle); |
jam | 03d8a78 | 2016-02-10 20:13:39 | [diff] [blame] | 614 | uint32_t out_data_length; |
| 615 | EXPECT_TRUE(iter.ReadUInt32(&out_data_length)); |
rockot | 0776a50 | 2015-12-17 06:19:49 | [diff] [blame] | 616 | EXPECT_EQ(data.size(), out_data_length); |
| 617 | |
| 618 | const char* out_data = nullptr; |
| 619 | EXPECT_TRUE(iter.ReadBytes(&out_data, out_data_length)); |
| 620 | EXPECT_EQ(data, std::string(out_data, out_data_length)); |
| 621 | |
| 622 | int out_value; |
| 623 | EXPECT_TRUE(iter.ReadInt(&out_value)); |
| 624 | EXPECT_EQ(42, out_value); |
| 625 | } |
| 626 | |
Daniel Cheng | ea877be | 2020-03-06 22:56:31 | [diff] [blame] | 627 | TEST(PickleTest, ReachedEnd) { |
| 628 | Pickle pickle; |
| 629 | pickle.WriteInt(1); |
| 630 | pickle.WriteInt(2); |
| 631 | pickle.WriteInt(3); |
| 632 | |
| 633 | PickleIterator iter(pickle); |
| 634 | int out; |
| 635 | |
| 636 | EXPECT_FALSE(iter.ReachedEnd()); |
| 637 | EXPECT_TRUE(iter.ReadInt(&out)); |
| 638 | EXPECT_EQ(1, out); |
| 639 | |
| 640 | EXPECT_FALSE(iter.ReachedEnd()); |
| 641 | EXPECT_TRUE(iter.ReadInt(&out)); |
| 642 | EXPECT_EQ(2, out); |
| 643 | |
| 644 | EXPECT_FALSE(iter.ReachedEnd()); |
| 645 | EXPECT_TRUE(iter.ReadInt(&out)); |
| 646 | EXPECT_EQ(3, out); |
| 647 | |
| 648 | EXPECT_TRUE(iter.ReachedEnd()); |
| 649 | EXPECT_FALSE(iter.ReadInt(&out)); |
| 650 | EXPECT_TRUE(iter.ReachedEnd()); |
| 651 | } |
| 652 | |
David Benjamin | 5746c53 | 2023-10-25 15:16:10 | [diff] [blame] | 653 | // Test that reading a value other than 0 or 1 as a bool does not trigger |
| 654 | // UBSan. |
| 655 | TEST(PickleTest, NonCanonicalBool) { |
| 656 | Pickle pickle; |
| 657 | pickle.WriteInt(0xff); |
| 658 | |
| 659 | PickleIterator iter(pickle); |
| 660 | bool b; |
| 661 | ASSERT_TRUE(iter.ReadBool(&b)); |
| 662 | EXPECT_TRUE(b); |
| 663 | } |
| 664 | |
Matt Menke | 4e486db | 2025-04-07 13:51:43 | [diff] [blame] | 665 | // Tests the ReadData() overload that returns a span. |
| 666 | TEST(PickleTest, ReadDataAsSpan) { |
| 667 | constexpr auto kWriteData = |
| 668 | std::to_array<uint8_t>({0x01, 0x02, 0x03, 0x61, 0x62, 0x63}); |
| 669 | |
| 670 | Pickle pickle; |
| 671 | pickle.WriteData(kWriteData); |
| 672 | pickle.WriteData(base::span<const uint8_t>()); |
| 673 | |
| 674 | PickleIterator iter(pickle); |
| 675 | EXPECT_THAT(iter.ReadData(), testing::Optional(kWriteData)); |
| 676 | EXPECT_THAT(iter.ReadData(), testing::Optional(base::span<const uint8_t>())); |
| 677 | EXPECT_FALSE(iter.ReadData()); |
| 678 | } |
| 679 | |
| 680 | // Tests the ReadBytes() overload that returns a span. |
| 681 | TEST(PickleTest, ReadBytesAsSpan) { |
| 682 | constexpr auto kWriteData = |
| 683 | std::to_array<uint8_t>({0x01, 0x02, 0x03, 0x61, 0x62, 0x63}); |
| 684 | |
| 685 | Pickle pickle; |
| 686 | pickle.WriteBytes(kWriteData); |
| 687 | |
| 688 | PickleIterator iter(pickle); |
| 689 | EXPECT_THAT(iter.ReadBytes(kWriteData.size()), testing::Optional(kWriteData)); |
| 690 | EXPECT_FALSE(iter.ReadBytes(kWriteData.size())); |
| 691 | } |
| 692 | |
brettw | 05cfd8ddb | 2015-06-02 07:02:47 | [diff] [blame] | 693 | } // namespace base |