QTest::CrashHandler: move the Unix async-safe I/O code to the .cpp

This declutters the header from code that doesn't need to be there and
is only used in the .cpp anyway. This code used to be in qtestcase.cpp
before commit c0014becca2cd376eadd5c8a0265e5cf47c9aa01, which we now
amend. Additionally, since Windows code doesn't need to be async-safe
anyway, we can simplify it.

I'm also going to need the toHexString() lambda in another place.

Change-Id: Ic9571bac864dfb31564cfffd785e8ab15cab3ae5
Reviewed-by: Edward Welbourne <[email protected]>
Reviewed-by: Ahmad Samir <[email protected]>

1 files changed, 5 insertions, 3 deletions

diff --git a/src/testlib/qtestcrashhandler_win.cpp b/src/testlib/qtestcrashhandler_win.cpp
index f814a6bc68e..6a9f610eabd 100644
--- a/src/testlib/qtestcrashhandler_win.cpp
+++ b/src/testlib/qtestcrashhandler_win.cpp
@@ -51,9 +51,11 @@ void printTestRunTime()
     const int msecsFunctionTime = qRound(QTestLog::msecsFunctionTime());
     const int msecsTotalTime = qRound(QTestLog::msecsTotalTime());
     const char *const name = QTest::currentTestFunction();
-    writeToStderr("\n         ", name ? name : "[Non-test]",
-                  " function time: ", asyncSafeToString(msecsFunctionTime),
-                  "ms, total time: ", asyncSafeToString(msecsTotalTime), "ms\n");
+
+    // Windows doesn't have the concept of async-safety, so fprintf() is
+    // probably as good as WriteFile() and WriteConsole().
+    fprintf(stderr, "\n         %s function time: %dms, total time: %dms\n",
+            name ? name : "[Non-test]", msecsFunctionTime, msecsTotalTime);
 }
 
 void generateStackTrace()