QtTest: port from qsnprintf to std::snprintf and mark the module as qsnprintf-free

Drive-by remove an explicit NUL-termination (std::snprintf() does
that) and port a repeated use of printf argument checking to the
protect() idiom.

Pick-to: 6.8
Change-Id: Ida15940fe9aef0622e9836a229a398c909503a9a
Reviewed-by: Volker Hilsheimer <[email protected]>

1 files changed, 4 insertions, 2 deletions

diff --git a/src/testlib/qtestlog.cpp b/src/testlib/qtestlog.cpp
index 89149f3d47a..39178feb2b7 100644
--- a/src/testlib/qtestlog.cpp
+++ b/src/testlib/qtestlog.cpp
@@ -30,6 +30,8 @@
 #include <QtCore/QRegularExpression>
 #endif
 
+#include <cstdio>
+
 #include <stdlib.h>
 #include <string.h>
 #include <limits.h>
@@ -194,8 +196,8 @@ namespace QTest {
 
             const size_t maxMsgLen = 1024;
             char msg[maxMsgLen] = {'\0'};
-            qsnprintf(msg, maxMsgLen, "Received a warning that resulted in a failure:\n%s",
-                      qPrintable(message));
+            std::snprintf(msg, maxMsgLen, "Received a warning that resulted in a failure:\n%s",
+                          qPrintable(message));
             QTestResult::addFailure(msg, context.file, context.line);
             return true;
         }