Port from container.count()/length() to size()

This is semantic patch using ClangTidyTransformator:

  auto QtContainerClass = expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)
  makeRule(cxxMemberCallExpr(on(QtContainerClass),
                             callee(cxxMethodDecl(hasAnyName({"count", "length"),
                                                  parameterCountIs(0))))),
           changeTo(cat(access(o, cat("size"), "()"))),
           cat("use 'size()' instead of 'count()/length()'"))

a.k.a qt-port-to-std-compatible-api with config Scope: 'Container'.

<classes> are:

    // sequential:
    "QByteArray",
    "QList",
    "QQueue",
    "QStack",
    "QString",
    "QVarLengthArray",
    "QVector",
    // associative:
    "QHash",
    "QMultiHash",
    "QMap",
    "QMultiMap",
    "QSet",
    // Qt has no QMultiSet

Change-Id: Ibe8837be96e8d30d1846881ecd65180c1bc459af
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Volker Hilsheimer <[email protected]>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp b/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp
index 70335293268..5479d7425ac 100644
--- a/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp
+++ b/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp
@@ -424,14 +424,14 @@ static QString stringify(const QString &data)
 {
     QString retval;
     qsizetype i;
-    for (i = 0; i < data.length(); ++i) {
+    for (i = 0; i < data.size(); ++i) {
         retval += u'\"';
-        for ( ; i < data.length() && data[i] != u'\n' && data[i] != u'\r'; ++i)
+        for ( ; i < data.size() && data[i] != u'\n' && data[i] != u'\r'; ++i)
             if (data[i] == u'\"')
                 retval += "\\\""_L1;
             else
                 retval += data[i];
-        if (i+1 < data.length() && data[i] == u'\r' && data[i+1] == u'\n')
+        if (i+1 < data.size() && data[i] == u'\r' && data[i+1] == u'\n')
             i++;
         retval += "\\n\"\n"_L1;
     }