diff options
author | Marc Mutz <[email protected]> | 2015-06-20 12:58:10 +0200 |
---|---|---|
committer | Marc Mutz <[email protected]> | 2015-06-21 13:42:49 +0000 |
commit | 2422251ee5025a067b14b989153764ab36e43f10 (patch) | |
tree | 8758c5b128a38f0aa6266a156385112aa3527e03 /src/tools/qdoc/qmlmarkupvisitor.h | |
parent | 08e0963e0862726feaa10c09b0e3b401c89b9224 (diff) |
qdoc: don't hold QQmlJS::AST::SourceLocation in QLists
QQmlJS::AST::SourceLocation wasn't marked as movable, and it is larger
than void*, so QList<SourceLocation> is horribly inefficient.
Fix by marking as movable primitive and holding in QVector instead.
The same fix probably is required in QtDeclarative, too.
Change-Id: I4e0d2cd32b7e03205d59cbc9900287f77045154a
Reviewed-by: Martin Smith <[email protected]>
Diffstat (limited to 'src/tools/qdoc/qmlmarkupvisitor.h')
-rw-r--r-- | src/tools/qdoc/qmlmarkupvisitor.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/tools/qdoc/qmlmarkupvisitor.h b/src/tools/qdoc/qmlmarkupvisitor.h index 04d6a57564e..34d18d6868d 100644 --- a/src/tools/qdoc/qmlmarkupvisitor.h +++ b/src/tools/qdoc/qmlmarkupvisitor.h @@ -50,7 +50,7 @@ public: }; QmlMarkupVisitor(const QString &code, - const QList<QQmlJS::AST::SourceLocation> &pragmas, + const QVector<QQmlJS::AST::SourceLocation> &pragmas, QQmlJS::Engine *engine); virtual ~QmlMarkupVisitor(); @@ -158,7 +158,7 @@ private: QQmlJS::Engine *engine; QList<ExtraType> extraTypes; - QList<QQmlJS::AST::SourceLocation> extraLocations; + QVector<QQmlJS::AST::SourceLocation> extraLocations; QString source; QString output; quint32 cursor; |