diff options
| author | Konstantin Ritt <[email protected]> | 2015-01-23 13:05:12 +0400 |
|---|---|---|
| committer | Konstantin Ritt <[email protected]> | 2015-02-13 16:29:16 +0000 |
| commit | 9b67d89c24666d405dd00e63bb56c924738aa002 (patch) | |
| tree | bf0c0197b68097e9aace8ac3708dcbf0e3fe0c7c /src/tools/uic/cpp/cppwriteicondata.cpp | |
| parent | 22b5c39e8e0f4d8cb8a2b2d661e0451e01b75929 (diff) | |
Pass params of shareable type by const-ref rather than by value
...where passing them by value was not intentional.
Change-Id: Ifd5036d57b41fddeeacfbd3f5890881605b80647
Reviewed-by: Shawn Rutledge <[email protected]>
Reviewed-by: Thiago Macieira <[email protected]>
Diffstat (limited to 'src/tools/uic/cpp/cppwriteicondata.cpp')
| -rw-r--r-- | src/tools/uic/cpp/cppwriteicondata.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/tools/uic/cpp/cppwriteicondata.cpp b/src/tools/uic/cpp/cppwriteicondata.cpp index 51b37b191f0..ee80ee16433 100644 --- a/src/tools/uic/cpp/cppwriteicondata.cpp +++ b/src/tools/uic/cpp/cppwriteicondata.cpp @@ -42,7 +42,7 @@ QT_BEGIN_NAMESPACE namespace CPP { -static QByteArray transformImageData(QString data) +static QByteArray transformImageData(const QString &data) { int baSize = data.length() / 2; uchar *ba = new uchar[baSize]; @@ -66,7 +66,7 @@ static QByteArray transformImageData(QString data) return ret; } -static QByteArray unzipXPM(QString data, ulong& length) +static QByteArray unzipXPM(const QString &data, ulong &length) { #ifndef QT_NO_COMPRESS const int lengthOffset = 4; |