diff options
author | Axel Spoerl <[email protected]> | 2022-01-14 09:04:31 +0100 |
---|---|---|
committer | Axel Spoerl <[email protected]> | 2022-01-17 21:24:27 +0100 |
commit | fd93c298d6fab70db5a1ce65eed41d929635e8b9 (patch) | |
tree | 1954e16bbbecb358a01a5088877025924aaa6ecb /tests/baseline/shared/qwidgetbaselinetest.cpp | |
parent | 6ee2664883391c14b44eb9f959782c96e42def8b (diff) |
Prevent takeStandardSnapshots() from stopping on first mismatch
Force takeStandardSnapshots() to take and log all snapshots before
launching QFAIL. Macros QBASELINE_CHECK_DEFERRED and
QBASELINE_CHECK_DEFERRED_SUM have been added in qbaselinetest.h
Task-number: QTBUG-99790
Pick-to: 6.3
Change-Id: Ia015de808f354e842ac4029c5c84be18c4a4e209
Reviewed-by: Volker Hilsheimer <[email protected]>
Diffstat (limited to 'tests/baseline/shared/qwidgetbaselinetest.cpp')
-rw-r--r-- | tests/baseline/shared/qwidgetbaselinetest.cpp | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/tests/baseline/shared/qwidgetbaselinetest.cpp b/tests/baseline/shared/qwidgetbaselinetest.cpp index 1553a2d82f3..e4b36ddb69a 100644 --- a/tests/baseline/shared/qwidgetbaselinetest.cpp +++ b/tests/baseline/shared/qwidgetbaselinetest.cpp @@ -149,7 +149,7 @@ void QWidgetBaselineTest::takeStandardSnapshots() bool focusNextPrevChild(bool next) override { return QWidget::focusNextPrevChild(next); } }; - QBASELINE_CHECK(takeSnapshot(), "default"); + QBASELINE_CHECK_DEFERRED(takeSnapshot(), "default"); // try hard to set focus static_cast<PublicWidget*>(window)->focusNextPrevChild(true); @@ -158,14 +158,15 @@ void QWidgetBaselineTest::takeStandardSnapshots() if (firstChild) firstChild->setFocus(); } + if (testWindow()->focusWidget()) { - QBASELINE_CHECK(takeSnapshot(), "focused"); + QBASELINE_CHECK_DEFERRED(takeSnapshot(), "focused"); testWindow()->focusWidget()->clearFocus(); } // this disables all children window->setEnabled(false); - QBASELINE_CHECK(takeSnapshot(), "disabled"); + QBASELINE_CHECK_DEFERRED(takeSnapshot(), "disabled"); window->setEnabled(true); // show and activate another window so that our test window becomes inactive @@ -176,7 +177,7 @@ void QWidgetBaselineTest::takeStandardSnapshots() otherWindow.show(); otherWindow.windowHandle()->requestActivate(); QVERIFY(QTest::qWaitForWindowActive(&otherWindow)); - QBASELINE_CHECK(takeSnapshot(), "inactive"); + QBASELINE_CHECK_DEFERRED(takeSnapshot(), "inactive"); window->windowHandle()->requestActivate(); QVERIFY(QTest::qWaitForWindowActive(window)); |