CommitFest 2014-10 (Closed)

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Committed: 36, Returned with Feedback: 22, Rejected: 4. Total: 62.

Pending Patches

No patches.

Committed Patches

Patch Name	Status	Author	Reviewers	Date Closed
Broken example in PL/PgSQL docs Patch by johto on 2014-09-17: Initial version. Review by intgr on 2014-10-08: Review/alternate patch	Committed	Marko Tiikkaja	Marti Raudsepp	2014-10-09
pg_dump refactor to remove global variables Patch by jwieland on 2014-08-27: rebased patch, compiles with clang now Patch by jwieland on 2014-09-05: changes based on Peter's initial comments Patch by jwieland on 2014-09-17: changes based on Alvaro's comments	Committed	Joachim Wieland	Peter Eisentraut	2014-10-14
Allow format 0000-0000-0000 in postgresql MAC parser Patch by herwinw on 2014-10-01: Initial version. Review by apaan on 2014-10-18: Ready for Commit. Side note: 8-byte macaddr?	Committed	Herwin Weststrate	Ali Akbar	2014-10-21
run xmllint during build Review by calvin on 2014-08-21: Some remarks about the patch & the doc build in general Patch by petere on 2014-09-14: update patch Review by calvin on 2014-09-14: Ok.	Committed	Peter Eisentraut	Fabien Coelho	2014-10-21
Correct documentation tool list for FreeBSD Patch by des on 2014-10-16: Initial version.	Committed	Dag-Erling Smørgrav	Peter Eisentraut	2014-10-21
Simplify calls of pg_class_aclcheck for multiple modes Patch by michael-kun on 2014-08-30: Initial version. Comment by michael-kun on 2014-08-30: Registering this trivial patch here so as it does not fall in the void... Comment by fabriziomello on 2014-10-06: First review.	Committed	Michael Paquier	Fabrízio de Royes Mello	2014-10-23
defer AfterTriggerBeginXact work Patch by rhaas on 2014-10-14: Initial version.	Committed	Robert Haas	Andres Freund	2014-10-23
defer AtStart_Inval work Patch by rhaas on 2014-10-14: Initial version. Comment by simon on 2014-10-16: Patch looks good	Committed	Robert Haas	Simon Riggs, Andres Freund	2014-10-29
Support CREATE INDEX IF NOT EXISTS Patch by intgr on 2014-10-06: Patch v7 Review by masaofujii on 2014-10-30: Minor comments Patch by fabriziomello on 2014-10-31: New version after reviewed by Fujii Masao	Committed	Fabrízio de Royes Mello	Marti Raudsepp	2014-11-06
Custom Plan API Patch by kaigai on 2014-09-05: v8, strip DDL support, split into three portions (custom-path, custom-scan, ctidscan) Patch by kaigai on 2014-09-12: v9, revised according to the comments from Robert Patch by kaigai on 2014-09-30: v12, revised according to the comments from Robert and Thom	Committed	KaiGai Kohei	Shigeru HANADA	2014-11-07
Make B-Tree/CLUSTER tuplesorts use sortsupport Patch by pgeoghegan on 2014-10-11: Initial version. Review by kandreas on 2014-11-06: Looks good except some minor things.	Committed	Peter Geoghegan	Andreas Karlsson	2014-11-07
generate_series(numeric, numeric) Review by apaan on 2014-10-06: review by Michael Paquier: changed process to use NumericVar instead of Numeric Patch by apaan on 2014-10-06: fixed whitespace & regression test as recommended by Marti Review by michael-kun on 2014-10-14: Fixed a couple of things here and there, marking as ready for committer.	Committed	Платон Малюгин, Ali Akbar	Michael Paquier, Marti Raudsepp	2014-11-11
storage parameter specifying the maximum size of GIN pending list Comment by efujita on 2014-11-04: Needs discussions about category or min value of the GUC. Patch by masaofujii on 2014-11-06: Updated. Review by efujita on 2014-11-10: Patch looks good to me except for one thing.	Committed	Fujii Masao	Etsuro Fujita	2014-11-11
Refactor of documentation of row-level locking Patch by michael-kun on 2014-10-10: Initial version.	Committed	Michael Paquier	Nobody	2014-11-13
Clarify evaluation order of aggregates wrt conditionals Patch by intgr on 2014-10-14: Initial version. Review by michael-kun on 2014-11-11: Patch does not compile properly, fixed it with some typo fixes at the same time. Patch by michael-kun on 2014-11-11: All parties agreed to the following patch, marking it as ready for committer.	Committed	Marti Raudsepp	Michael Paquier	2014-11-14
Refactoring tablecmds.c to passdown relpersistence to reindex_index Comment by fabriziomello on 2014-11-10: First review by Michael Paquier Patch by fabriziomello on 2014-11-10: New version after first review Review by michael-kun on 2014-11-11: Nothing more to add, so passing it to a committer, fixed some typos corrected in patch attached though.	Committed	Fabrízio de Royes Mello	Michael Paquier	2014-11-15
Improving ANALYZE VERBOSE messaging for inheritance parents Patch by efujita on 2014-10-16: Initial version. Review by osamufuruya on 2014-11-07: Initial review	Committed	Etsuro Fujita	Furuya Osamu	2014-11-15
Taking dumps with pg_dump using synchronous snapshots Comment by michael-kun on 2014-10-28: Comments from Petr: incorrect --help and issue with SET TRANSACTION SNAPSHOT Patch by michael-kun on 2014-10-28: Previous comments addressed. Review by pjmodos on 2014-10-28: ready for committer	Committed	Michael Paquier	Petr Jelinek	2014-11-17
Index scan optimization Patch by rajeevrastogi03 on 2014-09-24: Initial version.	Committed	Kumar Rajeev Rastogi	Hari Babu	2014-11-18
Flush buffers belonging to unlogged tables Patch by pavan on 2014-08-08: Initial version. Comment by pavan on 2014-08-08: I've attached a patch which adds a new flag for CHECKPOINT to flush buffers belonging to unlogged tables. There wasn't a clear consensus on the approach, nevertheless putting it here so that we don't lose track again.	Committed	Pavan Deolasee	MauMau	2014-11-18
Add Synchronous replication to pg_receivexlog Review by osamufuruya on 2014-11-10: No objection Patch by masaofujii on 2014-11-13: Implemented Alvaro's review comments. Comment by michael-kun on 2014-11-19: Committed as of c4f99d2.	Committed	Osamu Furuya	Fujii Masao	2014-11-19
GIN pageinspect functions Patch by heikki on 2014-10-08: Initial version. Patch by pgeoghegan on 2014-11-18: Largely mechanical revision fixing bitrot Review by michael-kun on 2014-11-20: Actually that's a patch cleaned up with docs and a more complete set of functions more than a review.	Committed	Heikki Linnakangas	Sawada Masahiko, Michael Paquier	2014-11-21
Incorrect behavior with system-column reference in postgres_fdw Patch by efujita on 2014-11-18: Updated patch postgres_fdw-syscol-v2.patch addressing the comments from Ashutosh Review by ashutosh_bapat on 2014-11-19: Instead of using rel->reltargetlist, tlist passed as argument to create_foreignscan_plan() should be used in this function. The reasons for the same are discussed in the review mails. Fujita-san suggested that this should be left to the commiter to decide. Review by efujita on 2014-11-19: See the above discussion here.	Committed	Etsuro Fujita	Ashutosh Bapat	2014-11-22
Simplify EXISTS subqueries containing LIMIT Review by davidrowley on 2014-10-22: Needs a couple more tests and a comment improved Patch by intgr on 2014-10-26: v2 patch in response to feedback Review by davidrowley on 2014-10-27: This looks ok to me.	Committed	Marti Raudsepp	David Rowley	2014-11-23
Stating the significance of Lehman & Yao in the nbtree README Patch by pgeoghegan on 2014-09-07: Revision that expands upon the purpose of a page highkey, and the use of page read locks in the Postgres implementation as it relates to the canonical algorithm. Review by heikki on 2014-09-09: This isn't ready for commit, so marking back to Returned with feedback. Comment by pgeoghegan on 2014-09-16: Moved to next commitfest	Committed	Peter Geoghegan	Amit Kapila	2014-11-24
Add shutdown_at_recovery_target option to recovery.conf Review by pjmodos on 2014-10-31: Review by Asif: aditional changes needed Patch by pjmodos on 2014-10-31: v2 addressing the comments from review Patch by pjmodos on 2014-11-24: v6	Committed	Petr Jelinek	Muhammad Asif Naeem	2014-11-25
array_agg(anyarray) Patch by apaan on 2014-10-27: v11: refactoring according to Pavel's design Patch by apaan on 2014-10-27: v13: remove unnecesary API (pavel) & patch cleaning Review by okbobcz on 2014-10-27: no objection, ready for commit	Committed	Ali Akbar	Pavel Stehule	2014-11-25
Track commit timestamps Patch by pjmodos on 2014-11-12: v8, addresses comments raised by review and further discussion Review by michael-kun on 2014-11-14: Doubts about the definition of nodeid: variable that can be set only with C interface gets in a WAL record.. Patch by pjmodos on 2014-11-21: v10, removed lsn, some other adjustments	Committed	Álvaro Herrera, Petr Jelinek	Michael Paquier	2014-12-03
New Event Trigger: table_rewrite Review by michael-kun on 2014-11-20: Review of v4, some minor comments, nothing huge. Patch by michael-kun on 2014-12-02: v5 of patch. Patch by michael-kun on 2014-12-02: Done some cleanup with v6. Switching to "ready for committer" as all the issues mentioned are addressed.	Committed	Dimitri Fontaine	Robert Haas, Alvaro Herrera, Michael Paquier	2014-12-08
Use faster, higher precision timer API GetSystemTimeAsFileTime on windows Patch by ringerc on 2014-12-02: Removed leftover elog include Review by davidrowley on 2014-12-05: Everything looks ok to me. Patch by ringerc on 2014-12-08: Used defined constants per David's final comment, otherwise unchanged	Committed	Craig Ringer	David Rowley	2014-12-08
REINDEX SCHEMA Review by michael-kun on 2014-11-26: Couple of issues that should be addressed. New APIs of this patch are weird. Patch by masahikosawada on 2014-12-01: Fixed ACL problem. Review by michael-kun on 2014-12-02: Found issues with catalog schema handling, rewrote the patches.	Committed	Sawada Masahiko	Fabrízio de Royes Mello, Michael Paquier	2014-12-09
Refactoring code for synchronous node detection Review by decibel on 2014-10-29: I'd like someone to chime in on the potential performance impact. Other than that, looks good modulo a few grammar fixes. Patch by michael-kun on 2014-10-31: New patch addressing issues raised previously. Patch by heikki on 2014-12-11: Review and another patch version	Committed	Michael Paquier	Nobody	2014-12-12
Jsonb generator functions Comment by okbobcz on 2014-10-20: missing doc, missing tests for to_jsonb function Patch by adunstan on 2014-10-27: Added docs and to_jsonb tests. Review by okbobcz on 2014-10-27: No objections	Committed	Andrew Dunstan	Pavel Stehule	2014-12-12
json strip nulls functions Review by okbobcz on 2014-10-17: missing doc, missing functions comments Review by okbobcz on 2014-10-27: no objections Patch by okbobcz on 2014-10-27: fix warning	Committed	Andrew Dunstan	Pavel Stehule	2014-12-12
Add IF NOT EXISTS to CREATE TABLE AS and CREATE MATERIALIZED VIEW Review by rlathia on 2014-10-27: Shared the review. Patch by fabriziomello on 2014-10-31: New version after reviewed by Rushabh Lathia Review by rlathia on 2014-11-03: Patch look good, assigning to committer.	Committed	Fabrízio de Royes Mello	Rushabh Lathia	2014-12-13
Fix local_preload_libraries to work as expected. Patch by horiguti on 2014-09-01: Only change context for the variable to PGC_USERSET and edit doc. Review by petere on 2014-09-14: further considerations Comment by michael-kun on 2014-12-15: Switching to returned with feedback. There have been wider discussions about the use of PGC_SU_BACKEND btw.	Committed	Kyoaro Horiguchi	Peter Eisentraut	2014-12-15

Returned with Feedback

Patch Name	Status	Author	Reviewers	Date Closed
Lowest LSN value as #define Patch by michael-kun on 2014-09-13: Initial version.	Returned with Feedback	Michael Paquier	Nobody	2014-11-15
Improve automatic analyze messages for inheritance trees Patch by efujita on 2014-10-06: Initial version. Comment by decibel on 2014-10-29: Marking Waiting on Author per Etsuro's comment Patch by efujita on 2014-10-30: v2 addressing the comment by Simon	Returned with Feedback	Etsuro Fujita	Simon Riggs	2014-11-15
Additional Shutdown Logging Patch by mbanck on 2014-10-16: Initial version.	Returned with Feedback	Michael Banck	Simon Riggs	2014-11-15
INNER JOIN removals Patch by davidrowley on 2014-10-15: Initial version. Comment by simon on 2014-11-15: Looks good, but I personally think more work required yet.	Returned with Feedback	David Rowley	Simon Riggs	2014-11-18
REINDEX CONCURRENTLY 3.0 Patch by michael-kun on 2014-10-30: Patch addressing previous comments, mainly docs and comments + a wart fix. Patch by jjanes on 2014-11-17: rebased Comment by michael-kun on 2014-11-20: Note: marked as returned with feedback by the author himself. I don't see much how things would move on for this CF.	Returned with Feedback	Michael Paquier	Nobody	2014-11-20
pg_background (and more parallelism infrastructure patches) Patch by rhaas on 2014-09-09: Initial version. Review by amitkapila on 2014-09-26: Few issues and suggestions. Comment by rhaas on 2014-11-24: parallelism infrastructure patches committed; pg_background itself returned with feedback	Returned with Feedback	Robert Haas, Amit Khandekar, Noah Misch	Petr Jelinek, Andres Freund, Amit Kapila	2014-11-24
Access methods extendability Patch by smagen on 2014-10-15: Initial version. Review by heikki on 2014-11-24: Review	Returned with Feedback	Alexander Korotkov	Nobody	2014-11-24
Add ready_count counter to pg_stat_archiver Review by abrightwell on 2014-10-21: Initial Review. Patch by michael-kun on 2014-11-18: Rewrote the patch, current approach was not appropriate. Review by michael-kun on 2014-11-18: Previous version counts as well as a review of the patch.	Returned with Feedback	Julien Rouhaud	Adam Brightwell	2014-11-24
Function returning the timestamp of last transaction Patch by masaofujii on 2014-08-15: Per discussion, the problem which exists in current code should be fixed first. I attached the patch for that. Comment by heikki on 2014-08-25: Marking this as "Waiting on Author" until the patch fixing the current code is committed Comment by michael-kun on 2014-12-02: First patch adding barriers for pg_stat counter should be committed. Now main feature would be covered by commit timestamp machinery from Alvaro, so marking it as "returned with feedback".	Returned with Feedback	Fujii Masao	Nobody	2014-12-02
psql support for asciidoc table output Review by okbobcz on 2014-11-02: no objections Comment by simon on 2014-11-18: Alvaro found some bugs, Szymon/Pavel to fix Comment by michael-kun on 2014-12-03: Some issues still not addressed. Marking as returned with feedback.	Returned with Feedback	Szymon Guz	Pavel Stehule	2014-12-03
Superuser Shortcut Cleanup Patch by abrightwell on 2014-11-05: Addresses comments from review. Patch by abrightwell on 2014-11-21: updated patch focusing solely on superuser shortcut cleanup. Review by petere on 2014-12-06: still issues	Returned with Feedback	Adam Brightwell	Peter Eisentraut	2014-12-06
Selectivity estimation for inet operators Patch by hasegeli on 2014-09-27: Version 12. Patch by tgl on 2014-12-01: Updated patch, also some gripes about remaining loose ends. Comment by tgl on 2014-12-01: We need to reduce the runtime when there are a lot of statistics, too.	Returned with Feedback	Emre Hasegeli	Tom Lane	2014-12-08
scalable LWLocks Review by amitkapila on 2014-06-26: Findings related to modifications in lwlock variants. Review by amitkapila on 2014-10-22: tpc-b results seems to be okay, however observed one intermittent hang Review by amitkapila on 2014-10-22: Few comments are yet to be addressed.	Returned with Feedback	Andres Freund	Peter Geoghegan, Amit Kapila	2014-12-08
GIST vacuum sequential access Patch by chapaev28 on 2014-09-07: Initial version. Comment by chapaev28 on 2014-09-11: Discussion of patch. Comment by jjanes on 2014-10-17: I think it can't benefit from further review in its current state.	Returned with Feedback	Constantine Kuznetsov	Nobody	2014-12-08
Event triggers: object creation support Review by michael-kun on 2014-11-05: Extra review of patches 1-3. Review by michael-kun on 2014-11-05: Some input on patch 4. Review by michael-kun on 2014-11-05: More infrastructure for jsonb should be implemented instead of the ObjTree stuff to allow in-memory manipulation of JSONB data, useful for this feature, and for potential extensions playing with JSONB.	Returned with Feedback	Álvaro Herrera	Michael Paquier	2014-12-08
Detect custom-format dumps as psql input and suggest pg_restore Patch by ringerc on 2014-10-17: Initial version. Review by jeevan.chalke on 2014-10-17: Initial Review with few comments	Returned with Feedback	Craig Ringer	Jeevan Chalke	2014-12-08
Scaling shared buffer eviction Review by andresfreund on 2014-09-11: Review spotting some minor/medium things, looking good otherwise Patch by amitkapila on 2014-09-20: Fixed review comments raised by Andres Patch by amitkapila on 2014-10-14: Rebased the remaining patch to add a new process bgreclaimer to move buffers to free list.	Returned with Feedback	Amit Kapila	Andres Freund	2014-12-09
deparse DDL in event triggers Review by michael-kun on 2014-12-15: Concerns by Tom about the overhead this feature would create for developers. Comment by michael-kun on 2014-12-15: Other concerns from Robert. Review by michael-kun on 2014-12-15: Marking as returned with feedback. On top of the other concerns expressed, having ObjTree instead of a better API base for jsonb is not a good thing thinking long-term maintenance.	Returned with Feedback	Álvaro Herrera	Nobody	2014-12-15
KNN-GiST with recheck Review by hasegeli on 2014-09-25: Code review Comment by smagen on 2014-10-15: Architecture thoughts. Comment by michael-kun on 2014-12-15: Based on those comments, binary heap method is preferable, hence marking this patch as returned with feedback.	Returned with Feedback	Alexander Korotkov	Emre Hasegeli	2014-12-15
WIP: dynahash replacement for buffer table Patch by rhaas on 2014-10-14: Initial version. Review by michael-kun on 2014-12-15: Review by Andres. Comment by michael-kun on 2014-12-15: Switching to returned with feedback because of lack of activity.	Returned with Feedback	Robert Haas	Andres Freund	2014-12-15
Lockless StrategyGetBuffer Patch by andresfreund on 2014-10-17: Initial version. Comment by michael-kun on 2014-12-15: Marked as returned with feedback due to lack of activity lately as there are still problems with in buffer mapping locks. Note that this last problem may be due to problems with HEAD as well on ppc.	Returned with Feedback	Andres Freund	Nobody	2014-12-15
pgcrypto: support PGP signatures Patch by johto on 2014-10-28: Patch v8, v6 re-rebased Patch by johto on 2014-11-01: Patch v9, bug fix of MDC handling Comment by michael-kun on 2014-12-15: v9 still has some bugs and has not been updated in a while. Switching back to returned with feedback.	Returned with Feedback	Marko Tiikkaja	Joel Jacobson, Jeff Janes, Thomas Munro	2014-12-15

Rejected Patches

Patch Name	Status	Author	Reviewers	Date Closed
Wait free dynahash implementation by using atomic ops. Patch by amitkapila on 2014-10-14: Initial version.	Rejected	Amit Kapila	Nobody	2014-10-28
plpgsql - RAISE WHEN Review by pjmodos on 2014-10-14: Needs docs Patch by okbobcz on 2014-10-16: with doc and fix formatting issue Review by pjmodos on 2014-10-17: ready for committer	Rejected	Pavel Stehule	Petr Jelinek	2014-11-15
Directory Aliases for Directory/File Access Permissions Comment by petere on 2014-10-21: patch is missing files Patch by abrightwell on 2014-10-21: Updated patch with previously missing files. Patch by abrightwell on 2014-10-27: Updated patch with minor updates.	Rejected	Adam Brightwell	Nobody	2014-12-11
Refactor of functions related to quoting from builtins.h to utils/quote.h Patch by michael-kun on 2014-10-14: Initial version. Review by rjuju on 2014-11-06: Patch looks good.	Rejected	Michael Paquier	Julien Rouhaud	2014-12-14