diff options
author | Andres Freund | 2014-09-19 13:17:12 +0000 |
---|---|---|
committer | Andres Freund | 2014-09-19 14:20:29 +0000 |
commit | 728f152e07f998d2cb4fe5f24ec8da2c3bda98f2 (patch) | |
tree | 3d7f2d8a04764a093a340af3f82b0cd15f44a6c1 /src/backend/access/rmgrdesc/mxactdesc.c | |
parent | 7e3f728353fa9b36c7f98b6ec447d3f1b8deec14 (diff) |
Add rmgr callback to name xlog record types for display purposes.
This is primarily useful for the upcoming pg_xlogdump --stats feature,
but also allows to remove some duplicated code in the rmgr_desc
routines.
Due to the separation and harmonization, the output of dipsplayed
records changes somewhat. But since this isn't enduser oriented
content that's ok.
It's potentially desirable to further change pg_xlogdump's display of
records. It previously wasn't possible to show the record type
separately from the description forcing it to be in the last
column. But that's better done in a separate commit.
Author: Abhijit Menon-Sen, slightly editorialized by me
Reviewed-By: Álvaro Herrera, Andres Freund, and Heikki Linnakangas
Discussion: [email protected]
Diffstat (limited to 'src/backend/access/rmgrdesc/mxactdesc.c')
-rw-r--r-- | src/backend/access/rmgrdesc/mxactdesc.c | 37 |
1 files changed, 25 insertions, 12 deletions
diff --git a/src/backend/access/rmgrdesc/mxactdesc.c b/src/backend/access/rmgrdesc/mxactdesc.c index 50d9b55ea9e..177aebea079 100644 --- a/src/backend/access/rmgrdesc/mxactdesc.c +++ b/src/backend/access/rmgrdesc/mxactdesc.c @@ -52,30 +52,43 @@ multixact_desc(StringInfo buf, XLogRecord *record) char *rec = XLogRecGetData(record); uint8 info = record->xl_info & ~XLR_INFO_MASK; - if (info == XLOG_MULTIXACT_ZERO_OFF_PAGE) + if (info == XLOG_MULTIXACT_ZERO_OFF_PAGE || + info == XLOG_MULTIXACT_ZERO_MEM_PAGE) { int pageno; memcpy(&pageno, rec, sizeof(int)); - appendStringInfo(buf, "zero offsets page: %d", pageno); - } - else if (info == XLOG_MULTIXACT_ZERO_MEM_PAGE) - { - int pageno; - - memcpy(&pageno, rec, sizeof(int)); - appendStringInfo(buf, "zero members page: %d", pageno); + appendStringInfo(buf, "%d", pageno); } else if (info == XLOG_MULTIXACT_CREATE_ID) { xl_multixact_create *xlrec = (xl_multixact_create *) rec; int i; - appendStringInfo(buf, "create mxid %u offset %u nmembers %d: ", xlrec->mid, + appendStringInfo(buf, "%u offset %u nmembers %d: ", xlrec->mid, xlrec->moff, xlrec->nmembers); for (i = 0; i < xlrec->nmembers; i++) out_member(buf, &xlrec->members[i]); } - else - appendStringInfoString(buf, "UNKNOWN"); +} + +const char * +multixact_identify(uint8 info) +{ + const char *id = NULL; + + switch (info) + { + case XLOG_MULTIXACT_ZERO_OFF_PAGE: + id = "ZERO_OFF_PAGE"; + break; + case XLOG_MULTIXACT_ZERO_MEM_PAGE: + id = "ZERO_MEM_PAGE"; + break; + case XLOG_MULTIXACT_CREATE_ID: + id = "CREATE_ID"; + break; + } + + return id; } |