diff options
| author | Peter Eisentraut | 2024-03-04 11:00:11 +0000 |
|---|---|---|
| committer | Peter Eisentraut | 2024-03-04 11:02:20 +0000 |
| commit | dbbca2cf299b81299112ca6ada671a36235ec008 (patch) | |
| tree | aac5368f0983f682c6a31b6bc6140cd89b50fe3c /src/backend/utils/mmgr | |
| parent | 24eebc65c26cfcc0ea5b8a95b61fa2fda6118e68 (diff) | |
Remove unused #include's from backend .c files
as determined by include-what-you-use (IWYU)
While IWYU also suggests to *add* a bunch of #include's (which is its
main purpose), this patch does not do that. In some cases, a more
specific #include replaces another less specific one.
Some manual adjustments of the automatic result:
- IWYU currently doesn't know about includes that provide global
variable declarations (like -Wmissing-variable-declarations), so
those includes are being kept manually.
- All includes for port(ability) headers are being kept for now, to
play it safe.
- No changes of catalog/pg_foo.h to catalog/pg_foo_d.h, to keep the
patch from exploding in size.
Note that this patch touches just *.c files, so nothing declared in
header files changes in hidden ways.
As a small example, in src/backend/access/transam/rmgr.c, some IWYU
pragma annotations are added to handle a special case there.
Discussion: https://www.postgresql.org/message-id/flat/af837490-6b2f-46df-ba05-37ea6a6653fc%40eisentraut.org
Diffstat (limited to 'src/backend/utils/mmgr')
| -rw-r--r-- | src/backend/utils/mmgr/dsa.c | 2 | ||||
| -rw-r--r-- | src/backend/utils/mmgr/mcxt.c | 4 | ||||
| -rw-r--r-- | src/backend/utils/mmgr/portalmem.c | 1 |
3 files changed, 0 insertions, 7 deletions
diff --git a/src/backend/utils/mmgr/dsa.c b/src/backend/utils/mmgr/dsa.c index b9e7f224d51..ddc64014c77 100644 --- a/src/backend/utils/mmgr/dsa.c +++ b/src/backend/utils/mmgr/dsa.c @@ -53,9 +53,7 @@ #include "port/atomics.h" #include "port/pg_bitutils.h" #include "storage/dsm.h" -#include "storage/ipc.h" #include "storage/lwlock.h" -#include "storage/shmem.h" #include "utils/dsa.h" #include "utils/freepage.h" #include "utils/memutils.h" diff --git a/src/backend/utils/mmgr/mcxt.c b/src/backend/utils/mmgr/mcxt.c index 41f2390fb8f..1a615becae4 100644 --- a/src/backend/utils/mmgr/mcxt.c +++ b/src/backend/utils/mmgr/mcxt.c @@ -23,10 +23,6 @@ #include "mb/pg_wchar.h" #include "miscadmin.h" -#include "storage/proc.h" -#include "storage/procarray.h" -#include "storage/procsignal.h" -#include "utils/fmgrprotos.h" #include "utils/memdebug.h" #include "utils/memutils.h" #include "utils/memutils_internal.h" diff --git a/src/backend/utils/mmgr/portalmem.c b/src/backend/utils/mmgr/portalmem.c index 3d4282da03a..4a246135377 100644 --- a/src/backend/utils/mmgr/portalmem.c +++ b/src/backend/utils/mmgr/portalmem.c @@ -19,7 +19,6 @@ #include "postgres.h" #include "access/xact.h" -#include "catalog/pg_type.h" #include "commands/portalcmds.h" #include "funcapi.h" #include "miscadmin.h" |