diff options
| author | Tom Lane | 2017-02-25 21:12:24 +0000 |
|---|---|---|
| committer | Tom Lane | 2017-02-25 21:12:55 +0000 |
| commit | 9e3755ecb2d058f7d123dd35a2e1784006190962 (patch) | |
| tree | f938cae7833ef756947d4ac074a83d31f5f6113d /src/bin/pg_dump/parallel.c | |
| parent | 5639ceddcb7f3efa8751b2ba6e50cc1d27cc2a45 (diff) | |
Remove useless duplicate inclusions of system header files.
c.h #includes a number of core libc header files, such as <stdio.h>.
There's no point in re-including these after having read postgres.h,
postgres_fe.h, or c.h; so remove code that did so.
While at it, also fix some places that were ignoring our standard pattern
of "include postgres[_fe].h, then system header files, then other Postgres
header files". While there's not any great magic in doing it that way
rather than system headers last, it's silly to have just a few files
deviating from the general pattern. (But I didn't attempt to enforce this
globally, only in files I was touching anyway.)
I'd be the first to say that this is mostly compulsive neatnik-ism,
but over time it might save enough compile cycles to be useful.
Diffstat (limited to 'src/bin/pg_dump/parallel.c')
| -rw-r--r-- | src/bin/pg_dump/parallel.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/src/bin/pg_dump/parallel.c b/src/bin/pg_dump/parallel.c index 775a7f858c9..be8e018a964 100644 --- a/src/bin/pg_dump/parallel.c +++ b/src/bin/pg_dump/parallel.c @@ -51,6 +51,12 @@ #include "postgres_fe.h" +#ifndef WIN32 +#include <sys/wait.h> +#include <signal.h> +#include <unistd.h> +#include <fcntl.h> +#endif #ifdef HAVE_SYS_SELECT_H #include <sys/select.h> #endif @@ -59,14 +65,6 @@ #include "pg_backup_utils.h" #include "fe_utils/string_utils.h" -#ifndef WIN32 -#include <sys/types.h> -#include <sys/wait.h> -#include "signal.h" -#include <unistd.h> -#include <fcntl.h> -#endif - /* Mnemonic macros for indexing the fd array returned by pipe(2) */ #define PIPE_READ 0 #define PIPE_WRITE 1 |