diff options
| author | Heikki Linnakangas | 2009-11-23 09:58:36 +0000 |
|---|---|---|
| committer | Heikki Linnakangas | 2009-11-23 09:58:36 +0000 |
| commit | cd87b6f8a5084c070c3e56b07794be8fea33647d (patch) | |
| tree | 20c1c2d08a56147198288ea6845791a41e888c91 /src/include/access/twophase_rmgr.h | |
| parent | c194ff20d2fa1541d62c366bb6a9000fb0d3b983 (diff) | |
Fix an old bug in multixact and two-phase commit. Prepared transactions can
be part of multixacts, so allocate a slot for each prepared transaction in
the "oldest member" array in multixact.c. On PREPARE TRANSACTION, transfer
the oldest member value from the current backends slot to the prepared xact
slot. Also save and recover the value from the 2pc state file.
The symptom of the bug was that after a transaction prepared, a shared lock
still held by the prepared transaction was sometimes ignored by other
transactions.
Fix back to 8.1, where both 2PC and multixact were introduced.
Diffstat (limited to 'src/include/access/twophase_rmgr.h')
| -rw-r--r-- | src/include/access/twophase_rmgr.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/include/access/twophase_rmgr.h b/src/include/access/twophase_rmgr.h index 5f516b8666c..37d03495bc9 100644 --- a/src/include/access/twophase_rmgr.h +++ b/src/include/access/twophase_rmgr.h @@ -7,7 +7,7 @@ * Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/access/twophase_rmgr.h,v 1.8 2009/09/01 02:54:52 alvherre Exp $ + * $PostgreSQL: pgsql/src/include/access/twophase_rmgr.h,v 1.9 2009/11/23 09:58:36 heikki Exp $ * *------------------------------------------------------------------------- */ @@ -26,7 +26,8 @@ typedef uint8 TwoPhaseRmgrId; #define TWOPHASE_RM_INVAL_ID 2 #define TWOPHASE_RM_NOTIFY_ID 3 #define TWOPHASE_RM_PGSTAT_ID 4 -#define TWOPHASE_RM_MAX_ID TWOPHASE_RM_PGSTAT_ID +#define TWOPHASE_RM_MULTIXACT_ID 5 +#define TWOPHASE_RM_MAX_ID TWOPHASE_RM_MULTIXACT_ID extern const TwoPhaseCallback twophase_recover_callbacks[]; extern const TwoPhaseCallback twophase_postcommit_callbacks[]; |