diff options
| author | David Rowley | 2025-05-30 10:59:39 +0000 |
|---|---|---|
| committer | David Rowley | 2025-05-30 10:59:39 +0000 |
| commit | c3eda50b0648005281c2a3cf95375708f8ef97fc (patch) | |
| tree | 19ad79897e47f8f5da5e202bb9a2431a175e5512 /src/include/nodes/plannodes.h | |
| parent | 03c53a73141aa0e0ee6b0c7642671c1e972bae32 (diff) | |
Change internal queryid type from uint64 to int64
uint64 was perhaps chosen in cff440d36 as the type was uint32 prior to
that widening work.
Having this as uint64 doesn't make much sense and just adds the overhead of
having to remember that we always output this in its signed form. Let's
remove that overhead.
The signed form output is seemingly required since we have no way to
represent the full range of uint64 in an SQL type. We use BIGINT in places
like pg_stat_statements, which maps directly to int64.
The release notes "Source Code" section may want to mention this
adjustment as some extensions may wish to adjust their code.
Author: David Rowley <[email protected]>
Suggested-by: Peter Eisentraut <[email protected]>
Reviewed-by: Sami Imseih <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Diffstat (limited to 'src/include/nodes/plannodes.h')
| -rw-r--r-- | src/include/nodes/plannodes.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/nodes/plannodes.h b/src/include/nodes/plannodes.h index f0d514e6e15..e70e33afa9c 100644 --- a/src/include/nodes/plannodes.h +++ b/src/include/nodes/plannodes.h @@ -53,7 +53,7 @@ typedef struct PlannedStmt CmdType commandType; /* query identifier (copied from Query) */ - uint64 queryId; + int64 queryId; /* plan identifier (can be set by plugins) */ uint64 planId; |