diff options
| author | Thomas Munro | 2022-07-21 21:41:12 +0000 |
|---|---|---|
| committer | Thomas Munro | 2022-07-21 22:41:50 +0000 |
| commit | 4f1f5a7f85cee932c417aef589b27574813a06c9 (patch) | |
| tree | 0a9b86ad582917b9ed8c31199f3ae8dca5b9b38c /src/include/port.h | |
| parent | 3225399021b62cda66012b17ee60c7bec4733fce (diff) | |
Remove fls(), use pg_leftmost_one_pos32() instead.
Commit 4f658dc8 provided the traditional BSD fls() function in
src/port/fls.c so it could be used in several places. Later we added a
bunch of similar facilities in pg_bitutils.h, based on compiler
builtins that map to hardware instructions. It's a bit confusing to
have both 1-based and 0-based variants of this operation in use in
different parts of the tree, and neither is blessed by a standard.
Let's drop fls.c and the configure probe, and reuse the newer code.
Reviewed-by: David Rowley <[email protected]>
Reviewed-by: Tom Lane <[email protected]>
Discussion: https://postgr.es/m/CA%2BhUKG%2B7dSX1XF8yFGmYk-%3D48dbjH2kmzZj16XvhbrWP-9BzRg%40mail.gmail.com
Diffstat (limited to 'src/include/port.h')
| -rw-r--r-- | src/include/port.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/include/port.h b/src/include/port.h index e647f62b779..d39b04141f9 100644 --- a/src/include/port.h +++ b/src/include/port.h @@ -366,10 +366,6 @@ extern int gettimeofday(struct timeval *tp, struct timezone *tzp); #define pgoff_t off_t #endif -#ifndef HAVE_FLS -extern int fls(int mask); -#endif - #ifndef HAVE_GETPEEREID /* On Windows, Perl might have incompatible definitions of uid_t and gid_t. */ #ifndef PLPERL_HAVE_UID_GID |