Use printf's %m format instead of strerror(errno) in more places

Most callers of strerror() are removed from the backend code.  The
remaining callers require special handling with a saved errno from a
previous system call.  The frontend code still needs strerror() where
error states need to be handled outside of fprintf.

Note that pg_regress is not changed to use %m as the TAP output may
clobber errno, since those functions call fprintf() and friends before
evaluating the format string.

Support for %m in src/port/snprintf.c has been added in d6c55de1f99a,
hence all the stable branches currently supported include it.

Author: Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/[email protected]

1 files changed, 6 insertions, 6 deletions

diff --git a/src/interfaces/ecpg/preproc/ecpg.c b/src/interfaces/ecpg/preproc/ecpg.c
index e4db21e0c16..93e66fc60f0 100644
--- a/src/interfaces/ecpg/preproc/ecpg.c
+++ b/src/interfaces/ecpg/preproc/ecpg.c
@@ -216,8 +216,8 @@ main(int argc, char *const argv[])
 
 				if (base_yyout == NULL)
 				{
-					fprintf(stderr, _("%s: could not open file \"%s\": %s\n"),
-							progname, output_filename, strerror(errno));
+					fprintf(stderr, _("%s: could not open file \"%s\": %m\n"),
+							progname, output_filename);
 					output_filename = NULL;
 				}
 				else
@@ -331,8 +331,8 @@ main(int argc, char *const argv[])
 					base_yyout = fopen(output_filename, PG_BINARY_W);
 					if (base_yyout == NULL)
 					{
-						fprintf(stderr, _("%s: could not open file \"%s\": %s\n"),
-								progname, output_filename, strerror(errno));
+						fprintf(stderr, _("%s: could not open file \"%s\": %m\n"),
+								progname, output_filename);
 						free(output_filename);
 						output_filename = NULL;
 						free(input_filename);
@@ -342,8 +342,8 @@ main(int argc, char *const argv[])
 			}
 
 			if (base_yyin == NULL)
-				fprintf(stderr, _("%s: could not open file \"%s\": %s\n"),
-						progname, argv[fnr], strerror(errno));
+				fprintf(stderr, _("%s: could not open file \"%s\": %m\n"),
+						progname, argv[fnr]);
 			else
 			{
 				struct cursor *ptr;