Claudio Nicora nicorac
nicorac commented on pull request gitea/act#80 2024-02-14 10:28:49 +00:00
Patched options() to let container options propagate to job containers

3 issues could be fixed by this PR: 79, 475 and 483

nicorac commented on issue gitea/act_runner#483 2024-02-14 10:24:36 +00:00
config.yaml: container options are ignored with custom container

This issue is similar to this and this other ones (I'd like to inject Docker…

nicorac commented on issue gitea/act_runner#475 2024-01-29 19:11:57 +00:00
Apply resource limitation on container during job

This issue is similar to this other one (I'd like to inject Docker configuration params into started containers).

I've a…

nicorac pushed to main at nicorac/act_runner 2023-11-27 15:59:20 +00:00
c29fc1012b Switched to patched version of "act"
91bfe4c186 fix(deps): update module golang.org/x/time to v0.4.0 (#424)
825c6f97b7 fix(deps): update module github.com/mattn/go-isatty to v0.0.20 (#414)
2f3e5c7125 fix(deps): update module github.com/docker/docker to v24.0.7+incompatible (#413)
4d9de6ca8c fix(deps): update module github.com/spf13/cobra to v1.8.0 (#416)
Compare 17 commits »
nicorac pushed to main at nicorac/act_runner 2023-11-27 15:41:26 +00:00
9ae227f864 Switched to patched version of "act"
nicorac pushed to main at nicorac/act 2023-11-16 13:12:18 +00:00
d868bb469f Patched options() to always return "general" container config
15045b4fc0 Merge pull request 'Fix panic in extractFromImageEnv' (#81) from wolfogre/act:bugfix/panic_extractFromImageEnv into main
67918333fa fix: panic
c93462e19f Merge pull request 'bump nektos to 0.2.52' (#79) from bump-nektos into main
f3264cac20 Merge remote-tracking branch 'upstream/master' into bump-nektos
Compare 14 commits »
nicorac commented on issue gitea/act_runner#79 2023-10-20 06:34:11 +00:00
Provide "docker run" options for the containers launched by the runner

this issue looks like it is already fixed

No, it's not. options are applied only to default container.

If you use a custom container to run your jobs (and it happens most of the…

nicorac commented on pull request gitea/act#80 2023-10-19 08:05:48 +00:00
Patched options() to let container options propagate to job containers

Is there any possible security problem of this patch?

Which kind of problem are you suspecting could be introduced?

In my mind config.yaml file and its container.options field is…

nicorac commented on issue gitea/act_runner#378 2023-10-17 06:55:55 +00:00
Provide a way to mount common volumes to Docker containers used by Actions

I've already posted my own fix 3 months ago to the issue you've mentioned. Nobody commented...

Now I've created a PR [here](https://gitea.com/gi…

nicorac created pull request gitea/act#80 2023-10-17 06:53:35 +00:00
Patched options() to let container options propagate to job containers
nicorac pushed to main at nicorac/act_runner 2023-10-10 13:20:14 +00:00
5065e3c0c8 Switched to patched version of "act"
nicorac pushed to main at nicorac/act 2023-10-10 12:28:22 +00:00
33f5365c02 Patched options() to always return "general" container config
nicorac created repository nicorac/act_runner 2023-10-10 12:20:39 +00:00
nicorac created repository nicorac/act 2023-10-10 12:19:15 +00:00
nicorac commented on issue gitea/awesome-gitea#130 2023-08-23 06:42:57 +00:00
Dark theme "Earl Grey" not available anymore

Here you are.

I've also patched it to let it work with Gitea 1.20+ (see lines 271-272):

--color-nav-bg: var(--color-body);
--color-nav-hover-bg: var(--color-hover);
nicorac opened issue gitea/awesome-gitea#130 2023-08-22 09:54:43 +00:00
Dark theme "Earl Grey" not available anymore
nicorac commented on issue gitea/act_runner#79 2023-07-31 07:19:33 +00:00
Provide "docker run" options for the containers launched by the runner

Sometimes you just want to inject the same options to all started containers (e.g. corporate proxy settings), so it's better to "force" them through act_runner instead of repeating the same…

nicorac commented on issue gitea/act_runner#265 2023-07-14 09:06:57 +00:00
Container Options not propagated to job containers

Looking at the code I've found that container.options in runner config.yaml file are applied only to default container; if a job has custom container configured, then it receives only…

nicorac commented on issue gitea/act_runner#265 2023-07-06 14:45:02 +00:00
Container Options not propagated to job containers

you could try to add the option string to jobs.<job_id>.container.options and it should work.

I have the same issue and this "fixed" it but...

On my side I need to apply some **special…