fix bug in navigation: allow integer default types with argType float.#117
fix bug in navigation: allow integer default types with argType float.#117tatocaster wants to merge 1 commit into
Conversation
|
I do not know why those checks are failing, there are 0 changes related to them and I opened a ticket for this as well: https://issuetracker.google.com/issues/177896088 |
|
I'm pretty sure these are build failures on our end - I'll take a look, thanks for filing a bug! |
|
The build failures fix is up here: https://android-review.googlesource.com/c/platform/frameworks/support/+/1554452 Once this change lands you'll need to rebase this PR to get these tests to pass |
|
@dlam Hey, I rebased, the fix is kinda working, still failing for |
|
Ah - sorry about this, once these two land things should be green again :) https://android-review.googlesource.com/c/platform/frameworks/support/+/1555160 I just had my wisdom teeth removed so a bit slow to reply. |
|
@dlam finally, all checks have passed. can you merge it? Thanks for the fixes |
…float.
## Proposed Changes
changes the `NavInflater` to allow integer default types with argType="float".
From now on this will work:
```xml
<argument
android:name="ratio"
android:defaultValue="0" <-- notice the value, 0 instead of 0.0
app:argType="float" />
```
before there was an error: `org.xmlpull.v1.XmlPullParserException: Type is float but found integer: 0`
## Testing
Test: ./gradlew navigation:navigation-runtime:connectedCheck
## Issues Fixed
Fixes: The bug on [https://issuetracker.google.com/issues/173766247](https://issuetracker.google.com/issues/173766247) being fixed
This is an imported pull request from androidx/androidx#117.
Resolves #117
Github-Pr-Head-Sha: b60424e2b1e235851e0a4f4683efd8f913a20f53
GitOrigin-RevId: f54b9d371da4cfe77d57c7f280f994015008719b
Change-Id: Ic9e75bb4fe08973abd443008014a802dc6b19c1c
(cherry picked from commit 0b89ed8)
(cherry picked from commit 33dddc29239a552e3b2f24c094ddaaa8d8ad63c3)
Proposed Changes
changes the
NavInflaterto allow integer default types with argType="float".From now on this will work:
before there was an error:
org.xmlpull.v1.XmlPullParserException: Type is float but found integer: 0Testing
Test: ./gradlew navigation:navigation-runtime:connectedCheck
Issues Fixed
Fixes: The bug on https://issuetracker.google.com/issues/173766247 being fixed