-
Notifications
You must be signed in to change notification settings - Fork 392
[CELEBORN-770][FLINK] Convert BacklogAnnouncement, BufferStreamEnd, ReadAddCredit to PB #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1ad46ec
to
05b416e
Compare
Codecov Report
@@ Coverage Diff @@
## main #1905 +/- ##
==========================================
- Coverage 46.66% 46.59% -0.07%
==========================================
Files 164 164
Lines 10283 10293 +10
Branches 938 938
==========================================
- Hits 4798 4795 -3
- Misses 5171 5184 +13
Partials 314 314
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ReadClientHandler needs modifications to receive rpc requests. Sizable CI failures mean that something is wrong. |
05b416e
to
1d476cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReadClientHandler needs modification.
1d476cb
to
fe0f963
Compare
fe0f963
to
c053efa
Compare
b771439
to
e53a3b4
Compare
...t-flink/common/src/main/java/org/apache/celeborn/plugin/flink/network/ReadClientHandler.java
Outdated
Show resolved
Hide resolved
e53a3b4
to
0adb8b0
Compare
0adb8b0
to
a8e6281
Compare
…eadAddCredit to PB
a8e6281
to
903dce4
Compare
…eadAddCredit to PB `BacklogAnnouncement`, `BufferStreamEnd`, and `ReadAddCredit` should merge to transport messages to enhance celeborn's compatibility. 1. Improves celeborn's transport flexibility to change RPC. 2. Makes Compatible with 0.2 client. No. - `TransportFrameDecoderWithBufferSupplierSuiteJ` Closes #1905 from SteNicholas/CELEBORN-770. Authored-by: SteNicholas <[email protected]> Signed-off-by: Shuang <[email protected]> (cherry picked from commit 2407cae) Signed-off-by: Shuang <[email protected]>
Thanks merge to main/0.3 |
What changes were proposed in this pull request?
BacklogAnnouncement
,BufferStreamEnd
, andReadAddCredit
should merge to transport messages to enhance celeborn's compatibility.Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
TransportFrameDecoderWithBufferSupplierSuiteJ