Skip to content

[CELEBORN-1085] Update metrics doc #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

onebox-li
Copy link
Contributor

What changes were proposed in this pull request?

Update metrics doc.

Why are the changes needed?

Ditto

Does this PR introduce any user-facing change?

Doc updated.

How was this patch tested?

No.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2035 (fe6e16e) into main (349ee8b) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   46.83%   46.58%   -0.24%     
==========================================
  Files         165      165              
  Lines       10520    10520              
  Branches      956      956              
==========================================
- Hits         4926     4900      -26     
- Misses       5275     5297      +22     
- Partials      319      323       +4     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@waitinfuture waitinfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Merged to main(v0.4.0)

@onebox-li onebox-li deleted the update-metrics-doc branch October 24, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants