-
Notifications
You must be signed in to change notification settings - Fork 392
CELEBORN-1334 [CIP-12] Support HARD_SPLIT in PushMergedData should not support new version client with old version worker #3171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…pport compatibility of old worker success rpc with no content
ping @RexXiong |
@AngersZhuuuu Maybe we can just modify org/apache/celeborn/client/ShuffleClientImpl:PushMergedDataWrappedCallback
to
|
Since new client version not support older version worker, after discuss, we decided to remove this code. cc @RexXiong |
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
anymore comments for this? |
5590ef0
to
0dffcf6
Compare
What changes were proposed in this pull request?
Current version client can't be compatibility with older worker version.
Why are the changes needed?
For backward compatibility.
Does this PR introduce any user-facing change?
No
How was this patch tested?