Skip to content

CELEBORN-1334 [CIP-12] Support HARD_SPLIT in PushMergedData should not support new version client with old version worker #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

AngersZhuuuu
Copy link
Contributor

@AngersZhuuuu AngersZhuuuu commented Mar 25, 2025

What changes were proposed in this pull request?

Current version client can't be compatibility with older worker version.

Why are the changes needed?

For backward compatibility.

Does this PR introduce any user-facing change?

No

How was this patch tested?

@AngersZhuuuu AngersZhuuuu changed the title CELEBORN-1334 [CIP-12] Support HARD_SPLIT in PushMergedData should support compatibility of old worker success rpc no response body CELEBORN-1334 [CIP-12] Support HARD_SPLIT in PushMergedData should not support new version client with old version worker Mar 25, 2025
@AngersZhuuuu
Copy link
Contributor Author

ping @RexXiong

@jiang13021
Copy link
Contributor

@AngersZhuuuu Maybe we can just modify org/apache/celeborn/client/ShuffleClientImpl:PushMergedDataWrappedCallback

@Override
          public void onSuccess(ByteBuffer response) {
            byte reason = response.get();
......

to

@Override
      public void onSuccess(ByteBuffer response) {
        byte reason = StatusCode.SUCCESS.getValue();
        if (response.remaining() > 0) {
          reason = response.get();
        }
......

@AngersZhuuuu
Copy link
Contributor Author

@AngersZhuuuu Maybe we can just modify org/apache/celeborn/client/ShuffleClientImpl:PushMergedDataWrappedCallback

@Override
          public void onSuccess(ByteBuffer response) {
            byte reason = response.get();
......

to

@Override
      public void onSuccess(ByteBuffer response) {
        byte reason = StatusCode.SUCCESS.getValue();
        if (response.remaining() > 0) {
          reason = response.get();
        }
......

Since new client version not support older version worker, after discuss, we decided to remove this code. cc @RexXiong

Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Apr 18, 2025
@turboFei turboFei removed the stale label Apr 18, 2025
Copy link

github-actions bot commented May 9, 2025

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label May 9, 2025
@turboFei
Copy link
Member

anymore comments for this?

ping @AngersZhuuuu @jiang13021 @RexXiong

@github-actions github-actions bot removed the stale label May 19, 2025
@SteNicholas SteNicholas force-pushed the main branch 2 times, most recently from 5590ef0 to 0dffcf6 Compare May 26, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants