CELEBORN-1991: add retries for registerShuffle on the lifecycleManager #3238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add retries to registerShuffle for lifecycleManager to address failures from FallbackPolicyRunner and/or other manager issues. While we do retry connection failures to manager, this addresses failures such as no active manager for a short period of time as well.
We add three separate configs:
Why are the changes needed?
We were running into issues in production with manager not being active for a short period of time, which results in application failures due to registerShuffle failure.
Adding retries fixes these failures.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests.
Running jobs in our pre-prod environment.