[CELEBORN-2004] Filter empty partition before createIntputStream #3266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
reviewed
May 20, 2025
...t-spark/spark-3/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleReader.scala
Outdated
Show resolved
Hide resolved
turboFei
reviewed
May 20, 2025
...t-spark/spark-3/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleReader.scala
Outdated
Show resolved
Hide resolved
…eleborn/CelebornShuffleReader.scala Co-authored-by: Nicholas Jiang <[email protected]>
…eleborn/CelebornShuffleReader.scala
|
Thanks, merging to 0.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Filter empty partition from partitionFileGroup before createIntputStream.
Why are the changes needed?
Avoid creating the IntputStream for the empty partitions which might be a lot when partition num is large and data is small.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT and cluster test.