[CELEBORN-2006] LifecycleManager should avoid parsing shufflePartitionType every time #3273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RexXiong
approved these changes
May 22, 2025
turboFei
approved these changes
May 23, 2025
|
thanks, merging to 0.6.0 |
turboFei
pushed a commit
that referenced
this pull request
May 23, 2025
…nType every time ### What changes were proposed in this pull request? ### Why are the changes needed? `org.apache.celeborn.client.LifecycleManager.getPartitionType` may be called frequently, but in Spark scenario it requires each parsing configuration, which is not necessary. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? GA Closes #3273 from cxzl25/CELEBORN-2006. Authored-by: sychen <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit a554261) Signed-off-by: Wang, Fei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
org.apache.celeborn.client.LifecycleManager.getPartitionTypemay be called frequently, but in Spark scenario it requires each parsing configuration, which is not necessary.Does this PR introduce any user-facing change?
No
How was this patch tested?
GA