[CELEBORN-2008] SlotsAllocator should select disks randomly in RoundRobin mode #3275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2025 17:35
AngersZhuuuu
approved these changes
May 22, 2025
turboFei
approved these changes
May 22, 2025
RexXiong
approved these changes
May 22, 2025
|
thanks, merging to 0.6.0 |
turboFei
pushed a commit
that referenced
this pull request
May 23, 2025
…obin mode ### What changes were proposed in this pull request? SlotsAllocator should select disks randomly in RoundRobin mode ### Why are the changes needed? The current round robin selection mechanism is to select the first disk of each worker first, then the second disk of each worker, and finally the third disk. This can easily cause disk storage space skew. We should select disks randomly instead of selecting the first disk first. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs. Closes #3275 from leixm/CELEBORN-2008. Authored-by: Xianming Lei <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit d2befe0) Signed-off-by: Wang, Fei <[email protected]>
turboFei
pushed a commit
that referenced
this pull request
May 23, 2025
…obin mode ### What changes were proposed in this pull request? SlotsAllocator should select disks randomly in RoundRobin mode ### Why are the changes needed? The current round robin selection mechanism is to select the first disk of each worker first, then the second disk of each worker, and finally the third disk. This can easily cause disk storage space skew. We should select disks randomly instead of selecting the first disk first. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs. Closes #3275 from leixm/CELEBORN-2008. Authored-by: Xianming Lei <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit d2befe0) Signed-off-by: Wang, Fei <[email protected]>
|
thanks, merged to 0.6.0 and 0.5.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SlotsAllocator should select disks randomly in RoundRobin mode
Why are the changes needed?
The current round robin selection mechanism is to select the first disk of each worker first, then the second disk of each worker, and finally the third disk. This can easily cause disk storage space skew. We should select disks randomly instead of selecting the first disk first.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.