[CELEBORN-1528][HELM] Use volume claim template to support various storage backend #3277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efulset Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
5590ef0 to
0dffcf6
Compare
RexXiong
approved these changes
May 26, 2025
|
thanks, merging to 0.6.0 |
turboFei
pushed a commit
that referenced
this pull request
May 27, 2025
…orage backend ### What changes were proposed in this pull request? - Add support for configuring volumeClaimTemplates by adding new values `master.volumeClaimTemplates` and `worker.volumeClaimTemplates`. ### Why are the changes needed? Use volume claim template to support various storage backend. ### Does this PR introduce _any_ user-facing change? Yes. New Helm values `master.volumeClaimTemplates` and `worker.volumeClaimTemplates` are added. ### How was this patch tested? ```bash helm unittest charts/celeborn --file "tests/**/*_test.yaml" --strict --debug ``` Closes #3277 from ChenYi015/helm/volume-claim-templates. Authored-by: Yi Chen <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit c83d498) Signed-off-by: Wang, Fei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
master.volumeClaimTemplatesandworker.volumeClaimTemplates.Why are the changes needed?
Use volume claim template to support various storage backend.
Does this PR introduce any user-facing change?
Yes. New Helm values
master.volumeClaimTemplatesandworker.volumeClaimTemplatesare added.How was this patch tested?
helm unittest charts/celeborn --file "tests/**/*_test.yaml" --strict --debug