-
Notifications
You must be signed in to change notification settings - Fork 392
[CELEBORN-1413][FOLLOWUP] Bump spark 4.0 version to 4.0.0 #3282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
May 26, 2025
73f5046
to
d465aac
Compare
turboFei
commented
May 26, 2025
client/src/main/scala/org/apache/celeborn/client/ApplicationHeartbeater.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
May 27, 2025
cc @pan3793 |
pan3793
approved these changes
May 27, 2025
SteNicholas
reviewed
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@turboFei, could you also update the document to add Spark 4.0 support?
where to update? |
turboFei
commented
May 28, 2025
SteNicholas
approved these changes
May 28, 2025
LGTM. Merged to main(v0.6.0). |
FYI. need to merge to branch-0.6 |
turboFei
added a commit
that referenced
this pull request
May 28, 2025
### What changes were proposed in this pull request? Bump spark 4.0 version to 4.0.0. ### Why are the changes needed? Spark 4.0.0 is ready. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. Closes #3282 from turboFei/spark_4.0. Lead-authored-by: Fei Wang <[email protected]> Co-authored-by: Wang, Fei <[email protected]> Co-authored-by: Fei Wang <[email protected]> Signed-off-by: SteNicholas <[email protected]>
SteNicholas
added a commit
that referenced
this pull request
May 29, 2025
### What changes were proposed in this pull request? Support dependencies of `spark-4.0` profile. Follow up #3282. ### Why are the changes needed? #3282 is lack of dependencies support of `spark-4.0` profile. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Dependencies check: maven-jdk17 (spark-4.0). Closes #3298 from SteNicholas/CELEBORN-1413. Authored-by: SteNicholas <[email protected]> Signed-off-by: SteNicholas <[email protected]>
SteNicholas
added a commit
that referenced
this pull request
May 29, 2025
### What changes were proposed in this pull request? Support dependencies of `spark-4.0` profile. Follow up #3282. ### Why are the changes needed? #3282 is lack of dependencies support of `spark-4.0` profile. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Dependencies check: maven-jdk17 (spark-4.0). Closes #3298 from SteNicholas/CELEBORN-1413. Authored-by: SteNicholas <[email protected]> Signed-off-by: SteNicholas <[email protected]> (cherry picked from commit c79e02f) Signed-off-by: SteNicholas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bump spark 4.0 version to 4.0.0.
Why are the changes needed?
Spark 4.0.0 is ready.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.