[CELEBORN-2014] updateInterruptionNotice REST API #3285
+624
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mridulm @FMX @SteNicholas PTAL, thanks. |
5590ef0 to
0dffcf6
Compare
|
I'll review this PR today. |
|
thanks @FMX. The test failure also looks unrelated. |
|
@akpatnam25, could you also add the CLI command for the introduced REST API in this pull request? |
FMX
reviewed
May 29, 2025
FMX
reviewed
May 29, 2025
common/src/main/scala/org/apache/celeborn/common/util/PbSerDeUtils.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/util/PbSerDeUtils.scala
Outdated
Show resolved
Hide resolved
common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala
Outdated
Show resolved
Hide resolved
|
addressed comments and added cli command @FMX @SteNicholas . PTAL, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is part of CIP17: Interruption Aware Slot Selection.
It introduces a REST api for external services to notify master about interruptions/schedules.
Why are the changes needed?
To nofify master of upcoming interruption notices in the worker fleet. Master can then use these to proactively deprioritize workers that might be in scope for interruption sooner.
Does this PR introduce any user-facing change?
new rest api
How was this patch tested?
added unit tests.