[CELEBORN-2020][FOLLOWUP] Fix CLI master commands authentication testing #3303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
approved these changes
Jun 3, 2025
RexXiong
approved these changes
Jun 3, 2025
SteNicholas
pushed a commit
that referenced
this pull request
Jun 3, 2025
### What changes were proposed in this pull request? Fix the remaining master sub commands that does not transfer auth header. ### Why are the changes needed? Before, this mistake was not detected by GA. Because the authentication configs was not trasnferred when setting mini celeborn cluster. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT. Closes #3303 from turboFei/auth_header_followup. Authored-by: Wang, Fei <[email protected]> Signed-off-by: 子懿 <[email protected]> (cherry picked from commit 5a50686) Signed-off-by: 子懿 <[email protected]>
|
Thanks. Merged to main(v0.7.0) and branch-0.6(v0.6.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the remaining master sub commands that does not transfer auth header.
Why are the changes needed?
Before, this mistake was not detected by GA.
Because the authentication configs was not trasnferred when setting mini celeborn cluster.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.