Add span for Expr::TypedString
#1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have need to get the location info of an
Expr::TypedStringbut this currently returns aValuerather than aValueWithSpan. I saw that the parser already has access to this information. So this is a small PR changes Expr::TypedString to use a ValueWithSpan.I have also updated the test cases and docs.
One issue with this PR is that the I've used
Span::empty()in the test cases and it still passed. Looking at a PG test more closely the span was being filled with non-zero locations. Checking another PG test it seemed that span tests were skipped by using pattern matching; I didn't want to do this because I wanted to avoid accidentally change the tests. Or it might be fine as it is. Let me know how you'd like to deal with this.