HDDS-2573. Handle InterruptedException in KeyOutputStream. #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxorm
reviewed
Nov 23, 2019
| @@ -364,6 +364,7 @@ private void handleRetry(IOException exception, long len) throws IOException { | |||
| try { | |||
| Thread.sleep(action.delayMillis); | |||
| } catch (InterruptedException e) { | |||
| Thread.currentThread().interrupt(); | |||
There was a problem hiding this comment.
LGTM.
I build it and work well.
Waiting the retest.
|
/retest |
|
The acceptance tests are timing out. This happened twice in a row in the github actions. I will run tests locally on my box and if it works I will commit these changes. |
|
Yes, this is timeout is a known problem and I try to identify the root cause. Unfortunately it's flaky, hard to reproduce. I triggered a new build and will commit this patch if it works. |
|
@elek Thank you, that retrigger worked well. You have golden hands. I have just committed the change to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-m5KcVY8lQ4ZsAc&open=AW5md-m5KcVY8lQ4ZsAc
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2573
How was this patch tested?
Simple change, no testing done.