Skip to content

HDDS-6108. Add slf4j and log4j.properties for tests in hadoop-ozone/client #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

jojochuang
Copy link
Contributor

@jojochuang jojochuang commented Dec 15, 2021

What changes were proposed in this pull request?

Add slf4j and log4j.properties for tests in the hadoop-ozone/client module.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6108

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

@adoroszlai adoroszlai changed the title Add slf4j and log4j.properties for tests in the hadoop-ozone/client module HDDS-6108. Add slf4j and log4j.properties for tests in hadoop-ozone/client Dec 15, 2021
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file you added is in:

hadoop-ozone/client/src/main/resources/log4j.properties

Do you want to keep it in src/main or move tosrc/test.
Checked the code mostly it is test dir only:
image

@adoroszlai adoroszlai requested a review from ayushtkn January 3, 2022 09:53
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adoroszlai adoroszlai merged commit 144e982 into apache:master Jan 4, 2022
@adoroszlai
Copy link
Contributor

Thanks @jojochuang for the patch, @ayushtkn for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants