Skip to content

HDDS-2753. Test OM Volume and Bucket operations are idempotent. #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hanishakoneru
Copy link
Contributor

What changes were proposed in this pull request?

On OM restarts, it is possible that already applied ratis logs will be replayed. Hence, we need to ensure that all OM write operations are idempotent.
This Jira aims to add unit tests for testing that OM volume and bucket related operations are idempotent.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2753

How was this patch tested?

This Jira is for adding a unit test.

@cxorm
Copy link
Member

cxorm commented Dec 28, 2019

Thanks @hanishakoneru for the PR.
Some violations detected by checkstyle.

@bshashikant
Copy link
Contributor

Thanks @hanishakoneru for working on this. Instead of exposing a public API to force set last AppliedTermIndex on stateMachine, we can just do some operations, trigger a ratis snapshhot , do some more operations and restart. It will ensure replay will happen from lastSnapshotIndex?

Is there any specific need to add an api to force set lastAppliedIndex?

@elek
Copy link
Member

elek commented Apr 17, 2020

/pending Waiting for the answer of the author

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Waiting for the answer of the author

@adoroszlai
Copy link
Contributor

/close

@github-actions
Copy link

Thank you very much for the patch. I am closing this PR temporarily as there was no
activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel.

@github-actions github-actions bot closed this Jul 14, 2020
@hanishakoneru hanishakoneru deleted the HDDS-2753 branch December 1, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants