HDDS-8887. Support --all option in ListOptions. #4931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adoroszlai, Please help to review, Thanks. |
adoroszlai
reviewed
Jun 19, 2023
There was a problem hiding this comment.
Thanks @ashishkumar50 for the patch, mostly looks good.
Please also consider making --length and --all mutually exclusive.
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/volume/ListVolumeHandler.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/ListOptions.java
Outdated
Show resolved
Hide resolved
@adoroszlai, Thanks for the suggestion, Updated to use "mutually exclusive" and tested. |
adoroszlai
approved these changes
Jun 19, 2023
|
Thanks @ashishkumar50 for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently ListOptions provide -l option to override number of results return.
In this PR providing a way to return all results by providing --all option applicable for command which is using ListOptions like ListVolume, ListBucket, ListKeys.
ozone sh key list --all o3://localhost:9862/vol11/bucket1[ {
"volumeName" : "vol11",
"bucketName" : "bucket1",
"name" : "key1",
"dataSize" : 0,
"creationTime" : "2023-06-19T11:04:46.584Z",
"modificationTime" : "2023-06-19T11:04:46.640Z",
"replicationConfig" : {
"replicationFactor" : "THREE",
"requiredNodes" : 3,
"replicationType" : "RATIS"
},
"metadata" : { }
}, {
"volumeName" : "vol11",
"bucketName" : "bucket1",
"name" : "key2",
"dataSize" : 0,
"creationTime" : "2023-06-19T11:04:50.748Z",
"modificationTime" : "2023-06-19T11:04:50.779Z",
"replicationConfig" : {
"replicationFactor" : "THREE",
"requiredNodes" : 3,
"replicationType" : "RATIS"
},
"metadata" : { }
} ]
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8887
How was this patch tested?
Using integration test and also local test using docker cluster.