Skip to content

HDDS-2131. Optimize replication type and creation time calculation in S3 MPU list call. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2019

Conversation

swagle
Copy link
Contributor

@swagle swagle commented Oct 17, 2019

What changes were proposed in this pull request?

Optimize listMultiPartUpload to not read from openKeyTable.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2131

How was this patch tested?

Ran related unit tests.

Copy link
Contributor

@anuengineer anuengineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. pending CI.

@swagle
Copy link
Contributor Author

swagle commented Oct 18, 2019

/retest

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also this is missing S3 end change to use the replication type and replication factor and show them in S3StorageType format.

Need to use this class for conversion. https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3StorageType.java

@swagle
Copy link
Contributor Author

swagle commented Oct 18, 2019

And also this is missing S3 end change to use the replication type and replication factor and show them in S3StorageType format.

Need to use this class for conversion. https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3StorageType.java

Thanks for pointing this one out, where does this change go?
Do you mean we should add S3StorageType to org.apache.hadoop.ozone.om.response.s3.multipart.S3InitiateMultipartUploadResponse#S3InitiateMultipartUploadResponse

@bharatviswa504
Copy link
Contributor

And also this is missing S3 end change to use the replication type and replication factor and show them in S3StorageType format.
Need to use this class for conversion. https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3StorageType.java

Thanks for pointing this one out, where does this change go?
Do you mean we should add S3StorageType to org.apache.hadoop.ozone.om.response.s3.multipart.S3InitiateMultipartUploadResponse#S3InitiateMultipartUploadResponse

This was already taken care of. Sorry I thought this is missing.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.
Can you confirm if test failures are not related to this patch.

@swagle
Copy link
Contributor Author

swagle commented Oct 22, 2019

Hi @bharatviswa504 the tests are failing since we do not have RATIS-707 fix, it is unrelated. Do you want me to rebase and push?

@bharatviswa504
Copy link
Contributor

Thank You @swagle for the verification and for the contribution and @anuengineer for the review.

@bharatviswa504 bharatviswa504 merged commit 4bfad90 into apache:master Oct 22, 2019
swamirishi added a commit to swamirishi/ozone that referenced this pull request Aug 27, 2024
…DDS-10983 (apache#50)

Co-authored-by: Swaminathan Balachandran <[email protected]>
(cherry picked from commit c41c6b1)
swamirishi added a commit to swamirishi/ozone that referenced this pull request Oct 22, 2024
…pache#50)

Change-Id: Ib8b9fb743492eacde1f11436eb3116e6a221ac9b
ptlrs pushed a commit to ptlrs/ozone that referenced this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants