-
Notifications
You must be signed in to change notification settings - Fork 537
HDDS-2131. Optimize replication type and creation time calculation in S3 MPU list call. #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… S3 MPU list call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. pending CI.
/retest |
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also this is missing S3 end change to use the replication type and replication factor and show them in S3StorageType format.
Need to use this class for conversion. https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3StorageType.java
Thanks for pointing this one out, where does this change go? |
This was already taken care of. Sorry I thought this is missing. |
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.
Can you confirm if test failures are not related to this patch.
Hi @bharatviswa504 the tests are failing since we do not have RATIS-707 fix, it is unrelated. Do you want me to rebase and push? |
Thank You @swagle for the verification and for the contribution and @anuengineer for the review. |
…DDS-10983 (apache#50) Co-authored-by: Swaminathan Balachandran <[email protected]> (cherry picked from commit c41c6b1)
…pache#50) Change-Id: Ib8b9fb743492eacde1f11436eb3116e6a221ac9b
…DDS-10983 (apache#50) Co-authored-by: Swaminathan Balachandran <[email protected]>
What changes were proposed in this pull request?
Optimize listMultiPartUpload to not read from openKeyTable.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2131
How was this patch tested?
Ran related unit tests.