HDDS-9078. Set ratis.thirdparty.io.netty.native.workdir as OZONE home temp directory #5111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@duongkame @szetszwo @sumitagrawl Please help to review. |
szetszwo
approved these changes
Jul 25, 2023
arp7
reviewed
Jul 25, 2023
| @@ -78,6 +78,7 @@ function ozonecmd_case | |||
| # This parameter significantly reduces GC pressure for Datanode. | |||
| # Corresponding Ratis issue https://issues.apache.org/jira/browse/RATIS-534. | |||
| RATIS_OPTS="-Dorg.apache.ratis.thirdparty.io.netty.allocator.useCacheForAllThreads=false ${RATIS_OPTS}" | |||
| OZONE_OPTS="-Dorg.apache.ratis.thirdparty.io.netty.native.workdir=${OZONE_HOME}/temp ${OZONE_OPTS}" | |||
There was a problem hiding this comment.
@szetszwo does this look safe to you?
There was a problem hiding this comment.
According to https://netty.io/4.0/xref/io/netty/util/internal/NativeLibraryLoader.html , the change here is to use Ozone temp dir instead of the perform temp dir. So, it seems okay.
@arp7 , do you see any problems which may occur?
ChenSammi
added a commit
that referenced
this pull request
Nov 20, 2023
ashishkumar50
added a commit
to ashishkumar50/ozone
that referenced
this pull request
Nov 20, 2023
…ONE home temp directory. (apache#5111)" This reverts commit 6db519a.
ChenSammi
pushed a commit
that referenced
this pull request
Nov 20, 2023
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Feb 1, 2024
…orkdir as OZONE home temp directory. (apache#5111)" (apache#5630) (cherry picked from commit 9934cd6) Change-Id: Iab760d08fdab16b7c500db3a9d0d5e9b8617d34b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When there is noexec permission on /tmp directory, While executing ozone shell it prompts warning related to netty working directory.
/tmp/liborg_apache_ratis_thirdparty_netty_transport_native_epoll_x86_646071388068053995247.so exists but cannot be executed even when execute permissions set; check volume for "noexec" flag; use -Dorg.apache.ratis.thirdparty.io.netty.native.workdir=[path] to set native working directory separately.In this PR moving netty working directory inside Ozone home temp directory.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9078
How was this patch tested?
Verification pending in cluster