HDDS-9216. Update log in exception while processing ICR for container. #5226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szetszwo, Please help to review. |
sumitagrawl
approved these changes
Aug 28, 2023
sodonnel
reviewed
Aug 29, 2023
...cm/src/main/java/org/apache/hadoop/hdds/scm/container/IncrementalContainerReportHandler.java
Outdated
Show resolved
Hide resolved
szetszwo
reviewed
Aug 29, 2023
...cm/src/main/java/org/apache/hadoop/hdds/scm/container/IncrementalContainerReportHandler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Not leader log was changed in HDDS-6241 when there is exception during ICR. But in HDDS-8934 not leader exception is wrapped inside SCMException. Now it is not getting caught in
NotLeaderException. In this PR updating the log for SCM_NOT_LEADER exception.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9216
How was this patch tested?
Just logging changed, no test impact.