Skip to content

HDDS-9846. Datanode should not persist cluster ID to global version file until loading all volumes. #5757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

ashishkumar50
Copy link
Contributor

What changes were proposed in this pull request?

Update cluster ID to global version file after loading all the volumes in DN. In case if cluster ID in volume level version files doesn't match with the SCM cluster ID, In this case avoid updating cluster ID in DN global version file.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9846

How was this patch tested?

Unit test

@ashishkumar50
Copy link
Contributor Author

@errose28 Can you please help to review.

@kerneltime kerneltime requested a review from errose28 December 11, 2023 17:13
Copy link
Contributor

@aryangupta1998 aryangupta1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ChenSammi ChenSammi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashishkumar50 .

@ChenSammi ChenSammi merged commit 027febe into apache:master Dec 15, 2023
VarshaRaviCV pushed a commit to VarshaRaviCV/ozone that referenced this pull request Dec 18, 2023
adoroszlai pushed a commit to adoroszlai/ozone that referenced this pull request Jan 25, 2024
…ile until loading all volumes. (apache#5757)

(cherry picked from commit 027febe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants