HDDS-3090. Fix logging in OMFileRequest and OzoneManager #612
Conversation
| @@ -175,8 +175,8 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, | |||
| // if isRecursive is true, file would be created even if parent | |||
| // directories does not exist. | |||
| boolean isRecursive = createFileRequest.getIsRecursive(); | |||
| LOG.info("File create for : " + volumeName + "/" + bucketName + "/" | |||
| + keyName + ":" + isRecursive); | |||
| LOG.trace("File create for {}/{}/{}, recursive : {}", volumeName, | |||
There was a problem hiding this comment.
{}/{}/{} -> /{}/{}/{},
| @@ -92,8 +92,8 @@ public static OMPathInfo verifyFilesInPath( | |||
| result = OMDirectoryResult.DIRECTORY_EXISTS_IN_GIVENPATH; | |||
| inheritAcls = omMetadataManager.getKeyTable().get(dbDirKeyName) | |||
| .getAcls(); | |||
| LOG.trace("Acls inherited from parent " + dbDirKeyName + " are : " | |||
| + inheritAcls); | |||
| LOG.trace("Acls inherited from parent dir {}, are : {}", | |||
There was a problem hiding this comment.
Add LOG.isTraceEnabled()
| @@ -113,12 +113,12 @@ public static OMPathInfo verifyFilesInPath( | |||
| if (inheritAcls.isEmpty()) { | |||
| String bucketKey = omMetadataManager.getBucketKey(volumeName, bucketName); | |||
| inheritAcls = omMetadataManager.getBucketTable().get(bucketKey).getAcls(); | |||
| LOG.trace("Acls inherited from bucket " + bucketName + " are : " | |||
| + inheritAcls); | |||
| LOG.trace("Acls inherited from bucket {} are : {}", bucketName, | |||
There was a problem hiding this comment.
Add LOG.isTraceEnabled()
|
/pending Review comments are not yet addressed. |
|
/close |
|
Thank you very much for the patch. I am closing this PR temporarily as there was no It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time. It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs. If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel. |
What changes were proposed in this pull request?
parameterized some logs introduced in HDDS-2940. Corrected log levels.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3090
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
Executed Ozone FS interface unit tests. Only modified log messages.