Skip to content

HDDS-11070. Separate KeyCodec from reading and storing keys to disk #6871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 21, 2025
Merged

HDDS-11070. Separate KeyCodec from reading and storing keys to disk #6871

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b4be6b8
HDDS-11070. Separate KeyCodec responsibilities of being a coder/decod…
Galsza Jun 26, 2024
c9836f8
Addendum for HDDS-11070.
fapifta Dec 6, 2024
2296f9b
Fix conflicts with master and testcases
Galsza Dec 19, 2024
8509bdb
Merge branch 'master' into HDDS-11070
Galsza Dec 19, 2024
6c75d4f
Address review comments
Galsza Dec 19, 2024
ec1c198
Add test for rewriting a key
Galsza Jan 13, 2025
f264cf8
Fix typo in test name
Galsza Jan 15, 2025
87cdc72
Merge remote-tracking branch 'origin/master' into HDDS-11070
adoroszlai Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo in test name
  • Loading branch information
@Galsza
Galsza committed Jan 15, 2025
commit f264cf86dd52eb065dc575f43f6997bfe7c4ea29
2 changes: 1 addition & 1 deletion ...p-hdds/common/src/test/java/org/apache/hadoop/hdds/security/x509/keys/TestKeyStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ public void testReadKeyFailToWrite() throws Exception {

@Test
@DisplayName("an attempt to overwrite an internal key throws FileAlreadyExists exception.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo? testExternalKeysAreNotOverWritable -> testInternalKeysAreNotOverWritable?

public void testExternalKeysAreNotOverWritable() throws Exception {
public void testInternalKeysAreNotOverWritable() throws Exception {
KeyStorage storage = new KeyStorage(config, COMPONENT);
storage.storePublicKey(keys.getPublic());
storage.storePrivateKey(keys.getPrivate());
Expand Down
Loading