HDDS-11420. OM rocksdb manual WAL flush control #7165
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks related to #7150. Once Ozone supports RocksDB INI files we should not need to propagate RocksDB configs up to Ozone, but instead can ship with default RocksDB config files that contain our recommended practices. Since we don't need this in master immediately, I would wait until that switch to INI files completes. |
|
If this config is set to false, when does the WAL flush occur and how is it triggered? |
juncevich
reviewed
Sep 24, 2024
| <property> | ||
| <name>ozone.om.rocksdb.manual.wal.flush</name> | ||
| <value>false</value> | ||
| <tag>OZONE, OM</tag> |
There was a problem hiding this comment.
Is it ok to have different tags between ozone.om.rocksdb.manual.wal.flush and rocksdb.manual_wal_flush? (OZONE, OM, OM, SCM, DATANODE). Can ozone.om.rocksdb.manual.wal.flush also have tag DATANODE? Or rocksdb.manual_wal_flush doesn't have tag DATANODE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Capability is added to disable WAL manual flush of rocksdb for OM. There is no change in behavior but added for performance test purpose.
As ratis log itself provide recovery, WAL log provide duplicate mechanism. This is added for planned for Leader Side execution of request as performance optimization.
Parent JIRA:
https://issues.apache.org/jira/browse/HDDS-11415
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11420
How was this patch tested?