Skip to content

HDDS-11463. Track and display failed DataNode storage locations in SCM. #7266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
+875 −10
Open

HDDS-11463. Track and display failed DataNode storage locations in SCM. #7266

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
41afe7c
HDDS-11463. Track and display failed DataNode storage locations in SCM.
slfan1989 May 22, 2025
a39ae2f
HDDS-11463. Improve Some Code.
slfan1989 May 23, 2025
e973492
HDDS-11463. Improve Some Code.
slfan1989 May 23, 2025
f58bad4
HDDS-11463. Improve Some Code.
slfan1989 May 23, 2025
7b07957
HDDS-11463. Fix CheckStyle.
slfan1989 May 23, 2025
33b9f0e
HDDS-11463. Fix CheckStyle.
slfan1989 May 23, 2025
0381c37
HDDS-11463. Fix CheckStyle.
slfan1989 May 23, 2025
4ddc7c5
HDDS-11463. Improve Some Code.
slfan1989 May 29, 2025
92e1169
HDDS-11463. Improve Some Code.
slfan1989 May 29, 2025
5d637fa
HDDS-11463. Improve Some Code.
slfan1989 May 29, 2025
a8efdd3
HDDS-11463. Fix CheckStyle.
slfan1989 May 29, 2025
07370b7
Merge branch 'apache:master' into HDDS-11463
slfan1989 May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
HDDS-11463. Fix CheckStyle.
  • Loading branch information
@slfan1989
slfan1989 committed May 23, 2025
commit 0381c373c75ff226c3d584fbe92869e0f0b09a4f
4 changes: 2 additions & 2 deletions ...one/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/VolumeSubCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ public class VolumeSubCommand extends ScmSubcommand {
private SimpleDateFormat sdf = new SimpleDateFormat(
"EEE MMM dd HH:mm:ss Z yyyy", Locale.ENGLISH);

enum DISPLAYMODE { all, normal, failed }

/**
* We have designed a new option called 'show',
* which includes two selectable configurations:
Expand Down Expand Up @@ -96,6 +94,8 @@ enum DISPLAYMODE { all, normal, failed }
@CommandLine.Mixin
private ListPaginationOptions listOptions;

enum DISPLAYMODE { all, normal, failed }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Enums should be named like other types (classes, interfaces): DisplayMode.

Also, please consider using all-caps for values (ALL, etc.)


@Override
public void execute(ScmClient client) throws IOException {

Expand Down