HDDS-11895. Separate Root and Sub CA server implementation #7573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and handling persistence of keys
Purify KeyCodec and KeyStorage APIs, clear/add tests for the remaining pieces. Remove SecurityUtil, replace its functionality with the KeyCodec. KeyCodec now works with byte[] instead of String. KeyStorage relies purely on NIO. Keys related classes moved to hdds-common from hdds-framework. Intorduced SecurityConstants for string based magic constants in the PEM format. Changes in SecurityConfig to ensure testability. Updated APIDocs.
|
@ChenSammi Could you please review #6871 and this PR as well? |
|
Let's review #6871 first and get it merged. |
# Conflicts: # hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/keys/KeyStorage.java # hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/security/x509/keys/TestKeyStorage.java # hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/OzoneSecretKey.java # hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/authority/DefaultCAServer.java # hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java # hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/security/x509/certificate/authority/TestDefaultCAServer.java # hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/lease/package-info.java
|
Temporarily converted to draft and assigned to myself, to resolve conflicts. |
|
/pending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Separate the root and sub ca server implementation for better readability
[HDDS-11895](https://issues.apache.org/jira/browse/HDDS-11895
As an ongoing process for crypto-currency, the PKI system is a bit refactored.
This PR is built on a previous PR: #6871 that should be merged first.
That PR contains changes regarding KeyStorage, this PR only aims at the separation of CA servers.
HDDS-11895
How was this patch tested?
Existing CI tests, green CI apart from previous PR failure:
https://github.com/Galsza/ozone/actions/runs/12304108495